This was originally fixed in #35976, but one of the window.scrollY assertions was missed. Also updated tests to use toBeGreater/LessThan to improve failure messages. PR Close #36742
		
			
				
	
	
		
			332 lines
		
	
	
		
			11 KiB
		
	
	
	
		
			TypeScript
		
	
	
	
	
	
			
		
		
	
	
			332 lines
		
	
	
		
			11 KiB
		
	
	
	
		
			TypeScript
		
	
	
	
	
	
| /**
 | |
|  * @license
 | |
|  * Copyright Google Inc. All Rights Reserved.
 | |
|  *
 | |
|  * Use of this source code is governed by an MIT-style license that can be
 | |
|  * found in the LICENSE file at https://angular.io/license
 | |
|  */
 | |
| 
 | |
| import {APP_BASE_HREF, DOCUMENT, Location, ɵgetDOM as getDOM} from '@angular/common';
 | |
| import {ApplicationRef, Component, CUSTOM_ELEMENTS_SCHEMA, destroyPlatform, NgModule} from '@angular/core';
 | |
| import {inject} from '@angular/core/testing';
 | |
| import {BrowserModule} from '@angular/platform-browser';
 | |
| import {platformBrowserDynamic} from '@angular/platform-browser-dynamic';
 | |
| import {NavigationEnd, Resolve, Router, RouterModule} from '@angular/router';
 | |
| import {filter, first} from 'rxjs/operators';
 | |
| 
 | |
| describe('bootstrap', () => {
 | |
|   if (isNode) return;
 | |
|   let log: any[] = [];
 | |
|   let testProviders: any[] = null!;
 | |
| 
 | |
|   @Component({selector: 'test-app', template: 'root <router-outlet></router-outlet>'})
 | |
|   class RootCmp {
 | |
|     constructor() {
 | |
|       log.push('RootCmp');
 | |
|     }
 | |
|   }
 | |
| 
 | |
|   @Component({selector: 'test-app2', template: 'root <router-outlet></router-outlet>'})
 | |
|   class SecondRootCmp {
 | |
|   }
 | |
| 
 | |
|   class TestResolver implements Resolve<any> {
 | |
|     resolve() {
 | |
|       let resolve: any = null;
 | |
|       const res = new Promise(r => resolve = r);
 | |
|       setTimeout(() => resolve('test-data'), 0);
 | |
|       return res;
 | |
|     }
 | |
|   }
 | |
| 
 | |
|   beforeEach(inject([DOCUMENT], (doc: any) => {
 | |
|     destroyPlatform();
 | |
| 
 | |
|     const el1 = getDOM().createElement('test-app', doc);
 | |
|     const el2 = getDOM().createElement('test-app2', doc);
 | |
|     doc.body.appendChild(el1);
 | |
|     doc.body.appendChild(el2);
 | |
| 
 | |
|     log = [];
 | |
|     testProviders = [{provide: APP_BASE_HREF, useValue: ''}];
 | |
|   }));
 | |
| 
 | |
|   afterEach(inject([DOCUMENT], (doc: any) => {
 | |
|     const oldRoots = doc.querySelectorAll('test-app,test-app2');
 | |
|     for (let i = 0; i < oldRoots.length; i++) {
 | |
|       getDOM().remove(oldRoots[i]);
 | |
|     }
 | |
|   }));
 | |
| 
 | |
|   it('should wait for resolvers to complete when initialNavigation = enabled', (done) => {
 | |
|     @Component({selector: 'test', template: 'test'})
 | |
|     class TestCmpEnabled {
 | |
|     }
 | |
| 
 | |
|     @NgModule({
 | |
|       imports: [
 | |
|         BrowserModule,
 | |
|         RouterModule.forRoot(
 | |
|             [{path: '**', component: TestCmpEnabled, resolve: {test: TestResolver}}],
 | |
|             {useHash: true, initialNavigation: 'enabled'})
 | |
|       ],
 | |
|       declarations: [RootCmp, TestCmpEnabled],
 | |
|       bootstrap: [RootCmp],
 | |
|       providers: [...testProviders, TestResolver],
 | |
|       schemas: [CUSTOM_ELEMENTS_SCHEMA]
 | |
|     })
 | |
|     class TestModule {
 | |
|       constructor(router: Router) {
 | |
|         log.push('TestModule');
 | |
|         router.events.subscribe(e => log.push(e.constructor.name));
 | |
|       }
 | |
|     }
 | |
| 
 | |
|     platformBrowserDynamic([]).bootstrapModule(TestModule).then(res => {
 | |
|       const router = res.injector.get(Router);
 | |
|       const data = router.routerState.snapshot.root.firstChild!.data;
 | |
|       expect(data['test']).toEqual('test-data');
 | |
|       expect(log).toEqual([
 | |
|         'TestModule', 'NavigationStart', 'RoutesRecognized', 'GuardsCheckStart',
 | |
|         'ChildActivationStart', 'ActivationStart', 'GuardsCheckEnd', 'ResolveStart', 'ResolveEnd',
 | |
|         'RootCmp', 'ActivationEnd', 'ChildActivationEnd', 'NavigationEnd', 'Scroll'
 | |
|       ]);
 | |
|       done();
 | |
|     });
 | |
|   });
 | |
| 
 | |
|   it('should NOT wait for resolvers to complete when initialNavigation = legacy_enabled',
 | |
|      (done) => {
 | |
|        @Component({selector: 'test', template: 'test'})
 | |
|        class TestCmpLegacyEnabled {
 | |
|        }
 | |
| 
 | |
|        @NgModule({
 | |
|          imports: [
 | |
|            BrowserModule,
 | |
|            RouterModule.forRoot(
 | |
|                [{path: '**', component: TestCmpLegacyEnabled, resolve: {test: TestResolver}}],
 | |
|                {useHash: true, initialNavigation: 'legacy_enabled'})
 | |
|          ],
 | |
|          declarations: [RootCmp, TestCmpLegacyEnabled],
 | |
|          bootstrap: [RootCmp],
 | |
|          providers: [...testProviders, TestResolver],
 | |
|          schemas: [CUSTOM_ELEMENTS_SCHEMA]
 | |
|        })
 | |
|        class TestModule {
 | |
|          constructor(router: Router) {
 | |
|            log.push('TestModule');
 | |
|            router.events.subscribe(e => log.push(e.constructor.name));
 | |
|          }
 | |
|        }
 | |
| 
 | |
|        platformBrowserDynamic([]).bootstrapModule(TestModule).then(res => {
 | |
|          const router: Router = res.injector.get(Router);
 | |
|          expect(router.routerState.snapshot.root.firstChild).toBeNull();
 | |
|          // ResolveEnd has not been emitted yet because bootstrap returned too early
 | |
|          expect(log).toEqual([
 | |
|            'TestModule', 'RootCmp', 'NavigationStart', 'RoutesRecognized', 'GuardsCheckStart',
 | |
|            'ChildActivationStart', 'ActivationStart', 'GuardsCheckEnd', 'ResolveStart'
 | |
|          ]);
 | |
| 
 | |
|          router.events.subscribe((e) => {
 | |
|            if (e instanceof NavigationEnd) {
 | |
|              done();
 | |
|            }
 | |
|          });
 | |
|        });
 | |
|      });
 | |
| 
 | |
|   it('should not run navigation when initialNavigation = disabled', (done) => {
 | |
|     @Component({selector: 'test', template: 'test'})
 | |
|     class TestCmpDiabled {
 | |
|     }
 | |
| 
 | |
|     @NgModule({
 | |
|       imports: [
 | |
|         BrowserModule,
 | |
|         RouterModule.forRoot(
 | |
|             [{path: '**', component: TestCmpDiabled, resolve: {test: TestResolver}}],
 | |
|             {useHash: true, initialNavigation: 'disabled'})
 | |
|       ],
 | |
|       declarations: [RootCmp, TestCmpDiabled],
 | |
|       bootstrap: [RootCmp],
 | |
|       providers: [...testProviders, TestResolver],
 | |
|       schemas: [CUSTOM_ELEMENTS_SCHEMA]
 | |
|     })
 | |
|     class TestModule {
 | |
|       constructor(router: Router) {
 | |
|         log.push('TestModule');
 | |
|         router.events.subscribe(e => log.push(e.constructor.name));
 | |
|       }
 | |
|     }
 | |
| 
 | |
|     platformBrowserDynamic([]).bootstrapModule(TestModule).then(res => {
 | |
|       const router = res.injector.get(Router);
 | |
|       expect(log).toEqual(['TestModule', 'RootCmp']);
 | |
|       done();
 | |
|     });
 | |
|   });
 | |
| 
 | |
|   it('should not run navigation when initialNavigation = legacy_disabled', (done) => {
 | |
|     @Component({selector: 'test', template: 'test'})
 | |
|     class TestCmpLegacyDisabled {
 | |
|     }
 | |
| 
 | |
|     @NgModule({
 | |
|       imports: [
 | |
|         BrowserModule,
 | |
|         RouterModule.forRoot(
 | |
|             [{path: '**', component: TestCmpLegacyDisabled, resolve: {test: TestResolver}}],
 | |
|             {useHash: true, initialNavigation: 'legacy_disabled'})
 | |
|       ],
 | |
|       declarations: [RootCmp, TestCmpLegacyDisabled],
 | |
|       bootstrap: [RootCmp],
 | |
|       providers: [...testProviders, TestResolver],
 | |
|       schemas: [CUSTOM_ELEMENTS_SCHEMA]
 | |
|     })
 | |
|     class TestModule {
 | |
|       constructor(router: Router) {
 | |
|         log.push('TestModule');
 | |
|         router.events.subscribe(e => log.push(e.constructor.name));
 | |
|       }
 | |
|     }
 | |
| 
 | |
|     platformBrowserDynamic([]).bootstrapModule(TestModule).then(res => {
 | |
|       const router = res.injector.get(Router);
 | |
|       expect(log).toEqual(['TestModule', 'RootCmp']);
 | |
|       done();
 | |
|     });
 | |
|   });
 | |
| 
 | |
|   it('should not init router navigation listeners if a non root component is bootstrapped',
 | |
|      (done) => {
 | |
|        @NgModule({
 | |
|          imports: [BrowserModule, RouterModule.forRoot([], {useHash: true})],
 | |
|          declarations: [SecondRootCmp, RootCmp],
 | |
|          entryComponents: [SecondRootCmp],
 | |
|          bootstrap: [RootCmp],
 | |
|          providers: testProviders,
 | |
|          schemas: [CUSTOM_ELEMENTS_SCHEMA]
 | |
|        })
 | |
|        class TestModule {
 | |
|        }
 | |
| 
 | |
|        platformBrowserDynamic([]).bootstrapModule(TestModule).then(res => {
 | |
|          const router = res.injector.get(Router);
 | |
|          spyOn(router as any, 'resetRootComponentType').and.callThrough();
 | |
| 
 | |
|          const appRef: ApplicationRef = res.injector.get(ApplicationRef);
 | |
|          appRef.bootstrap(SecondRootCmp);
 | |
| 
 | |
|          expect((router as any).resetRootComponentType).not.toHaveBeenCalled();
 | |
| 
 | |
|          done();
 | |
|        });
 | |
|      });
 | |
| 
 | |
|   it('should reinit router navigation listeners if a previously bootstrapped root component is destroyed',
 | |
|      (done) => {
 | |
|        @NgModule({
 | |
|          imports: [BrowserModule, RouterModule.forRoot([], {useHash: true})],
 | |
|          declarations: [SecondRootCmp, RootCmp],
 | |
|          entryComponents: [SecondRootCmp],
 | |
|          bootstrap: [RootCmp],
 | |
|          providers: testProviders,
 | |
|          schemas: [CUSTOM_ELEMENTS_SCHEMA]
 | |
|        })
 | |
|        class TestModule {
 | |
|        }
 | |
| 
 | |
|        platformBrowserDynamic([]).bootstrapModule(TestModule).then(res => {
 | |
|          const router = res.injector.get(Router);
 | |
|          spyOn(router as any, 'resetRootComponentType').and.callThrough();
 | |
| 
 | |
|          const appRef: ApplicationRef = res.injector.get(ApplicationRef);
 | |
|          appRef.components[0].onDestroy(() => {
 | |
|            appRef.bootstrap(SecondRootCmp);
 | |
|            expect((router as any).resetRootComponentType).toHaveBeenCalled();
 | |
|            done();
 | |
|          });
 | |
| 
 | |
|          appRef.components[0].destroy();
 | |
|        });
 | |
|      });
 | |
| 
 | |
| 
 | |
|   it('should restore the scrolling position', async (done) => {
 | |
|     @Component({
 | |
|       selector: 'component-a',
 | |
|       template: `
 | |
|            <div style="height: 3000px;"></div>
 | |
|            <div id="marker1"></div>
 | |
|            <div style="height: 3000px;"></div>
 | |
|            <div id="marker2"></div>
 | |
|            <div style="height: 3000px;"></div>
 | |
|            <a name="marker3"></a>
 | |
|            <div style="height: 3000px;"></div>
 | |
|       `
 | |
|     })
 | |
|     class TallComponent {
 | |
|     }
 | |
|     @NgModule({
 | |
|       imports: [
 | |
|         BrowserModule,
 | |
|         RouterModule.forRoot(
 | |
|             [
 | |
|               {path: '', pathMatch: 'full', redirectTo: '/aa'},
 | |
|               {path: 'aa', component: TallComponent}, {path: 'bb', component: TallComponent},
 | |
|               {path: 'cc', component: TallComponent},
 | |
|               {path: 'fail', component: TallComponent, canActivate: ['returnFalse']}
 | |
|             ],
 | |
|             {
 | |
|               useHash: true,
 | |
|               scrollPositionRestoration: 'enabled',
 | |
|               anchorScrolling: 'enabled',
 | |
|               scrollOffset: [0, 100],
 | |
|               onSameUrlNavigation: 'reload'
 | |
|             })
 | |
|       ],
 | |
|       declarations: [TallComponent, RootCmp],
 | |
|       bootstrap: [RootCmp],
 | |
|       providers: [...testProviders, {provide: 'returnFalse', useValue: () => false}],
 | |
|       schemas: [CUSTOM_ELEMENTS_SCHEMA]
 | |
|     })
 | |
|     class TestModule {
 | |
|     }
 | |
| 
 | |
|     const res = await platformBrowserDynamic([]).bootstrapModule(TestModule);
 | |
|     const router = res.injector.get(Router);
 | |
| 
 | |
|     await router.navigateByUrl('/aa');
 | |
|     window.scrollTo(0, 5000);
 | |
| 
 | |
|     // IE 9/10/11 use non-standard pageYOffset instead of scrollY
 | |
|     const getScrollY = () => window.scrollY !== undefined ? window.scrollY : window.pageYOffset;
 | |
| 
 | |
|     await router.navigateByUrl('/fail');
 | |
|     expect(getScrollY()).toEqual(5000);
 | |
| 
 | |
|     await router.navigateByUrl('/bb');
 | |
|     window.scrollTo(0, 3000);
 | |
| 
 | |
|     expect(getScrollY()).toEqual(3000);
 | |
| 
 | |
|     await router.navigateByUrl('/cc');
 | |
|     expect(getScrollY()).toEqual(0);
 | |
| 
 | |
|     await router.navigateByUrl('/aa#marker2');
 | |
|     expect(getScrollY()).toBeGreaterThanOrEqual(5900);
 | |
|     expect(getScrollY()).toBeLessThan(6000);  // offset
 | |
| 
 | |
|     await router.navigateByUrl('/aa#marker3');
 | |
|     expect(getScrollY()).toBeGreaterThanOrEqual(8900);
 | |
|     expect(getScrollY()).toBeLessThan(9000);
 | |
|     done();
 | |
|   });
 | |
| 
 | |
|   function waitForNavigationToComplete(router: Router): Promise<any> {
 | |
|     return router.events.pipe(filter((e: any) => e instanceof NavigationEnd), first()).toPromise();
 | |
|   }
 | |
| });
 |