3938563565
ngtsc previously could attempt to reuse the main ts.Program twice. This occurred when template type-checking was enabled and then an incremental build was performed. This breaks a TypeScript invariant - ts.Programs can only be reused once. The creation of the template type-checking program reuses the main program, rendering it moot. Then, on the next incremental build the main program would be subject to reuse again, which would crash inside TypeScript. This commit fixes the issue by reusing the template type-checking program from the previous run on the next incremental build. Since under normal circumstances the files in the type-checking program aren't changed, this should be just as fast. Testing strategy: a test is added in the incremental_spec which validates that program reuse with type-checking turned on does not crash the compiler. Fixes #30079 PR Close #30090 |
||
|---|---|---|
| .. | ||
| compliance | ||
| diagnostics | ||
| metadata | ||
| ngtsc | ||
| transformers | ||
| BUILD.bazel | ||
| extract_i18n_spec.ts | ||
| mocks.ts | ||
| ngc_spec.ts | ||
| ngtools_api_spec.ts | ||
| perform_compile_spec.ts | ||
| perform_watch_spec.ts | ||
| runfile_helpers.ts | ||
| test_support.ts | ||