d5b87d32b0
Currently Ivy stores the element attributes into an array above the component def and passes it into the relevant instructions, however the problem is that upon minification the array will get a unique name which won't compress very well. These changes move the attributes array into the component def and pass in the index into the instructions instead.
Before:
```
const _c0 = ['foo', 'bar'];
SomeComp.ngComponentDef = defineComponent({
template: function() {
element(0, 'div', _c0);
}
});
```
After:
```
SomeComp.ngComponentDef = defineComponent({
consts: [['foo', 'bar']],
template: function() {
element(0, 'div', 0);
}
});
```
A couple of cases that this PR doesn't handle:
* Template references are still in a separate array.
* i18n attributes are still in a separate array.
PR Close #32798
|
||
|---|---|---|
| .. | ||
| element_text_create | ||
| interpolation | ||
| listeners | ||
| map_based_style_and_class_bindings | ||
| noop_change_detection | ||
| property_binding | ||
| property_binding_update | ||
| style_and_class_bindings | ||
| style_binding | ||
| BUILD.bazel | ||
| README.md | ||
| micro_bench.ts | ||
| noop_renderer.ts | ||
| setup.ts | ||
README.md
Build
yarn bazel build //packages/core/test/render3/perf:{name}.min_debug.es2015.js --define=compile=aot
Run
node dist/bin/packages/core/test/render3/perf/{name}.min_debug.es2015.js
Profile
node --no-turbo-inlining --inspect-brk dist/bin/packages/core/test/render3/perf/{name}.min_debug.es2015.js
then connect with a debugger (the --inspect-brk option will make sure that benchmark execution doesn't start until a debugger is connected and the code execution is manually resumed).
The actual benchmark code has calls that will start (console.profile) and stop (console.profileEnd) a profiling session.
Notes
In all the above commands {name} should be replaced with the actual benchmark (folder) name, ex.:
- build:
yarn bazel build //packages/core/test/render3/perf:noop_change_detection.min_debug.es2015.js --define=compile=aot - run:
time node dist/bin/packages/core/test/render3/perf/noop_change_detection.min_debug.es2015.js - profile:
node --no-turbo-inlining --inspect-brk dist/bin/packages/core/test/render3/perf/noop_change_detection.min_debug.es2015.js profile