angular-cn/packages/core/test/acceptance
Kara Erickson 1a0ee18d62 fix(ivy): run pre-order hooks in injection order (#34026)
This commit fixes a compatibility bug where pre-order lifecycle
hooks (onInit, doCheck, OnChanges) for directives on the same
host node were executed based on the order the directives were
matched, rather than the order the directives were instantiated
(i.e. injection order).

This discrepancy can cause issues with forms, where it is common
to inject NgControl and try to extract its control property in
ngOnInit. As the NgControl directive is injected, it should be
instantiated before the control value accessor directive (and
thus its hooks should run first). This ensures that the NgControl
ngOnInit can set up the form control before the ngOnInit
for the control value accessor tries to access it.

Closes #32522

PR Close #34026
2019-11-25 18:41:22 -05:00
..
BUILD.bazel build: ts_web_test & ts_web_test_suite deprecated in favor of karma_web_test & karma_web_test_suite (#33802) 2019-11-13 13:33:38 -08:00
attributes_spec.ts refactor(core): Migrate TestBed.get to TestBed.inject (#32382) 2019-09-09 19:10:54 -04:00
bootstrap_spec.ts fix(ivy): support for #id bootstrap selectors (#33784) 2019-11-15 10:42:52 -08:00
change_detection_spec.ts perf(ivy): Improve performance of transplanted views (#33702) 2019-11-14 09:27:58 -08:00
common_integration_spec.ts test(ivy): move common integration tests to acceptance (#30213) 2019-05-14 11:37:50 -07:00
component_spec.ts fix(ivy): ComponentFactory.create should clear host element content (#33487) 2019-11-12 21:34:06 -08:00
content_spec.ts fix(ivy): include `ngProjectAs` into attributes array (#32784) 2019-09-27 10:12:18 -07:00
copy_definition_feature_spec.ts feat(ivy): add a runtime feature to copy cmp/dir definitions (#33362) 2019-10-25 09:16:50 -07:00
debug_spec.ts refactor(ivy): migrate debug spec from render3 (#32621) 2019-09-12 11:35:49 -07:00
di_spec.ts fix(ivy): remove TNodeType assertion from `directiveInject` instruction (#33948) 2019-11-21 17:09:42 -05:00
directive_spec.ts fix(ivy): match directives on namespaced elements (#33555) 2019-11-07 15:40:50 +00:00
discover_utils_spec.ts test(ivy): Have more descriptive names for `LView` (#33449) 2019-11-07 15:33:50 +00:00
embedded_views_spec.ts fix(ivy): unable to bind to implicit receiver in embedded views (#30897) 2019-06-11 14:29:42 -07:00
exports_spec.ts refactor(ivy): move exports tests to acceptance (#30157) 2019-04-26 16:37:34 -07:00
host_binding_spec.ts test: clean up explicit dynamic query usages (#33015) 2019-10-17 16:10:10 -04:00
i18n_spec.ts fix(ivy): better support for i18n attributes on <ng-container>s (#33599) 2019-11-07 01:51:42 +00:00
inherit_definition_feature_spec.ts refactor(ivy): remove ngBaseDef (#33264) 2019-10-25 13:11:34 -07:00
integration_spec.ts refactor(ivy): introduce a `firstUpdatePass` flag for `TView` instances (#31270) 2019-11-04 21:39:22 +00:00
lifecycle_spec.ts fix(ivy): run pre-order hooks in injection order (#34026) 2019-11-25 18:41:22 -05:00
listener_spec.ts test: clean up explicit dynamic query usages (#33015) 2019-10-17 16:10:10 -04:00
ng_module_spec.ts feat(ivy): implement unknown element detection in jit mode (#33419) 2019-11-04 15:59:10 +00:00
ngdevmode_debug_spec.ts test(ivy): Have more descriptive names for `LView` (#33449) 2019-11-07 15:33:50 +00:00
outputs_spec.ts test: clean up explicit dynamic query usages (#33015) 2019-10-17 16:10:10 -04:00
pipe_spec.ts test: clean up explicit dynamic query usages (#33015) 2019-10-17 16:10:10 -04:00
property_binding_spec.ts refactor(core): Migrate TestBed.get to TestBed.inject (#32382) 2019-09-09 19:10:54 -04:00
property_interpolation_spec.ts refactor: fix typescript strict flag failures in all tests (#30993) 2019-07-18 14:21:26 -07:00
providers_spec.ts fix(ivy): error when using forwardRef in Injectable's useClass (#30532) 2019-07-26 14:02:49 -07:00
pure_function_spec.ts fix(ivy): constant object literals shared across element and component instances (#33705) 2019-11-13 13:36:41 -08:00
query_spec.ts test: clean up explicit dynamic query usages (#33015) 2019-10-17 16:10:10 -04:00
renderer_factory_spec.ts fix(ivy): avoid DOM element assertions if procedural renderer is used (#33156) 2019-10-15 21:03:29 +00:00
router_integration_spec.ts refactor(core): Migrate TestBed.get to TestBed.inject (#32382) 2019-09-09 19:10:54 -04:00
styling_spec.ts fix(ivy): reset style property using ngStyle fix (#33920) 2019-11-20 14:46:00 -08:00
template_ref_spec.ts test(ivy): get ViewRef.rootNodes should get all root nodes from projectable nodes (#33647) 2019-11-11 09:37:38 -08:00
text_spec.ts refactor: fix typescript strict flag failures in all tests (#30993) 2019-07-18 14:21:26 -07:00
view_container_ref_spec.ts test: clean up explicit dynamic query usages (#33015) 2019-10-17 16:10:10 -04:00
view_insertion_spec.ts test(ivy): non-regression test for ViewContainerRef queried on ng-container (#33939) 2019-11-20 14:45:43 -08:00
view_ref_spec.ts test(ivy): fix failing view ref test (#29178) 2019-03-07 18:56:22 -08:00