History

JoostK 1381301afe refactor(compiler-cli): track a dependency on a default import on WrappedNodeExpr (#41557 )

Previously, the `DefaultImportRecorder` interface was used as follows:

1. During the analysis phase, the default import declaration of an
   identifier was recorded.

2. During the emit phase each emitted identifier would be recorded.
   The information from step 1 would then be used to determine the
   default import declaration of the identifier which would be
   registered as used.

3. A TypeScript transform would taint all default imports that were
   registered as used in step 2 such that the imports are not elided
   by TypeScript.

In incremental compilations, a file may have to be emitted even if its
analysis data has been reused from the prior compilation. This would
mean that step 1 is not executed, resulting in a mismatch in step 2 and
ultimately in incorrectly eliding the default. This was mitigated by
storing the mapping from identifier to import declaration on the
`ts.SourceFile` instead of a member of `DefaultImportTracker` such that
it would also be visible to the `DefaultImportRecorder` of subsequent
compiles even if step 1 had not been executed.

Ultimately however, the information that is being recorded into the
`DefaultImportRecorder` has a longer lifetime than a single
`DefaultImportRecorder` instance, as that is only valid during a single
compilation whereas the identifier to import declaration mapping
outlives a single compilation. This commit replaces the registration of
this mapping by attaching the default import declaration on the output
AST node that captures the identifier. This enables the removal of
all of the `DefaultImportRecorder` usages throughout the analysis phase
together with the `DefaultImportRecorder` interface itself.

PR Close #41557

2021-04-12 17:05:10 -07:00

src

refactor(compiler-cli): track a dependency on a default import on WrappedNodeExpr (#41557 )

2021-04-12 17:05:10 -07:00

test

test(ngcc): provide correct source-mappings for renderer tests (#41434 )

2021-04-12 16:46:29 -07:00

BUILD.bazel

perf(compiler-cli): detect semantic changes and their effect on an incremental rebuild (#40947 )

2021-03-08 08:41:19 -08:00

index.ts

refactor(ngcc): move logging code into ngtsc (#37114 )

2020-06-22 13:38:47 -07:00

main-ivy-ngcc.ts

build: update license headers to reference Google LLC (#37205 )

2020-05-26 14:26:58 -04:00

main-ngcc.ts

build: update license headers to reference Google LLC (#37205 )

2020-05-26 14:26:58 -04:00

README.md

refactor(ivy): move ngcc into a higher level folder (#29092 )

2019-03-20 14:45:54 -04:00

README.md

Angular Compatibility Compiler (ngcc)

This compiler will convert node_modules compiled with ngc, into node_modules which appear to have been compiled with ngtsc.

This conversion will allow such "legacy" packages to be used by the Ivy rendering engine.

Building

The project is built using Bazel:

yarn bazel build //packages/compiler-cli/ngcc

Unit Testing

The unit tests are built and run using Bazel:

yarn bazel test //packages/compiler-cli/ngcc/test

Integration Testing

There are tests that check the behavior of the overall executable:

yarn bazel test //packages/compiler-cli/ngcc/test:integration