honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
angular-cn/tools
History
Paul Gschwendtner a1e00f82f4 build: fix ts-api-guardian golden approval not working on windows (#36115) 
Currently on Windows, it's not possible to approve goldens in
`ts-api-guardian`. This is because paths are resolved relatively
to the working directory. In Windows, golden files are resolved
to the actual workspace directory. The current logic tries to
compute a relative path to the runfile from the working directory.

This causes the file paths to have a lot of parent directory
path segments. Eventually, when joined with the build workspace
directory, the paths end up being incorrect. e.g.

```
fileName = ../../../../../../projects/angular/golden/<..>/common.d.ts`
outFile = BUILD_WORKSPACE_DIR + fileName;
```

To fix this, we no longer deal with confusing relative paths, but
instead always use absolute file system paths.

Additionally, this fixes that new goldens are generated at the wrong
location on all platforms.

PR Close #36115
 		2020-03-17 12:38:25 -07:00
..
brotli-cli build: switch to @build_bazel_rules_nodejs//:index.bzl load point (#33433) 2019-10-28 10:10:48 -07:00
browsers build: fixes for cross-platform RBE (#33708) 2019-11-15 10:49:55 -08:00
build build: remove obsolete build related tools and helper scripts (#34058) 2019-12-02 10:52:21 -08:00
circular_dependency_test build: create bazel marco to test for circular dependencies (#34774) 2020-01-23 11:36:40 -08:00
contributing-stats fix(dev-infra): sort contributors alphabetically in `get-data.ts` script (#35997) 2020-03-11 14:49:18 -04:00
gulp-tasks feat(dev-infra): add dev-infra to the commit message scopes (#35992) 2020-03-10 13:26:12 -04:00
ng_rollup_bundle build: should use $(execpath) in npm_package_bin args (#34736) 2020-01-15 14:58:07 -05:00
ngcontainer build: depend on bazelisk rather than directly on Bazel (#36078) 2020-03-16 10:58:06 -07:00
npm build(bazel): remove hacky fake @angular/bazel npm package under tools/npm/@angular_bazel (#36009) 2020-03-11 14:43:13 -04:00
npm_integration_test build: depend on bazelisk rather than directly on Bazel (#36078) 2020-03-16 10:58:06 -07:00
pullapprove ci: add verification of the pullapprove config (#35060) 2020-02-12 16:39:13 -08:00
rxjs build: update to rules_nodejs 0.32.2 (#31325) 2019-07-01 14:16:42 -07:00
saucelabs build: fix saucelabs jobs that were broken by bazelisk change (#36109) 2020-03-17 12:28:02 -07:00
size-tracking build: update scripting and tooling to rely on define=angular_ivy_enabled instream of define=compile (#33983) 2019-11-26 16:38:40 -05:00
source-map-test build: update npm dependencies (#19328) 2017-09-22 13:20:52 -07:00
symbol-extractor build: update scripting and tooling to rely on define=angular_ivy_enabled instream of define=compile (#33983) 2019-11-26 16:38:40 -05:00
testing build: update to rules_nodejs 1.1.0 (#34736) 2020-01-15 14:58:07 -05:00
ts-api-guardian build: fix ts-api-guardian golden approval not working on windows (#36115) 2020-03-17 12:38:25 -07:00
tslint build: remove unused rollup.config.js files (#28646) 2019-02-14 19:28:08 +00:00
utils ci: only lint commit messages in the PR (#35035) 2020-02-04 10:25:01 -08:00
validate-commit-message feat(dev-infra): add dev-infra to the commit message scopes (#35992) 2020-03-10 13:26:12 -04:00
yarn build: upgrade yarn to 1.3.2 (#21406) 2018-01-10 12:32:26 -08:00
BUILD.bazel build: remove rollup packaging from dev-infra (#35647) 2020-03-17 12:27:07 -07:00
bazel_stamp_vars.js build: add pre-release check that validates the version name (#29551) 2019-03-27 12:26:13 -07:00
check-environment.js build: update to Node 10 (#25822) 2018-09-06 14:58:30 -07:00
defaults.bzl ci: move public-api goldens to goldens directory (#35768) 2020-03-10 20:58:39 -04:00
inline-package-json-deps.js build: remove rollup packaging from dev-infra (#35647) 2020-03-17 12:27:07 -07:00
jasmine-seed-generator.js test: run unit tests in random order (#19904) 2018-07-06 13:48:02 -07:00
jsconfig.json chore(vscode): add jsconfig.json and remove .settings dir 2015-10-29 13:53:21 +00:00
ng_benchmark.bzl ci: do not run ng_benchmarks on CI (#34057) 2019-11-26 16:10:09 -08:00
postinstall-patches.js build: no longer run tslint from within gulp task (#35800) 2020-03-03 09:20:49 -08:00
rebase-pr.js ci: only lint commit messages in the PR (#35035) 2020-02-04 10:25:01 -08:00
tsconfig-test.json build(bazel): use fine-grained npm deps (#26111) (#26488) 2018-10-19 20:59:29 -07:00
tsconfig.json build: ts-api-guardian tsconfig warning with bazel (#27583) 2018-12-13 11:01:48 -08:00
types.d.ts build: no longer run tslint from within gulp task (#35800) 2020-03-03 09:20:49 -08:00
utils.inc feat(bundle): add script to push bundles to code.angularjs.org 2015-04-14 14:50:53 -07:00