History

Pete Bacon Darwin 6b311552f0 fix(compiler-cli): ensure file_system handles mixed Windows drives (#37959 )

The `fs.relative()` method assumed that the file-system is a single tree,
which is not the case in Windows, where you can have multiple drives,
e.g. `C:`, `D:` etc.

This commit changes `fs.relative()` so that it no longer forces the result
to be a `PathSegment` and then flows that refactoring through the rest of
the compiler-cli (and ngcc).  The main difference is that now, in some cases,
we needed to check whether the result is "rooted", i.e an `AbsoluteFsPath`,
rather than a `PathSegment`, before using it.

Fixes #36777

PR Close #37959

2020-07-13 12:05:21 -07:00

src

fix(compiler-cli): ensure file_system handles mixed Windows drives (#37959 )

2020-07-13 12:05:21 -07:00

test

fix(compiler-cli): ensure file_system handles mixed Windows drives (#37959 )

2020-07-13 12:05:21 -07:00

testing

fix(compiler-cli): ensure file_system handles mixed Windows drives (#37959 )

2020-07-13 12:05:21 -07:00

BUILD.bazel

refactor(compiler-cli): tidy up file_system BUILD.bazel file_system (#37114 )

2020-06-22 13:38:47 -07:00

index.ts

fix(compiler-cli): ensure file_system handles mixed Windows drives (#37959 )

2020-07-13 12:05:21 -07:00

README.md

refactor(ivy): implement a virtual file-system layer in ngtsc + ngcc (#30921 )

2019-06-25 16:25:24 -07:00

README.md

Virtual file-system layer

To improve cross platform support, all file access (and path manipulation) is now done through a well known interface (FileSystem).

For testing a number of MockFileSystem implementations are supplied. These provide an in-memory file-system which emulates operating systems like OS/X, Unix and Windows.

The current file system is always available via the helper method, getFileSystem(). This is also used by a number of helper methods to avoid having to pass FileSystem objects around all the time. The result of this is that one must be careful to ensure that the file-system has been initialized before using any of these helper methods. To prevent this happening accidentally the current file system always starts out as an instance of InvalidFileSystem, which will throw an error if any of its methods are called.

You can set the current file-system by calling setFileSystem(). During testing you can call the helper function initMockFileSystem(os) which takes a string name of the OS to emulate, and will also monkey-patch aspects of the TypeScript library to ensure that TS is also using the current file-system.

Finally there is the NgtscCompilerHost to be used for any TypeScript compilation, which uses a given file-system.

All tests that interact with the file-system should be tested against each of the mock file-systems. A series of helpers have been provided to support such tests:

runInEachFileSystem() - wrap your tests in this helper to run all the wrapped tests in each of the mock file-systems, it calls initMockFileSystem() for each OS to emulate.
loadTestFiles() - use this to add files and their contents to the mock file system for testing.
loadStandardTestFiles() - use this to load a mirror image of files on disk into the in-memory mock file-system.
loadFakeCore() - use this to load a fake version of @angular/core into the mock file-system.

All ngcc and ngtsc source and tests now use this virtual file-system setup.