angular-cn/packages/compiler-cli/ngcc/test/analysis
George Kalpakas 6ab43d7335 fix(ngcc): correctly detect external files from nested `node_modules/` (#36559)
Previously, when we needed to detect whether a file is external to a
package, we only checked whether the relative path to the file from the
package's root started with `..`. This would detect external imports
when the packages were siblings (e.g. peer dependencies or hoisted to
the top of `node_modules/` by the package manager), but would fail to
detect imports from packages located in nested `node_modules/` as
external. For example, importing `node_modules/foo/node_modules/bar`
from a file in `node_modules/foo/` would be considered internal to the
`foo` package.

This could result in processing/analyzing more files than necessary.
More importantly it could lead to errors due to trying to analyze
non-Angular packages that were direct dependencies of Angular packages.

This commit fixes it by also verifying that the relative path to a file
does not start with `node_modules/`.

Jira issue: [FW-2068](https://angular-team.atlassian.net/browse/FW-2068)

Fixes #36526

PR Close #36559
2020-04-10 09:10:26 -07:00
..
decoration_analyzer_spec.ts fix(ngcc): correctly detect external files from nested `node_modules/` (#36559) 2020-04-10 09:10:26 -07:00
migration_host_spec.ts fix(ngcc): correctly detect external files from nested `node_modules/` (#36559) 2020-04-10 09:10:26 -07:00
module_with_providers_analyzer_spec.ts style(ngcc): reformat of ngcc after clang update (#36447) 2020-04-06 09:26:57 -07:00
ngcc_trait_compiler_spec.ts style(ngcc): reformat of ngcc after clang update (#36447) 2020-04-06 09:26:57 -07:00
private_declarations_analyzer_spec.ts style(ngcc): reformat of ngcc after clang update (#36447) 2020-04-06 09:26:57 -07:00
references_registry_spec.ts style(ngcc): reformat of ngcc after clang update (#36447) 2020-04-06 09:26:57 -07:00
switch_marker_analyzer_spec.ts fix(ngcc): correctly detect external files from nested `node_modules/` (#36559) 2020-04-10 09:10:26 -07:00
util_spec.ts fix(ngcc): correctly detect external files from nested `node_modules/` (#36559) 2020-04-10 09:10:26 -07:00