Go to file
Alex Rickabaugh fc034270ce fix(core): call ngOnDestroy on all services that have it (#23755)
Previously, ngOnDestroy was only called on services which were statically
determined to have ngOnDestroy methods. In some cases, such as with services
instantiated via factory functions, it's not statically known that the service
has an ngOnDestroy method.

This commit changes the runtime to look for ngOnDestroy when instantiating
all DI tokens, and to call the method if it's present.

Fixes #22466
Fixes #22240
Fixes #14818

PR Close #23755
2018-05-08 13:55:29 -07:00
.circleci build: update bazel to 0.13 (#23623) 2018-05-04 15:23:55 -07:00
.github docs(aio): add new sections to issue template (#23304) 2018-04-11 13:47:57 -07:00
aio feat(aio): add v6 release notification (#23690) 2018-05-04 15:23:36 -07:00
docs docs: update PUBLIC_API.md with the latest list of packages and clarifications 2018-05-02 16:23:47 -07:00
integration build: update to latest nodejs bazel rules (#23683) 2018-05-04 15:29:03 -07:00
modules revert: refactor(ivy): make return value of define(Component|Directive|Pipe|Injector|Injectable) private (#23371) 2018-04-13 23:02:29 -07:00
packages fix(core): call ngOnDestroy on all services that have it (#23755) 2018-05-08 13:55:29 -07:00
scripts build: update the scripts/release/post-check script for 6.0.x 2018-05-03 15:39:58 -07:00
tools Revert "style(animations): fix short param names (#23668)" 2018-05-05 08:36:49 -07:00
.bowerrc chore(dgeni): clean up legacy typings bundle creation 2015-10-29 21:19:59 +00:00
.clang-format feat(tooling): Add a .clang-format for automated JavaScript formatting. 2015-04-02 08:44:34 -07:00
.editorconfig chore(.editorconfig): include markdown config 2015-01-27 00:14:48 -08:00
.gitattributes chore: force lf EOL for ts files (#11143) 2016-08-29 12:41:58 -07:00
.gitignore build: update Bazel dependency to 0.11.1 (#23297) 2018-04-10 23:01:30 -07:00
.mailmap build: add a Git .mailmap with my new name (#19550) 2017-10-09 14:35:30 -07:00
.nvmrc build: update node version number in .nvmrc (#20832) 2017-12-12 11:56:18 -08:00
.pullapprove.yml ci: add Brandon Roberts as an aio approver (#23417) 2018-04-27 07:17:04 -07:00
.travis.yml ci: remove travis e2e_2 job (#22810) 2018-04-13 16:30:50 -07:00
BUILD.bazel feat(elements): add schematics (#23298) 2018-04-11 18:13:30 -07:00
CHANGELOG.md docs: add link to the v6 release announcement to our changelog 2018-05-03 13:15:20 -07:00
CODE_OF_CONDUCT.md docs: fix community tab in GitHub by copying CoC 2018-02-27 19:02:30 -08:00
CONTRIBUTING.md feat(elements): add support for creating custom elements (#22413) 2018-03-16 12:39:07 -07:00
LICENSE docs(common): update copyright years (#21232) 2018-01-04 17:45:36 -05:00
README.md docs: improve the GitHub README.md, update links, etc 2018-05-03 13:26:12 -07:00
WORKSPACE build: update to latest nodejs bazel rules (#23683) 2018-05-04 15:29:03 -07:00
bower.json docs: branding fixes (#14132) 2017-01-27 15:03:11 -06:00
browser-providers.conf.js build: remove required BrowserStack run as it fails with “Access denied” (#19769) 2017-10-17 15:51:40 -07:00
build.sh feat: update the package output of build.sh to APF v6 (#22808) 2018-03-18 09:33:51 -07:00
gulpfile.js test: migrate remaining public-api tests to Bazel (#22639) 2018-03-09 09:11:40 -08:00
karma-js.conf.js feat(ivy): first steps towards ngtsc mode (#23455) 2018-04-25 13:25:33 -07:00
package.json release: cut the v6.0.0 release 2018-05-03 12:44:30 -07:00
protractor-e2e.conf.js refactor: add license header to JS files & format files (#12081) 2016-10-04 20:39:20 -07:00
protractor-examples-e2e.conf.js refactor: format and lint code 2016-12-12 11:30:25 -08:00
protractor-perf.conf.js refactor: add license header to JS files & format files (#12081) 2016-10-04 20:39:20 -07:00
shims_for_IE.js Revert "refactor: add license header to JS files & format files (#12035)" 2016-10-04 14:06:41 -07:00
test-events.js fix(platform-browser): run BLACK_LISTED_EVENTS outside of ngZone (#18993) 2017-09-05 15:33:22 -05:00
test-main.js feat(core): upgrade rxjs to 6.0.0-alpha.4 (#22573) 2018-03-19 21:51:51 -07:00
test.sh docs: update available platforms for `test.sh` (#22958) 2018-03-23 14:01:45 -04:00
tslint.json build: add lint rule for global flags in rollup config (#20028) 2017-10-30 23:09:16 -04:00
yarn.lock build: update to rxjs@6.0.0 (#23679) 2018-05-03 10:53:39 -07:00
yarn.lock.readme.md build: switch from npm to yarn (#19328) 2017-09-22 13:20:52 -07:00

README.md

Build Status CircleCI BrowserStack Status Join the chat at https://gitter.im/angular/angular npm version

Angular

Angular is a development platform for building mobile and desktop web applications using Typescript/JavaScript and other languages.

Quickstart

Get started in 5 minutes.

Changelog

Learn about the latest improvements.

Want to help?

Want to file a bug, contribute some code, or improve documentation? Excellent! Read up on our guidelines for contributing and then check out one of our issues in the hotlist: community-help.