Go to file
crisbeto fcb03abc72 fix(ivy): injecting incorrect Renderer2 into child components (#31063)
In ViewEngine injecting a Renderer2 returns a renderer that is specific to the particular component, however in Ivy we inject the renderer for the parent view instead. This causes it to set incorrect `ngcontent` attributes when creating elements through the renderer.

The issue comes from the fact that the `Renderer2` is created according to the current `LView`, but because DI happens before we've entered the `LView` of the component that's injecting the renderer, we end up with one that's one level up. We work around the issue by finding the `LView` that corresponds to the `previousOrParentTNode` inside of the parent view and associating the `Renderer2` with it.

This PR resolves FW-1382.

PR Close #31063
2019-06-24 11:33:31 -07:00
.circleci ci: send failure notifications from `saucelabs_tests` to `dev-infra-ci-failures` (#31202) 2019-06-21 15:29:35 -07:00
.codefresh
.devcontainer
.github
.vscode
aio
docs
integration
modules
packages fix(ivy): injecting incorrect Renderer2 into child components (#31063) 2019-06-24 11:33:31 -07:00
scripts
third_party
tools
.bazelignore
.bazelrc
.clang-format
.editorconfig
.gitattributes
.gitignore
.mailmap
.nvmrc
BUILD.bazel
CHANGELOG.md
CODE_OF_CONDUCT.md
CONTRIBUTING.md
LICENSE
README.md
WORKSPACE
browser-providers.conf.js
browser_repositories.bzl
gulpfile.js
karma-js.conf.js
package.json
protractor-perf.conf.js
renovate.json
shims_for_IE.js
test-events.js
test-main.js
tslint.json
yarn.lock
yarn.lock.readme.md

README.md

CircleCI BrowserStack Status Join the chat at https://gitter.im/angular/angular npm version

Angular

Angular is a development platform for building mobile and desktop web applications using Typescript/JavaScript and other languages.

Quickstart

Get started in 5 minutes.

Changelog

Learn about the latest improvements.

Want to help?

Want to file a bug, contribute some code, or improve documentation? Excellent! Read up on our guidelines for contributing and then check out one of our issues in the hotlist: community-help.