Add examples to show issues 841 and 919 fixes.

This commit is contained in:
Joel Costigliola 2017-04-25 21:04:12 +12:00
parent fe86db8cf8
commit 2984550eff
3 changed files with 78 additions and 1 deletions

View File

@ -201,4 +201,9 @@ public class NumberAssertionsExamples extends AbstractAssertionsExamples {
.isNotPositive();
}
@Test
public void should_consider_primitive_negative_zero_as_zero_fixing_issue_919() {
assertThat(-0.).isZero();
}
}

View File

@ -0,0 +1,72 @@
/**
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on
* an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
* specific language governing permissions and limitations under the License.
*
* Copyright 2012-2016 the original author or authors.
*/
package org.assertj.examples;
import static java.util.Collections.singleton;
import static org.assertj.core.api.Assertions.assertThat;
import java.math.BigDecimal;
import java.util.Set;
import org.assertj.core.util.BigDecimalComparator;
import org.junit.Test;
public class ObjectAssertionsExamples extends AbstractAssertionsExamples {
private static final BigDecimalComparator BIG_DECIMAL_COMPARATOR = new BigDecimalComparator();
@Test
public void issue_841() {
BigDecimal value1 = BigDecimal.valueOf(100);
BigDecimal value2 = value1.setScale(2);
assertThat(value1).isNotEqualTo(value2);
assertThat(value1.hashCode()).isNotEqualTo(value2.hashCode());
assertThat(value1).isEqualByComparingTo(value2);
class Foo {
private final BigDecimal value;
Foo(BigDecimal value) {
this.value = value;
}
@SuppressWarnings("unused")
BigDecimal getValue() {
return value;
}
}
Foo foo1 = new Foo(value1);
Foo foo2 = new Foo(value2);
assertThat(foo1).usingComparatorForType(BIG_DECIMAL_COMPARATOR, BigDecimal.class)
.isEqualToComparingFieldByFieldRecursively(foo2);
class Bar {
private final Set<Foo> foos;
Bar(Set<Foo> foos) {
this.foos = foos;
}
@SuppressWarnings("unused")
Set<Foo> getFoos() {
return foos;
}
}
assertThat(new Bar(singleton(foo1))).usingComparatorForType(BIG_DECIMAL_COMPARATOR, BigDecimal.class)
.isEqualToComparingFieldByFieldRecursively(new Bar(singleton(foo2)));
}
}

View File

@ -16,13 +16,13 @@ import java.util.Comparator;
import org.assertj.examples.data.TolkienCharacter;
/**
* Compare {@link TolkienCharacter} age.
*
* @author Joel Costigliola
*/
public class AgeComparator implements Comparator<TolkienCharacter> {
@Override
public int compare(TolkienCharacter tolkienCharacter1, TolkienCharacter tolkienCharacter2) {
Integer age1 = tolkienCharacter1.age;
return age1.compareTo(tolkienCharacter2.age);