diff --git a/hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/search/lastn/IElasticsearchSvc.java b/hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/search/lastn/IElasticsearchSvc.java index 7153955fbfc..b9c4a662b0b 100644 --- a/hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/search/lastn/IElasticsearchSvc.java +++ b/hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/search/lastn/IElasticsearchSvc.java @@ -57,7 +57,7 @@ public interface IElasticsearchSvc { * Creates or updates index for an Observation Resource. * @param theDocumentId Identifier for Observation resource. * @param theObservationDocument Indexing document for Observation. - * @return + * @return True if Observation indexed successfully. */ Boolean createOrUpdateObservationIndex(String theDocumentId, ObservationJson theObservationDocument); @@ -65,7 +65,7 @@ public interface IElasticsearchSvc { * Creates or updates index for an Observation Code. * @param theCodeableConceptID Identifier for Observation resource. * @param theObservationCodeDocument Indexing document for Observation. - * @return + * @return True if Observation Code indexed successfully. */ Boolean createOrUpdateObservationCodeIndex(String theCodeableConceptID, CodeJson theObservationCodeDocument); diff --git a/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/r4/PersistObservationIndexedSearchParamLastNR4IT.java b/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/r4/PersistObservationIndexedSearchParamLastNR4IT.java index 73eb8953663..f5bf5cfdbd9 100644 --- a/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/r4/PersistObservationIndexedSearchParamLastNR4IT.java +++ b/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/r4/PersistObservationIndexedSearchParamLastNR4IT.java @@ -61,6 +61,8 @@ public class PersistObservationIndexedSearchParamLastNR4IT { elasticsearchSvc.deleteAllDocumentsForTest(ElasticsearchSvcImpl.OBSERVATION_INDEX); elasticsearchSvc.deleteAllDocumentsForTest(ElasticsearchSvcImpl.OBSERVATION_CODE_INDEX); + elasticsearchSvc.refreshIndex(ElasticsearchSvcImpl.OBSERVATION_INDEX); + elasticsearchSvc.refreshIndex(ElasticsearchSvcImpl.OBSERVATION_CODE_INDEX); } private final String SINGLE_SUBJECT_ID = "4567"; @@ -90,6 +92,9 @@ public class PersistObservationIndexedSearchParamLastNR4IT { String observationCodeNormalizedId = persistedObservationEntity.getCode_concept_id(); + // List persistedObservationCodes = elasticsearchSvc.queryAllIndexedObservationCodesForTest(); + // assertEquals(1, persistedObservationCodes.size()); + // Check that we can retrieve code by hash value. String codeSystemHash = persistedObservationEntity.getCode_coding_code_system_hash(); CodeJson persistedObservationCode = elasticsearchSvc.getObservationCodeDocument(codeSystemHash, null); @@ -181,6 +186,9 @@ public class PersistObservationIndexedSearchParamLastNR4IT { List observationDocuments = elasticsearchSvc.executeLastNWithAllFieldsForTest(searchParameterMap, myFhirCtx); assertEquals(100, observationDocuments.size()); + //List codeDocuments = elasticsearchSvc.queryAllIndexedObservationCodesForTest(); + //assertEquals(2, codeDocuments.size()); + // Check that all observations were indexed. searchParameterMap = new SearchParameterMap(); searchParameterMap.add(Observation.SP_SUBJECT, multiSubjectParams); diff --git a/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/search/lastn/LastNElasticsearchSvcMultipleObservationsIT.java b/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/search/lastn/LastNElasticsearchSvcMultipleObservationsIT.java index a6a28cd1879..b6ede9489c7 100644 --- a/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/search/lastn/LastNElasticsearchSvcMultipleObservationsIT.java +++ b/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/search/lastn/LastNElasticsearchSvcMultipleObservationsIT.java @@ -53,6 +53,8 @@ public class LastNElasticsearchSvcMultipleObservationsIT { public void after() throws IOException { elasticsearchSvc.deleteAllDocumentsForTest(ElasticsearchSvcImpl.OBSERVATION_INDEX); elasticsearchSvc.deleteAllDocumentsForTest(ElasticsearchSvcImpl.OBSERVATION_CODE_INDEX); + elasticsearchSvc.refreshIndex(ElasticsearchSvcImpl.OBSERVATION_INDEX); + elasticsearchSvc.refreshIndex(ElasticsearchSvcImpl.OBSERVATION_CODE_INDEX); } @Test diff --git a/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/search/lastn/LastNElasticsearchSvcSingleObservationIT.java b/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/search/lastn/LastNElasticsearchSvcSingleObservationIT.java index 0780178849f..b0f913c3483 100644 --- a/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/search/lastn/LastNElasticsearchSvcSingleObservationIT.java +++ b/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/search/lastn/LastNElasticsearchSvcSingleObservationIT.java @@ -92,6 +92,8 @@ public class LastNElasticsearchSvcSingleObservationIT { public void after() throws IOException { elasticsearchSvc.deleteAllDocumentsForTest(ElasticsearchSvcImpl.OBSERVATION_INDEX); elasticsearchSvc.deleteAllDocumentsForTest(ElasticsearchSvcImpl.OBSERVATION_CODE_INDEX); + elasticsearchSvc.refreshIndex(ElasticsearchSvcImpl.OBSERVATION_INDEX); + elasticsearchSvc.refreshIndex(ElasticsearchSvcImpl.OBSERVATION_CODE_INDEX); } @Test @@ -297,6 +299,7 @@ public class LastNElasticsearchSvcSingleObservationIT { assertTrue(elasticsearchSvc.createOrUpdateObservationCodeIndex(OBSERVATIONSINGLECODEID, codeableConceptField)); elasticsearchSvc.refreshIndex(ElasticsearchSvcImpl.OBSERVATION_INDEX); + elasticsearchSvc.refreshIndex(ElasticsearchSvcImpl.OBSERVATION_CODE_INDEX); } }