Fix #234 - Invalid entry in OSGi manifest

This commit is contained in:
James Agnew 2015-10-01 18:37:00 -04:00
parent 397a902db6
commit 0a5e6043bd
4 changed files with 49 additions and 1 deletions

View File

@ -57,7 +57,7 @@
<Embed-Dependency>*;scope=!provided|test</Embed-Dependency>
<Embed-Directory>lib</Embed-Directory>
<Embed-Transitive>true</Embed-Transitive>
<_removeheaders>Built-By</_removeheaders>
<_removeheaders>Built-By, Include-Resource, Private-Package</_removeheaders>
<!-- <Private-Package>org.foo.myproject.*</Private-Package> <Bundle-Activator>org.foo.myproject.impl1.Activator</Bundle-Activator> -->
</instructions>
</configuration>
@ -70,6 +70,24 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-failsafe-plugin</artifactId>
<configuration>
<redirectTestOutputToFile>true</redirectTestOutputToFile>
</configuration>
<executions>
<execution>
<goals>
<goal>integration-test</goal>
<goal>verify</goal>
</goals>
<phase>integration-test</phase>
</execution>
</executions>
</plugin>
</plugins>
<resources>
<resource>

View File

@ -0,0 +1,26 @@
package ca.uhn.fhir.osgi;
import static org.hamcrest.Matchers.containsString;
import static org.hamcrest.Matchers.not;
import static org.junit.Assert.assertThat;
import java.io.FileReader;
import org.apache.commons.io.IOUtils;
import org.junit.Test;
public class ManifestIT {
/**
* See #234
*/
@Test
public void testValidateManifest() throws Exception {
FileReader r = new FileReader("./target/classes/META-INF/MANIFEST.MF");
String file = IOUtils.toString(r);
assertThat(file, not(containsString(".jar=/")));
}
}

View File

@ -120,6 +120,10 @@
if they did not contain a question mark. Thanks
to Bill de Beaubien for reporting!
</action>
<action type="fix" issue="234">
Remove invalid entries in OSGi Manifest. Thanks
to Alexander Kley for the fix!
</action>
</release>
<release version="1.2" date="2015-09-18">
<action type="add">