honeymoose
/
hapi-fhir
mirror of https://github.com/hapifhir/hapi-fhir.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

remove question, put in PR instead

This commit is contained in:
Tadgh 2020-07-23 18:09:10 -07:00
parent 698b18eb2f
commit 31d0ed3ac1
1 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
hapi-fhir-jpaserver-empi/src/main/java/ca/uhn/fhir/jpa/empi/svc/candidate/EmpiCandidateSearchCriteriaBuilderSvc.java
View File

@ -57,17 +57,8 @@ public class EmpiCandidateSearchCriteriaBuilderSvc {
}
});
//TODO GGG/KHS, here's a question: What scenario would be actually want to return this empty optional.
//In the case where the resource being matched doesnt have any of the values that the EmpiResourceSearchParamJson wants?
//e.g. if i have a patient with name 'gary', but no birthdate, and i have a search param saying
// {
// "resourceType": "Patient",
// "searchParams": ["birthdate"]
// },
// do I actually want it to return Zero candidates? if so, this following conditional is valid. However
// What if I still want to match that person? Will they be unmatchable since they have no birthdate?
if (criteria.isEmpty()) {
//TODO GGG/KHS, re-evaluate whether we should early drop here.
return Optional.empty();
}
}