honeymoose
/
hapi-fhir
mirror of https://github.com/hapifhir/hapi-fhir.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add test for #942

This commit is contained in:
James Agnew 2018-05-13 10:31:54 -04:00
parent 8c47d966e9
commit 3a03d4ff63
1 changed files with 35 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
hapi-fhir-validation/src/test/java/org/hl7/fhir/r4/validation/FhirInstanceValidatorR4Test.java
View File

@ -26,6 +26,7 @@ import org.hl7.fhir.r4.model.StructureDefinition.StructureDefinitionKind;
import org.hl7.fhir.r4.model.ValueSet.ConceptSetComponent;
import org.hl7.fhir.r4.model.ValueSet.ValueSetExpansionComponent;
import org.hl7.fhir.r4.utils.FHIRPathEngine;
import org.hl7.fhir.r4.utils.IResourceValidator;
import org.hl7.fhir.utilities.validation.ValidationMessage;
import org.junit.*;
import org.junit.rules.TestRule;
@ -212,6 +213,40 @@ public class FhirInstanceValidatorR4Test {
assertEquals("primitive types must have a value or must have child extensions", all.get(0).getMessage());
}
/**
* See #942
*/
@Test
public void testValidateDoesntEnforceBestPracticesByDefault() {
Observation input = new Observation();
input.setStatus(ObservationStatus.AMENDED);
input.getCode().addCoding().setSystem("http://loinc.org").setCode("1234").setDisplay("FOO");
FhirInstanceValidator instanceModule;
FhirValidator val;
ValidationResult result;
List<SingleValidationMessage> all;
// With BPs disabled
val = ourCtx.newValidator();
instanceModule = new FhirInstanceValidator(myDefaultValidationSupport);
val.registerValidatorModule(instanceModule);
result = val.validateWithResult(input);
all = logResultsAndReturnAll(result);
assertTrue(result.isSuccessful());
assertThat(all, empty());
// With BPs enabled
val = ourCtx.newValidator();
instanceModule = new FhirInstanceValidator(myDefaultValidationSupport);
instanceModule.setBestPracticeWarningLevel(IResourceValidator.BestPracticeWarningLevel.Error);
val.registerValidatorModule(instanceModule);
result = val.validateWithResult(input);
all = logResultsAndReturnAll(result);
assertFalse(result.isSuccessful());
assertEquals("All observations should have a subject", all.get(0).getMessage());
}
private List<SingleValidationMessage> logResultsAndReturnNonInformationalOnes(ValidationResult theOutput) {
List<SingleValidationMessage> retVal = new ArrayList<SingleValidationMessage>();