honeymoose
/
hapi-fhir
mirror of https://github.com/hapifhir/hapi-fhir.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix the IndexOutOfBoundsException, #902 

Add a test that demonstrates it
This commit is contained in:
David Gileadi 2018-03-26 11:10:55 -07:00
parent 6ba6f301e4
commit 3b724107ff
2 changed files with 30 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hapi-fhir-validation/src/main/java/org/hl7/fhir/instance/validation/QuestionnaireResponseValidator.java
View File

@ -245,7 +245,7 @@ public class QuestionnaireResponseValidator extends BaseValidator {
} }
} }
for (org.hl7.fhir.instance.model.QuestionnaireResponse.GroupComponent nextAnswerGroup : answerGroups) { for (org.hl7.fhir.instance.model.QuestionnaireResponse.GroupComponent nextAnswerGroup : answerGroups) {
int index = theAnswerGroups.indexOf(answerGroups.get(1)); int index = theAnswerGroups.indexOf(nextAnswerGroup);
thePathStack.add("group(" + index + ")"); thePathStack.add("group(" + index + ")");
validateGroup(theErrors, nextQuestionGroup, nextAnswerGroup, thePathStack, theAnswers, theValidateRequired); validateGroup(theErrors, nextQuestionGroup, nextAnswerGroup, thePathStack, theAnswers, theValidateRequired);
thePathStack.removeLast(); thePathStack.removeLast();

29
hapi-fhir-validation/src/test/java/org/hl7/fhir/instance/hapi/validation/FhirInstanceValidatorTest.java
View File

@ -17,8 +17,11 @@ import org.apache.commons.io.IOUtils;
import org.hl7.fhir.instance.model.DateType; import org.hl7.fhir.instance.model.DateType;
import org.hl7.fhir.instance.model.Observation; import org.hl7.fhir.instance.model.Observation;
import org.hl7.fhir.instance.model.Observation.ObservationStatus; import org.hl7.fhir.instance.model.Observation.ObservationStatus;
import org.hl7.fhir.instance.model.Questionnaire;
import org.hl7.fhir.instance.model.Questionnaire.AnswerFormat;
import org.hl7.fhir.instance.model.QuestionnaireResponse; import org.hl7.fhir.instance.model.QuestionnaireResponse;
import org.hl7.fhir.instance.model.QuestionnaireResponse.QuestionnaireResponseStatus; import org.hl7.fhir.instance.model.QuestionnaireResponse.QuestionnaireResponseStatus;
import org.hl7.fhir.instance.model.Reference;
import org.hl7.fhir.instance.model.StringType; import org.hl7.fhir.instance.model.StringType;
import org.junit.AfterClass; import org.junit.AfterClass;
import org.junit.Ignore; import org.junit.Ignore;
@ -224,6 +227,32 @@ public class FhirInstanceValidatorTest {
assertTrue(result.isSuccessful()); assertTrue(result.isSuccessful());
} }
@Test
public void testQuestionnaireResponseValidator() {
final Questionnaire q = new Questionnaire();
q.getGroup().addGroup().setLinkId("group1").addQuestion().setLinkId("foo").setType(AnswerFormat.BOOLEAN);
q.getGroup().addQuestion().setLinkId("bar").setType(AnswerFormat.TEXT);
QuestionnaireResponse qr = new QuestionnaireResponse();
qr.setStatus(QuestionnaireResponseStatus.COMPLETED);
qr.getGroup().addGroup().setLinkId("group1").addQuestion().setLinkId("foo");
qr.getGroup().addQuestion().setLinkId("bar");
qr.setQuestionnaire(new Reference("#q"));
qr.getQuestionnaire().setResource(q);
FhirValidator val = ourCtxHl7OrgDstu2.newValidator();
FhirQuestionnaireResponseValidator module = new FhirQuestionnaireResponseValidator();
val.registerValidatorModule(module);
ValidationResult result = val.validateWithResult(qr);
String encoded = ourCtxHl7OrgDstu2.newJsonParser().setPrettyPrint(true).encodeResourceToString(result.toOperationOutcome());
ourLog.info(encoded);
assertTrue(result.isSuccessful());
}
@AfterClass @AfterClass
public static void afterClassClearContext() { public static void afterClassClearContext() {
TestUtil.clearAllStaticFieldsForUnitTest(); TestUtil.clearAllStaticFieldsForUnitTest();