From 4bd60a8447e2e801181441f3cb50a057a8c32bd5 Mon Sep 17 00:00:00 2001
From: James Agnew <jamesagnew@gmail.com>
Date: Sun, 7 Jul 2019 11:02:08 -0400
Subject: [PATCH] Roll back one dependency

---
 .../src/test/java/ca/uhn/fhir/jpa/config/TestR4Config.java     | 3 ++-
 .../fhir/jpa/model/entity/BaseResourceIndexedSearchParam.java  | 2 +-
 pom.xml                                                        | 3 ++-
 src/changes/changes.xml                                        | 2 +-
 4 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/config/TestR4Config.java b/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/config/TestR4Config.java
index c33c0e8f50b..54be5d46320 100644
--- a/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/config/TestR4Config.java
+++ b/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/config/TestR4Config.java
@@ -5,6 +5,7 @@ import ca.uhn.fhir.jpa.util.CurrentThreadCaptureQueriesListener;
 import ca.uhn.fhir.rest.server.interceptor.RequestValidatingInterceptor;
 import ca.uhn.fhir.validation.ResultSeverityEnum;
 import net.ttddyy.dsproxy.listener.SingleQueryCountHolder;
+import net.ttddyy.dsproxy.listener.logging.SLF4JLogLevel;
 import net.ttddyy.dsproxy.support.ProxyDataSourceBuilder;
 import org.apache.commons.dbcp2.BasicDataSource;
 import org.springframework.context.annotation.Bean;
@@ -103,7 +104,7 @@ public class TestR4Config extends BaseJavaConfigR4 {
 
 		DataSource dataSource = ProxyDataSourceBuilder
 			.create(retVal)
-//			.logQueryBySlf4j(SLF4JLogLevel.INFO, "SQL")
+			.logQueryBySlf4j(SLF4JLogLevel.INFO, "SQL")
 //			.logSlowQueryBySlf4j(10, TimeUnit.SECONDS)
 //			.countQuery(new ThreadQueryCountHolder())
 			.beforeQuery(new BlockLargeNumbersOfParamsListener())
diff --git a/hapi-fhir-jpaserver-model/src/main/java/ca/uhn/fhir/jpa/model/entity/BaseResourceIndexedSearchParam.java b/hapi-fhir-jpaserver-model/src/main/java/ca/uhn/fhir/jpa/model/entity/BaseResourceIndexedSearchParam.java
index a955a475d56..aa1dfddebe2 100644
--- a/hapi-fhir-jpaserver-model/src/main/java/ca/uhn/fhir/jpa/model/entity/BaseResourceIndexedSearchParam.java
+++ b/hapi-fhir-jpaserver-model/src/main/java/ca/uhn/fhir/jpa/model/entity/BaseResourceIndexedSearchParam.java
@@ -55,7 +55,7 @@ public abstract class BaseResourceIndexedSearchParam extends BaseResourceIndex {
 	@Column(name = "SP_NAME", length = MAX_SP_NAME, nullable = false)
 	private String myParamName;
 
-	@ManyToOne(optional = false, fetch = FetchType.LAZY)
+	@ManyToOne(optional = false, fetch = FetchType.LAZY, cascade = {})
 	@JoinColumn(name = "RES_ID", referencedColumnName = "RES_ID")
 	@ContainedIn
 	private ResourceTable myResource;
diff --git a/pom.xml b/pom.xml
index 00bff885d83..217eefd7495 100755
--- a/pom.xml
+++ b/pom.xml
@@ -592,7 +592,8 @@
 		<servicemix_xmlresolver_version>1.2_5</servicemix_xmlresolver_version>
 		<slf4j_version>1.7.25</slf4j_version>
 		<spring_version>5.1.8.RELEASE</spring_version>
-		<spring_data_version>2.1.9.RELEASE</spring_data_version>
+		<!-- FYI: Spring Data JPA 2.1.9 causes test failures due to unexpected cascading deletes -->
+		<spring_data_version>2.1.8.RELEASE</spring_data_version>
 		<spring_boot_version>2.1.1.RELEASE</spring_boot_version>
 		<spring_retry_version>1.2.2.RELEASE</spring_retry_version>
 
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index f9aebd01b1f..18c90465db2 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -16,7 +16,7 @@
 					<li>Apache HTTPClient (Client): 4.5.3 -&gt; 4.5.9</li>
 					<li>Apache HTTPCore (Client>: 4.4.6 -&gt; 4.4.11</li>
 					<li>Spring (JPA): 5.1.6.RELEASE -&gt; 5.1.8.RELEASE</li>
-					<li>Spring-Data (JPA): 2.1.6.RELEASE -&gt; 2.1.9.RELEASE</li>
+					<li>Spring-Data (JPA): 2.1.6.RELEASE -&gt; 2.1.8.RELEASE</li>
 <!--					<li>Derby (CLI and JPA Examples): 10.14.2.0 -&gt; 10.15.1.3</li>-->
 					<li>JANSI (CLI): 1.17.1 -&gt; 1.18</li>
 					<li>json-patch (JPA): 1.10 -&gt; 1.15 (see changelog entry about this change)</li>