honeymoose
/
hapi-fhir
mirror of https://github.com/hapifhir/hapi-fhir.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add FK index to avoid timeout when deleting large ValueSet (#3416) 

* Add FK index to avoid timeout when deleting large ValueSet

* Add exception to allow same name for index and FK

Co-authored-by: juan.marchionatto <juan.marchionatto@smilecdr.com>
This commit is contained in:
jmarchionatto 2022-02-23 13:54:30 -05:00 committed by GitHub
parent 96cadbba3e
commit 53c5a9bbeb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/6_0_0/3316-deleting-large-valueset-timeout.yml Normal file
View File

@ -0,0 +1,4 @@
---
type: fix
issue: 3316
title: "When deleting a large ValueSet operation was timing out. This issue has been fixed."

3
hapi-fhir-jpa/src/main/java/ca/uhn/fhir/jpa/util/TestUtil.java
View File

@ -84,7 +84,8 @@ public class TestUtil {
"FK_CONCEPTPROP_CONCEPT",
"FK_CONCEPTDESIG_CONCEPT",
"FK_TERM_CONCEPTPC_CHILD",
"FK_TERM_CONCEPTPC_PARENT"
"FK_TERM_CONCEPTPC_PARENT",
"FK_TRM_VALUESET_CONCEPT_PID"
);

5
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/entity/TermValueSetConceptDesignation.java
View File

@ -33,7 +33,10 @@ import java.io.Serializable;
import static org.apache.commons.lang3.StringUtils.left;
import static org.apache.commons.lang3.StringUtils.length;
@Table(name = "TRM_VALUESET_C_DESIGNATION")
@Table(name = "TRM_VALUESET_C_DESIGNATION", indexes = {
// must have same name that indexed FK or SchemaMigrationTest complains because H2 sets this index automatically
@Index(name = "FK_TRM_VALUESET_CONCEPT_PID", columnList = "VALUESET_CONCEPT_PID", unique = false)
})
@Entity()
public class TermValueSetConceptDesignation implements Serializable {
private static final long serialVersionUID = 1L;

9
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/migrate/tasks/HapiFhirJpaMigrationTasks.java
View File

@ -153,6 +153,15 @@ public class HapiFhirJpaMigrationTasks extends BaseMigrationTasks<VersionEnum> {
// drop obsolete
dateTable.dropIndexOnline("20220207.16", "IDX_SP_DATE_UPDATED");
// fix for https://github.com/hapifhir/hapi-fhir/issues/3316
// index must have same name that indexed FK or SchemaMigrationTest complains because H2 sets this index automatically
version.onTable("TRM_VALUESET_C_DESIGNATION")
.addIndex("20220223.1", "FK_TRM_VALUESET_CONCEPT_PID")
.unique(false)
.withColumns("VALUESET_CONCEPT_PID")
.onlyAppliesToPlatforms(NON_AUTOMATIC_FK_INDEX_PLATFORMS);
}
/**