diff --git a/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/bulk/BulkDataExportSvcImplR4Test.java b/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/bulk/BulkDataExportSvcImplR4Test.java index 08a1af4e4bf..ef3d1429bc1 100644 --- a/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/bulk/BulkDataExportSvcImplR4Test.java +++ b/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/bulk/BulkDataExportSvcImplR4Test.java @@ -304,7 +304,6 @@ public class BulkDataExportSvcImplR4Test extends BaseJpaR4Test { assertEquals(jobDetails1.getJobId(), jobDetails2.getJobId()); } - @Test public void testBatchJobSubmitsAndRuns() throws Exception { createResources(); @@ -340,11 +339,7 @@ public class BulkDataExportSvcImplR4Test extends BaseJpaR4Test { //Note that if the job is generated, and doesnt rely on an existed persisted BulkExportJobEntity, it will need to //create one itself, which means that its jobUUID isnt known until it starts. to get around this, we move public void awaitJobCompletion(JobExecution theJobExecution) throws InterruptedException { - await().until(() -> { - return theJobExecution.getStatus() == BatchStatus.COMPLETED; - //String jobUUID = theJobExecution.getExecutionContext().getString("jobUUID"); - //return myBulkDataExportSvc.getJobInfoOrThrowResourceNotFound(jobUUID).getStatus() == BulkJobStatusEnum.COMPLETE; - }); + await().until(() -> theJobExecution.getStatus() == BatchStatus.COMPLETED); } @Test diff --git a/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/config/TestR4Config.java b/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/config/TestR4Config.java index db9f1a5add5..8dbe1d26e62 100644 --- a/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/config/TestR4Config.java +++ b/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/config/TestR4Config.java @@ -44,7 +44,7 @@ public class TestR4Config extends BaseJavaConfigR4 { * starvation */ if (ourMaxThreads == null) { - ourMaxThreads = (int) (Math.random() * 6.0) + 2; + ourMaxThreads = (int) (Math.random() * 6.0) + 3; if ("true".equals(System.getProperty("single_db_connection"))) { ourMaxThreads = 1; diff --git a/hapi-fhir-jpaserver-empi/src/test/java/ca/uhn/fhir/jpa/empi/svc/EmpiPersonMergerSvcTest.java b/hapi-fhir-jpaserver-empi/src/test/java/ca/uhn/fhir/jpa/empi/svc/EmpiPersonMergerSvcTest.java index f9f15933fe1..65798826787 100644 --- a/hapi-fhir-jpaserver-empi/src/test/java/ca/uhn/fhir/jpa/empi/svc/EmpiPersonMergerSvcTest.java +++ b/hapi-fhir-jpaserver-empi/src/test/java/ca/uhn/fhir/jpa/empi/svc/EmpiPersonMergerSvcTest.java @@ -108,7 +108,7 @@ public class EmpiPersonMergerSvcTest extends BaseEmpiR4Test { @Test public void mergeRemovesPossibleDuplicatesLink() { EmpiLink empiLink = new EmpiLink().setPersonPid(myToPersonPid).setTargetPid(myFromPersonPid).setMatchResult(EmpiMatchResultEnum.POSSIBLE_DUPLICATE).setLinkSource(EmpiLinkSourceEnum.AUTO); - myEmpiLinkDaoSvc.save(empiLink); + saveLink(empiLink); assertEquals(1, myEmpiLinkDao.count()); mergePersons(); assertEquals(0, myEmpiLinkDao.count()); @@ -179,7 +179,8 @@ public class EmpiPersonMergerSvcTest extends BaseEmpiR4Test { EmpiLink fromLink = createEmpiLink(myFromPerson, myTargetPatient1); fromLink.setLinkSource(EmpiLinkSourceEnum.MANUAL); fromLink.setMatchResult(EmpiMatchResultEnum.NO_MATCH); - myEmpiLinkDaoSvc.save(fromLink); + + saveLink(fromLink); createEmpiLink(myToPerson, myTargetPatient1); @@ -196,7 +197,7 @@ public class EmpiPersonMergerSvcTest extends BaseEmpiR4Test { EmpiLink toLink = createEmpiLink(myToPerson, myTargetPatient1); toLink.setLinkSource(EmpiLinkSourceEnum.MANUAL); toLink.setMatchResult(EmpiMatchResultEnum.NO_MATCH); - myEmpiLinkDaoSvc.save(toLink); + saveLink(toLink); mergePersons(); List links = myEmpiLinkDaoSvc.findEmpiLinksByPersonId(myToPerson); @@ -209,7 +210,7 @@ public class EmpiPersonMergerSvcTest extends BaseEmpiR4Test { EmpiLink fromLink = createEmpiLink(myFromPerson, myTargetPatient1); fromLink.setLinkSource(EmpiLinkSourceEnum.MANUAL); fromLink.setMatchResult(EmpiMatchResultEnum.NO_MATCH); - myEmpiLinkDaoSvc.save(fromLink); + saveLink(fromLink); EmpiLink toLink = createEmpiLink(myToPerson, myTargetPatient1); toLink.setLinkSource(EmpiLinkSourceEnum.MANUAL); @@ -229,12 +230,12 @@ public class EmpiPersonMergerSvcTest extends BaseEmpiR4Test { EmpiLink fromLink = createEmpiLink(myFromPerson, myTargetPatient1); fromLink.setLinkSource(EmpiLinkSourceEnum.MANUAL); fromLink.setMatchResult(EmpiMatchResultEnum.MATCH); - myEmpiLinkDaoSvc.save(fromLink); + saveLink(fromLink); EmpiLink toLink = createEmpiLink(myToPerson, myTargetPatient1); toLink.setLinkSource(EmpiLinkSourceEnum.MANUAL); toLink.setMatchResult(EmpiMatchResultEnum.NO_MATCH); - myEmpiLinkDaoSvc.save(toLink); + saveLink(toLink); try { mergePersons(); @@ -249,12 +250,12 @@ public class EmpiPersonMergerSvcTest extends BaseEmpiR4Test { EmpiLink fromLink = createEmpiLink(myFromPerson, myTargetPatient1); fromLink.setLinkSource(EmpiLinkSourceEnum.MANUAL); fromLink.setMatchResult(EmpiMatchResultEnum.NO_MATCH); - myEmpiLinkDaoSvc.save(fromLink); + saveLink(fromLink); EmpiLink toLink = createEmpiLink(myToPerson, myTargetPatient2); toLink.setLinkSource(EmpiLinkSourceEnum.MANUAL); toLink.setMatchResult(EmpiMatchResultEnum.MATCH); - myEmpiLinkDaoSvc.save(toLink); + saveLink(toLink); mergePersons(); assertEquals(1, myToPerson.getLink().size());