Moved changelog entry, and added clarifying comments to DateRangeParam.

This commit is contained in:
Diederik Muylwyk 2019-12-30 15:29:35 -05:00
parent 990b43de2a
commit 856993edf8
3 changed files with 44 additions and 18 deletions

View File

@ -215,6 +215,15 @@ public class DateRangeParam implements IQueryParameterAnd<DateParam> {
* This lower bound is assumed to have a <code>ge</code> * This lower bound is assumed to have a <code>ge</code>
* (greater than or equals) modifier. * (greater than or equals) modifier.
* </p> * </p>
* <p>
* Note: An operation can take a DateRangeParam. If only a single date is provided,
* it will still result in a DateRangeParam where the lower and upper bounds
* are the same value. As such, even though the prefixes for the lower and
* upper bounds default to <code>ge</code> and <code>le</code> respectively,
* the resulting prefix is effectively <code>eq</code> where only a single
* date is provided - as required by the FHIR specificiation (i.e. "If no
* prefix is present, the prefix <code>eq</code> is assumed").
* </p>
*/ */
public DateRangeParam setLowerBound(String theLowerBound) { public DateRangeParam setLowerBound(String theLowerBound) {
setLowerBound(new DateParam(GREATERTHAN_OR_EQUALS, theLowerBound)); setLowerBound(new DateParam(GREATERTHAN_OR_EQUALS, theLowerBound));
@ -298,6 +307,15 @@ public class DateRangeParam implements IQueryParameterAnd<DateParam> {
* This upper bound is assumed to have a <code>le</code> * This upper bound is assumed to have a <code>le</code>
* (less than or equals) modifier. * (less than or equals) modifier.
* </p> * </p>
* <p>
* Note: An operation can take a DateRangeParam. If only a single date is provided,
* it will still result in a DateRangeParam where the lower and upper bounds
* are the same value. As such, even though the prefixes for the lower and
* upper bounds default to <code>ge</code> and <code>le</code> respectively,
* the resulting prefix is effectively <code>eq</code> where only a single
* date is provided - as required by the FHIR specificiation (i.e. "If no
* prefix is present, the prefix <code>eq</code> is assumed").
* </p>
*/ */
public DateRangeParam setUpperBound(String theUpperBound) { public DateRangeParam setUpperBound(String theUpperBound) {
setUpperBound(new DateParam(LESSTHAN_OR_EQUALS, theUpperBound)); setUpperBound(new DateParam(LESSTHAN_OR_EQUALS, theUpperBound));
@ -618,6 +636,15 @@ public class DateRangeParam implements IQueryParameterAnd<DateParam> {
return b.toString(); return b.toString();
} }
/**
* Note: An operation can take a DateRangeParam. If only a single date is provided,
* it will still result in a DateRangeParam where the lower and upper bounds
* are the same value. As such, even though the prefixes for the lower and
* upper bounds default to <code>ge</code> and <code>le</code> respectively,
* the resulting prefix is effectively <code>eq</code> where only a single
* date is provided - as required by the FHIR specificiation (i.e. "If no
* prefix is present, the prefix <code>eq</code> is assumed").
*/
private void validateAndSet(DateParam lowerBound, DateParam upperBound) { private void validateAndSet(DateParam lowerBound, DateParam upperBound) {
if (hasBound(lowerBound) && hasBound(upperBound)) { if (hasBound(lowerBound) && hasBound(upperBound)) {
if (lowerBound.getValue().getTime() > upperBound.getValue().getTime()) { if (lowerBound.getValue().getTime() > upperBound.getValue().getTime()) {

View File

@ -41,18 +41,27 @@
type: "fix" type: "fix"
title: "A missing mandatory was added to the SNOMED CT CodeSystem that is uploaded when SCT is uploaded to the JPA server. Thanks to Anders Havn for the pull request!" title: "A missing mandatory was added to the SNOMED CT CodeSystem that is uploaded when SCT is uploaded to the JPA server. Thanks to Anders Havn for the pull request!"
- item: - item:
issue: 1643 issue: "1643"
type: fix type: "fix"
title: "When validating resources containing custom valuesets defined in PrePopulatedValidationSupport title: "When validating resources containing custom valuesets defined in PrePopulatedValidationSupport
outside of the JPA server, sometimes code systems could not be found resulting in false negative outside of the JPA server, sometimes code systems could not be found resulting in false negative
errors." errors."
- item: - item:
issue: 1588 issue: "1588"
type: add type: "add"
title: "Support for several new operators has been added to the `_filter` support in the JPA server. Thanks title: "Support for several new operators has been added to the `_filter` support in the JPA server. Thanks
to Anthony Sute for the Pull Request!" to Anthony Sute for the Pull Request!"
- item: - item:
issue: 1650 issue: "1650"
type: fix type: "fix"
title: Several misleading comments in documentation code snippets were fixed. Thanks to title: "Several misleading comments in documentation code snippets were fixed. Thanks to
Jafer Khan for the pull request! Jafer Khan for the pull request!"
- item:
issue: "1645"
type: "add"
title: "The following utility methods have been added:
<ul>
<li><code>DateRangeParam#isDateWithinRange(Date theDate)</code></li>
<li><code>DateRangeParam#isDateWithinLowerBound(Date theDate)</code></li>
<li><code>DateRangeParam#isDateWithinUpperBound(Date theDate)</code></li>
</ul>"

View File

@ -77,16 +77,6 @@
An issue with the HAPI FHIR CLI was corrected that prevented the upload of LOINC due to an error An issue with the HAPI FHIR CLI was corrected that prevented the upload of LOINC due to an error
regarding the properties file. regarding the properties file.
</action> </action>
<action type="add" issue="1645">
The following utility methods have been added:
<![CDATA[
<ul>
<li><code>DateRangeParam#isDateWithinRange(Date theDate)</code></li>
<li><code>DateRangeParam#isDateWithinLowerBound(Date theDate)</code></li>
<li><code>DateRangeParam#isDateWithinUpperBound(Date theDate)</code></li>
</ul>
]]>
</action>
</release> </release>
<release version="4.1.0" date="2019-11-13" description="Jitterbug"> <release version="4.1.0" date="2019-11-13" description="Jitterbug">
<action type="add"> <action type="add">