From 96a21515429048b305cda2677e50d572bad6a8b7 Mon Sep 17 00:00:00 2001 From: Diederik Muylwyk Date: Thu, 4 Mar 2021 19:19:34 -0500 Subject: [PATCH] Remove unnecessary FIXMEs. --- .../dao/index/SearchParamWithInlineReferencesExtractor.java | 1 - .../main/java/ca/uhn/fhir/jpa/term/BaseTermReadSvcImpl.java | 1 - .../jpa/dao/r4/FhirResourceDaoCreatePlaceholdersR4Test.java | 1 - .../src/test/java/ca/uhn/fhir/jpa/packages/NpmR4Test.java | 3 --- 4 files changed, 6 deletions(-) diff --git a/hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/index/SearchParamWithInlineReferencesExtractor.java b/hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/index/SearchParamWithInlineReferencesExtractor.java index bdbf6ec991d..0a059bbc1ab 100644 --- a/hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/index/SearchParamWithInlineReferencesExtractor.java +++ b/hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/index/SearchParamWithInlineReferencesExtractor.java @@ -214,7 +214,6 @@ public class SearchParamWithInlineReferencesExtractor { } - // FIXME: DM 2021-03-04 - This is where inline match URLs are handled. /** * Handle references within the resource that are match URLs, for example references like "Patient?identifier=foo". These match URLs are resolved and replaced with the ID of the * matching resource. diff --git a/hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/term/BaseTermReadSvcImpl.java b/hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/term/BaseTermReadSvcImpl.java index 7c70a2d6129..a5c579e096c 100644 --- a/hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/term/BaseTermReadSvcImpl.java +++ b/hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/term/BaseTermReadSvcImpl.java @@ -2124,7 +2124,6 @@ public abstract class BaseTermReadSvcImpl implements ITermReadSvc { private boolean isPlaceholder(MetadataResource theResource) { // FIXME: DM 2021-03-04 - We should probably check if this extension exists and the value is true. - // FIXME: DM 2021-03-04 - Don't like that getExtensionUrl returns null instead of empty collection. return theResource.getMeta().getExtensionByUrl(HapiExtensions.EXT_RESOURCE_META_PLACEHOLDER) != null; } diff --git a/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/r4/FhirResourceDaoCreatePlaceholdersR4Test.java b/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/r4/FhirResourceDaoCreatePlaceholdersR4Test.java index ae6a807fac1..5392aad2bd4 100644 --- a/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/r4/FhirResourceDaoCreatePlaceholdersR4Test.java +++ b/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/r4/FhirResourceDaoCreatePlaceholdersR4Test.java @@ -287,7 +287,6 @@ public class FhirResourceDaoCreatePlaceholdersR4Test extends BaseJpaR4Test { assertEquals(0, patient.getIdentifier().size()); } - // FIXME: DM 2021-03-04 - This test fails; placeholder identifier isn't populated by default. @Test public void testCreatePlaceholderWithMatchUrl_IdentifierCopiedByDefault_WithUpdateToTarget() { myDaoConfig.setAutoCreatePlaceholderReferenceTargets(true); diff --git a/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/packages/NpmR4Test.java b/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/packages/NpmR4Test.java index 1f864c9471e..eeaa4eac020 100644 --- a/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/packages/NpmR4Test.java +++ b/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/packages/NpmR4Test.java @@ -357,9 +357,6 @@ public class NpmR4Test extends BaseJpaR4Test { } } - // FIXME: DM 2021-03-04 - This test is meant to validate that placeholder ValueSets are not created. - // FIXME: DM 2021-03-04 - This test or a new test should probably validate that placeholder ConceptMaps are also not created. - // FIXME: DM 2021-03-04 - This test does not validate that placeholder resources are created with a EXT_RESOURCE_META_PLACEHOLDER extension. // Reproduces https://github.com/hapifhir/hapi-fhir/issues/2332 @Test public void testInstallR4Package_AutoCreatePlaceholder() throws Exception {