honeymoose
/
hapi-fhir
mirror of https://github.com/hapifhir/hapi-fhir.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove useless log line

This commit is contained in:
James Agnew 2017-10-11 21:16:56 -04:00
parent 0ac53e55d4
commit 9d6bfdc25a
3 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
hapi-fhir-client/src/main/java/ca/uhn/fhir/rest/client/apache/ApacheHttpResponse.java
View File

@ -98,24 +98,23 @@ public class ApacheHttpResponse implements IHttpResponse {
} }
if (charset == null) { if (charset == null) {
if (Constants.STATUS_HTTP_204_NO_CONTENT != myResponse.getStatusLine().getStatusCode()) { if (Constants.STATUS_HTTP_204_NO_CONTENT != myResponse.getStatusLine().getStatusCode()) {
ourLog.warn("Response did not specify a charset."); ourLog.debug("Response did not specify a charset, defaulting to utf-8");
} }
charset = Charset.forName("UTF-8"); charset = Charset.forName("UTF-8");
} }
Reader reader = new InputStreamReader(readEntity(), charset); return new InputStreamReader(readEntity(), charset);
return reader;
} }
@Override @Override
public Map<String, List<String>> getAllHeaders() { public Map<String, List<String>> getAllHeaders() {
Map<String, List<String>> headers = new HashMap<String, List<String>>(); Map<String, List<String>> headers = new HashMap<>();
if (myResponse.getAllHeaders() != null) { if (myResponse.getAllHeaders() != null) {
for (Header next : myResponse.getAllHeaders()) { for (Header next : myResponse.getAllHeaders()) {
String name = next.getName().toLowerCase(); String name = next.getName().toLowerCase();
List<String> list = headers.get(name); List<String> list = headers.get(name);
if (list == null) { if (list == null) {
list = new ArrayList<String>(); list = new ArrayList<>();
headers.put(name, list); headers.put(name, list);
} }
list.add(next.getValue()); list.add(next.getValue());
@ -131,7 +130,7 @@ public class ApacheHttpResponse implements IHttpResponse {
if (headers == null) { if (headers == null) {
headers = new Header[0]; headers = new Header[0];
} }
List<String> retVal = new ArrayList<String>(); List<String> retVal = new ArrayList<>();
for (Header next : headers) { for (Header next : headers) {
retVal.add(next.getValue()); retVal.add(next.getValue());
} }

2
hapi-fhir-validation/src/main/java/org/hl7/fhir/dstu3/validation/InstanceValidator.java
View File

@ -292,7 +292,7 @@ public class InstanceValidator extends BaseValidator implements IResourceValidat
source = Source.InstanceValidator; source = Source.InstanceValidator;
} }
t
@Override @Override
public boolean isNoInvariantChecks() { public boolean isNoInvariantChecks() {

5
src/changes/changes.xml
View File

@ -64,6 +64,11 @@
If-Match header when passed in via If-Match header when passed in via
<![CDATA[<code>Bundle.entry.request.ifMatch</code>]]> value <![CDATA[<code>Bundle.entry.request.ifMatch</code>]]> value
</action> </action>
<action type="add">
In Apache client, remove a log message at WARN level when the response does not
specify a charset. This log line often showed up any time a server was not supplying
a response, making client logs quite noisy
</action>
</release> </release>
<release version="3.0.0" date="2017-09-27"> <release version="3.0.0" date="2017-09-27">
<action type="add"> <action type="add">