honeymoose/hapi-fhir
1
0
Fork 0
mirror of https://github.com/hapifhir/hapi-fhir.git synced 2025-03-09 14:33:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix replace references small batch test (#6586)

Browse Source 
* fix replace references small batch test

* added assertion for bundle sizes
This commit is contained in:
Emre Dincturk 2025-01-03 17:07:44 -05:00 committed by GitHub
parent cf9a90149b
commit b51ccdc696
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
hapi-fhir-jpaserver-test-r4/src/test/java/ca/uhn/fhir/jpa/provider/r4/ReplaceReferencesR4Test.java
View File

@ -22,6 +22,7 @@ import java.util.List;
import static ca.uhn.fhir.jpa.provider.ReplaceReferencesSvcImpl.RESOURCE_TYPES_SYSTEM;
import static ca.uhn.fhir.jpa.replacereferences.ReplaceReferencesTestHelper.EXPECTED_SMALL_BATCHES;
import static ca.uhn.fhir.jpa.replacereferences.ReplaceReferencesTestHelper.TOTAL_EXPECTED_PATCHES;
import static ca.uhn.fhir.rest.server.provider.ProviderConstants.OPERATION_REPLACE_REFERENCES_OUTPUT_PARAM_OUTCOME;
import static ca.uhn.fhir.rest.server.provider.ProviderConstants.OPERATION_REPLACE_REFERENCES_OUTPUT_PARAM_TASK;
import static org.assertj.core.api.Assertions.assertThat;
@ -123,8 +124,11 @@ public class ReplaceReferencesR4Test extends BaseResourceProviderR4Test {
.element(0)
.isInstanceOf(Bundle.class);
int entriesLeft = ReplaceReferencesTestHelper.TOTAL_EXPECTED_PATCHES;
for (int i = 1; i < EXPECTED_SMALL_BATCHES; i++) {
// for each batch, there should be a corresponding patch result bundle in the task as a contained resource.
// The loop below validates the patch result bundles, and counts total number of bundle entries seen
// to ensure that all patch results are accounted for.
int totalPatchResultEntriesSeen = 0;
for (int i = 0; i < EXPECTED_SMALL_BATCHES; i++) {
Task.TaskOutputComponent taskOutput = taskWithOutput.getOutput().get(i);
@ -139,13 +143,17 @@ public class ReplaceReferencesR4Test extends BaseResourceProviderR4Test {
patchResultBundle = (Bundle) outputRef.getResource();
assertTrue(containedBundle.equalsDeep(patchResultBundle));
int numberOfEntriesInCurrentBundle = patchResultBundle.getEntry().size();
// validate
entriesLeft -= ReplaceReferencesTestHelper.SMALL_BATCH_SIZE;
int expectedNumberOfEntries = Math.min(entriesLeft, ReplaceReferencesTestHelper.SMALL_BATCH_SIZE);
ReplaceReferencesTestHelper.validatePatchResultBundle(patchResultBundle, expectedNumberOfEntries, List.of("Observation",
totalPatchResultEntriesSeen += numberOfEntriesInCurrentBundle;
assertThat(numberOfEntriesInCurrentBundle).isBetween(1, ReplaceReferencesTestHelper.SMALL_BATCH_SIZE);
ReplaceReferencesTestHelper.validatePatchResultBundle(patchResultBundle, numberOfEntriesInCurrentBundle, List.of(
"Observation",
"Encounter", "CarePlan"));
}
assertThat(totalPatchResultEntriesSeen).isEqualTo(TOTAL_EXPECTED_PATCHES);
// Check that the linked resources were updated
myTestHelper.assertAllReferencesUpdated();