honeymoose/hapi-fhir
1
0
Fork 0
mirror of https://github.com/hapifhir/hapi-fhir.git synced 2025-02-21 04:15:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Missing split of auditevents (#5373)

Browse Source 
* Simple test showing missing auditevent

* Added one more test and fix to the bug

* Removed unused variable

* Added changelog

* Corrected based on feedback
This commit is contained in:
Jens Kristian Villadsen 2024-10-28 22:54:12 +01:00 committed by GitHub
parent 0235c517f8
commit b6c27cd933
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 64 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/7_8_0/6407-missing-conformity-to-ihe-balp.yaml Normal file
View File

@ -0,0 +1,4 @@
---
type: fix
issue: 6407
title: "Corrected IHE BALP AuditEvent generation, so that it records one Audit Event per resource owner. Thanks to Jens Villadsen (@jkiddo) for the contribution!"

7
hapi-fhir-storage/src/main/java/ca/uhn/fhir/storage/interceptor/balp/BalpAuditCaptureInterceptor.java
View File

@ -200,8 +200,11 @@ public class BalpAuditCaptureInterceptor {
Set<String> compartmentOwners = determinePatientCompartmentOwnersForResources(resources, theRequestDetails);
if (!compartmentOwners.isEmpty()) {
AuditEvent auditEvent = createAuditEventPatientQuery(theRequestDetails, compartmentOwners);
myAuditEventSink.recordAuditEvent(auditEvent);
for (String owner : compartmentOwners) {
AuditEvent auditEvent = createAuditEventPatientQuery(theRequestDetails, Set.of(owner));
myAuditEventSink.recordAuditEvent(auditEvent);
}
} else {
AuditEvent auditEvent = createAuditEventBasicQuery(theRequestDetails);
myAuditEventSink.recordAuditEvent(auditEvent);

55
hapi-fhir-storage/src/test/java/ca/uhn/fhir/storage/interceptor/balp/BalpAuditCaptureInterceptorTest.java
View File

@ -831,6 +831,61 @@ public class BalpAuditCaptureInterceptorTest implements ITestDataBuilder {
assertHasPatientEntities(auditEvent, patientId.toUnqualified().getValue());
}
@Test
public void testSearchMultiplePatientsWithMultipleAuditEvents()
{
Patient p1 = buildResource("Patient", withId("P1"), withFamily("Simpson"), withGiven("Homer"));
Patient p2 = buildResource("Patient", withId("P2"), withFamily("Simpson"), withGiven("Marge"));
myPatientProvider.store(p1);
myPatientProvider.store(p2);
myClient
.search()
.forResource(Patient.class)
.returnBundle(Bundle.class)
.execute();
verify(myAuditEventSink, times(2)).recordAuditEvent(myAuditEventCaptor.capture());
List<AuditEvent> values = myAuditEventCaptor.getAllValues();
verifyAuditEvent(values.get(0), "Patient/P1/_history/1");
verifyAuditEvent(values.get(1),"Patient/P2/_history/1");
}
@Test
public void testSearchObservationsAmongMultiplePatients()
{
Patient p1 = buildResource("Patient", withId("P1"), withFamily("Simpson"), withGiven("Homer"));
Patient p2 = buildResource("Patient", withId("P2"), withFamily("Simpson"), withGiven("Marge"));
myPatientProvider.store(p1);
myPatientProvider.store(p2);
createObservation(withId("O1"), withSubject("Patient/P1"));
createObservation(withId("O2"), withSubject("Patient/P2"));
Bundle outcome = myClient
.search()
.forResource(Observation.class)
.returnBundle(Bundle.class)
.execute();
verify(myAuditEventSink, times(2)).recordAuditEvent(myAuditEventCaptor.capture());
List<AuditEvent> values = myAuditEventCaptor.getAllValues();
verifyAuditEvent(values.get(0), "Patient/P1");
verifyAuditEvent(values.get(1),"Patient/P2");
}
private void verifyAuditEvent(AuditEvent auditEvent, String id) {
ourLog.info("Audit Event: {}", ourCtx.newJsonParser().setPrettyPrint(true).encodeResourceToString(auditEvent));
assertAuditEventValidatesAgainstBalpProfile(auditEvent);
assertHasProfile(auditEvent, BalpProfileEnum.PATIENT_QUERY);
assertType(auditEvent);
assertSubType(auditEvent, "search-type");
assertEquals(AuditEvent.AuditEventAction.E, auditEvent.getAction());
assertEquals(AuditEvent.AuditEventOutcome._0, auditEvent.getOutcome());
assertHasPatientEntities(auditEvent, id);
}
private void create10Observations(String... thePatientIds) {
for (int i = 0; i < 10; i++) {
createObservation(withId("O" + i), withSubject(thePatientIds[i % thePatientIds.length]));