From b79dd75fce86311fdcde0bc60e5a2bf308d0ad0c Mon Sep 17 00:00:00 2001
From: James <jamesagnew@gmail.com>
Date: Thu, 19 Oct 2017 07:40:43 -0400
Subject: [PATCH] Update to Spring 5

---
 hapi-deployable-pom/pom.xml                            |  4 ++++
 hapi-fhir-jpaserver-base/pom.xml                       |  2 ++
 .../uhn/fhir/jpa/provider/r4/JpaSystemProviderR4.java  |  3 ++-
 .../fhir/jpa/provider/r4/ResourceProviderR4Test.java   |  4 ++--
 hapi-fhir-structures-dstu3/pom.xml                     |  7 +++----
 .../java/ca/uhn/fhir/to/mvc/ToBindingInitializer.java  |  7 ++++++-
 src/changes/changes.xml                                | 10 ++++++++++
 7 files changed, 29 insertions(+), 8 deletions(-)

diff --git a/hapi-deployable-pom/pom.xml b/hapi-deployable-pom/pom.xml
index 3c169c7edc8..712cb060e23 100644
--- a/hapi-deployable-pom/pom.xml
+++ b/hapi-deployable-pom/pom.xml
@@ -111,6 +111,10 @@
 							<groupId>org.jscience</groupId>
 							<artifactId>jscience</artifactId>
 						</dependency>
+						<dependency>
+							<groupId>org.springframework</groupId>
+							<artifactId>spring-jcl</artifactId>
+						</dependency>
 					</ignoredDependencies>
 					<ignoredResources>
 						<ignoredResource>changelog.txt</ignoredResource>
diff --git a/hapi-fhir-jpaserver-base/pom.xml b/hapi-fhir-jpaserver-base/pom.xml
index 022a7a0ccf5..e1fdf6d1e0a 100644
--- a/hapi-fhir-jpaserver-base/pom.xml
+++ b/hapi-fhir-jpaserver-base/pom.xml
@@ -105,10 +105,12 @@
 			<version>${project.version}</version>
 		</dependency>
 
+		<!--
 		<dependency>
 			<groupId>org.slf4j</groupId>
 			<artifactId>jcl-over-slf4j</artifactId>
 		</dependency>
+		-->
 
 		<dependency>
 			<groupId>ch.qos.logback</groupId>
diff --git a/hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/provider/r4/JpaSystemProviderR4.java b/hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/provider/r4/JpaSystemProviderR4.java
index 83027e4dbfa..ead683fdfe1 100644
--- a/hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/provider/r4/JpaSystemProviderR4.java
+++ b/hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/provider/r4/JpaSystemProviderR4.java
@@ -45,7 +45,7 @@ public class JpaSystemProviderR4 extends BaseJpaSystemProviderDstu2Plus<Bundle,
 	@Qualifier("mySystemDaoR4")
 	private IFhirSystemDao<Bundle, Meta> mySystemDao;
 
-	@Autowired
+	@Autowired(required = false)
 	private IFulltextSearchSvc mySearchDao;
 	
 	//@formatter:off
@@ -175,6 +175,7 @@ public class JpaSystemProviderR4 extends BaseJpaSystemProviderDstu2Plus<Bundle,
 			@OperationParam(name="searchParam", min=1, max=1) String theSearchParam,
 			@OperationParam(name="text", min=1, max=1) String theText
 		) {
+		ca.uhn.fhir.jpa.provider.dstu3.JpaSystemProviderDstu3.validateFulltextSearchEnabled(mySearchDao);
 		
 		if (isBlank(theContext)) {
 			throw new InvalidRequestException("Parameter 'context' must be provided");
diff --git a/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/provider/r4/ResourceProviderR4Test.java b/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/provider/r4/ResourceProviderR4Test.java
index 7518aeb01ad..9b541dbab11 100644
--- a/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/provider/r4/ResourceProviderR4Test.java
+++ b/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/provider/r4/ResourceProviderR4Test.java
@@ -3150,7 +3150,7 @@ public class ResourceProviderR4Test extends BaseResourceProviderR4Test {
 	@Test
 	public void testSearchWithCountSearchResultsUpTo20() throws Exception {
 		mySearchCoordinatorSvcRaw.setSyncSizeForUnitTests(1);
-		mySearchCoordinatorSvcRaw.setLoadingThrottleForUnitTests(100);
+		mySearchCoordinatorSvcRaw.setLoadingThrottleForUnitTests(200);
 		myDaoConfig.setCountSearchResultsUpTo(20);
 
 		for (int i =0; i < 10; i++) {
@@ -3174,7 +3174,7 @@ public class ResourceProviderR4Test extends BaseResourceProviderR4Test {
 	@Test
 	public void testSearchWithCountSearchResultsUpTo5() throws Exception {
 		mySearchCoordinatorSvcRaw.setSyncSizeForUnitTests(1);
-		mySearchCoordinatorSvcRaw.setLoadingThrottleForUnitTests(100);
+		mySearchCoordinatorSvcRaw.setLoadingThrottleForUnitTests(200);
 		myDaoConfig.setCountSearchResultsUpTo(5);
 
 		for (int i =0; i < 10; i++) {
diff --git a/hapi-fhir-structures-dstu3/pom.xml b/hapi-fhir-structures-dstu3/pom.xml
index 02015f89e56..789424ae66a 100644
--- a/hapi-fhir-structures-dstu3/pom.xml
+++ b/hapi-fhir-structures-dstu3/pom.xml
@@ -1,4 +1,4 @@
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0"
 	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
 	<modelVersion>4.0.0</modelVersion>
 
@@ -120,9 +120,8 @@
 		-->
 		<dependency>
 			<groupId>javax.servlet</groupId>
-			<artifactId>servlet-api</artifactId>
-			<version>2.5</version>
-			<optional>true</optional>
+			<artifactId>javax.servlet-api</artifactId>
+			<version>3.0.1</version>
 		</dependency>
 
 		<!--
diff --git a/hapi-fhir-testpage-overlay/src/main/java/ca/uhn/fhir/to/mvc/ToBindingInitializer.java b/hapi-fhir-testpage-overlay/src/main/java/ca/uhn/fhir/to/mvc/ToBindingInitializer.java
index 6c3b0e4f12a..14f69789cb4 100644
--- a/hapi-fhir-testpage-overlay/src/main/java/ca/uhn/fhir/to/mvc/ToBindingInitializer.java
+++ b/hapi-fhir-testpage-overlay/src/main/java/ca/uhn/fhir/to/mvc/ToBindingInitializer.java
@@ -7,8 +7,13 @@ import org.springframework.web.context.request.WebRequest;
 public class ToBindingInitializer implements WebBindingInitializer {
 
 	@Override
-	public void initBinder(WebDataBinder theBinder, WebRequest theRequest) {
+	public void initBinder(WebDataBinder theBinder) {
 		theBinder.setFieldMarkerPrefix("__");
 	}
 
+	@Override
+	public void initBinder(WebDataBinder theBinder, WebRequest theRequest) {
+		// nothing
+	}
+
 }
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 63026091e2b..6b0733bba44 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -7,6 +7,16 @@
 	</properties>
 	<body>
 		<release version="3.1.0" date="TBD">
+			<action type="add">
+				The version of a few dependencies have been bumped to the
+				latest versions (dependent HAPI modules listed in brackets):
+				<![CDATA[
+					<ul>
+						<li>Spring (JPA): 4.3.10 -&gt; 5.0.0</li>
+					</ul>
+				]]>
+			</action>
+
 			<action type="fix">
 				The Android client module has been restored to working order, and no longer
 				requires a special classifier or an XML parser to be present in order to