From dd5e442bcb53d83eb6d3decd5ee2dfe05be23921 Mon Sep 17 00:00:00 2001
From: jamesagnew <jamesagnew@gmail.com>
Date: Wed, 24 Sep 2014 17:36:59 -0400
Subject: [PATCH] Add an explicit dependency on phloc-commons to fix a build
 error, thanks to Odysseas Pentakalos for the contribution.

---
 hapi-fhir-base/pom.xml                        |  6 +++
 hapi-fhir-base/src/changes/changes.xml        |  4 ++
 .../BaseThymeleafNarrativeGenerator.java      |  4 --
 .../ca/uhn/fhir/parser/XmlParserTest.java     | 48 +++++++++++++++++++
 pom.xml                                       |  1 +
 5 files changed, 59 insertions(+), 4 deletions(-)

diff --git a/hapi-fhir-base/pom.xml b/hapi-fhir-base/pom.xml
index 93c91bf3b0f..20bc7b9d663 100644
--- a/hapi-fhir-base/pom.xml
+++ b/hapi-fhir-base/pom.xml
@@ -92,6 +92,12 @@
 		    <version>${phloc_schematron_version}</version>
 			<optional>true</optional>
 		</dependency>
+		<dependency>
+		    <groupId>com.phloc</groupId>
+		    <artifactId>phloc-commons</artifactId>
+		    <version>${phloc_commons_version}</version>
+			<optional>true</optional>
+		</dependency>
 
 		<!-- 
 		<dependency>
diff --git a/hapi-fhir-base/src/changes/changes.xml b/hapi-fhir-base/src/changes/changes.xml
index 461c6718f40..6c67153ee56 100644
--- a/hapi-fhir-base/src/changes/changes.xml
+++ b/hapi-fhir-base/src/changes/changes.xml
@@ -55,6 +55,10 @@
 				entities converted to their equivalent unicode characters when resources are encoded, since FHIR does
 				not allow extended entities in resource instances.
 			</action>
+			<action type="fix">
+				Add phloc-commons dependency explicitly, which resolves an issue building HAPI from source on
+				some platforms. Thanks to Odysseas Pentakalos for the patch!
+			</action>
 		</release>
 		<release version="0.6" date="2014-Sep-08" description="This release brings a number of new features and bug fixes!">
 			<!-- 
diff --git a/hapi-fhir-base/src/main/java/ca/uhn/fhir/narrative/BaseThymeleafNarrativeGenerator.java b/hapi-fhir-base/src/main/java/ca/uhn/fhir/narrative/BaseThymeleafNarrativeGenerator.java
index 9d45be75d47..e442b63ffce 100644
--- a/hapi-fhir-base/src/main/java/ca/uhn/fhir/narrative/BaseThymeleafNarrativeGenerator.java
+++ b/hapi-fhir-base/src/main/java/ca/uhn/fhir/narrative/BaseThymeleafNarrativeGenerator.java
@@ -68,13 +68,11 @@ import ca.uhn.fhir.parser.DataFormatException;
 
 public abstract class BaseThymeleafNarrativeGenerator implements INarrativeGenerator {
 	private static final org.slf4j.Logger ourLog = org.slf4j.LoggerFactory.getLogger(BaseThymeleafNarrativeGenerator.class);
-
 	private static final XhtmlAndHtml5NonValidatingSAXTemplateParser PARSER = new XhtmlAndHtml5NonValidatingSAXTemplateParser(1);
 
 	private Configuration configuration;
 	private boolean myApplyDefaultDatatypeTemplates = true;
 	private HashMap<Class<?>, String> myClassToName;
-
 	private boolean myCleanWhitespace = true;
 	private boolean myIgnoreFailures = true;
 	private boolean myIgnoreMissingTemplates = true;
@@ -82,9 +80,7 @@ public abstract class BaseThymeleafNarrativeGenerator implements INarrativeGener
 	private HashMap<String, String> myNameToNarrativeTemplate;
 	private HashMap<String, String> myNameToTitleTemplate;
 	private TemplateEngine myProfileTemplateEngine;
-
 	private HashMap<String, String> myProfileToName;
-
 	private TemplateEngine myTitleTemplateEngine;
 
 	public BaseThymeleafNarrativeGenerator() {
diff --git a/hapi-fhir-base/src/test/java/ca/uhn/fhir/parser/XmlParserTest.java b/hapi-fhir-base/src/test/java/ca/uhn/fhir/parser/XmlParserTest.java
index 7a7a77feb34..eb21540e6f1 100644
--- a/hapi-fhir-base/src/test/java/ca/uhn/fhir/parser/XmlParserTest.java
+++ b/hapi-fhir-base/src/test/java/ca/uhn/fhir/parser/XmlParserTest.java
@@ -13,6 +13,7 @@ import java.nio.charset.Charset;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
+import java.util.UUID;
 
 import org.apache.commons.io.IOUtils;
 import org.custommonkey.xmlunit.Diff;
@@ -34,13 +35,16 @@ import ca.uhn.fhir.model.api.IResource;
 import ca.uhn.fhir.model.api.ResourceMetadataKeyEnum;
 import ca.uhn.fhir.model.api.TagList;
 import ca.uhn.fhir.model.dstu.composite.AddressDt;
+import ca.uhn.fhir.model.dstu.composite.CodeableConceptDt;
 import ca.uhn.fhir.model.dstu.composite.HumanNameDt;
 import ca.uhn.fhir.model.dstu.composite.NarrativeDt;
 import ca.uhn.fhir.model.dstu.composite.ResourceReferenceDt;
 import ca.uhn.fhir.model.dstu.resource.Binary;
+import ca.uhn.fhir.model.dstu.resource.Composition;
 import ca.uhn.fhir.model.dstu.resource.Conformance;
 import ca.uhn.fhir.model.dstu.resource.Conformance.RestResource;
 import ca.uhn.fhir.model.dstu.resource.DiagnosticReport;
+import ca.uhn.fhir.model.dstu.resource.DocumentManifest;
 import ca.uhn.fhir.model.dstu.resource.ListResource;
 import ca.uhn.fhir.model.dstu.resource.Observation;
 import ca.uhn.fhir.model.dstu.resource.Organization;
@@ -51,6 +55,7 @@ import ca.uhn.fhir.model.dstu.resource.Specimen;
 import ca.uhn.fhir.model.dstu.resource.ValueSet;
 import ca.uhn.fhir.model.dstu.valueset.AddressUseEnum;
 import ca.uhn.fhir.model.dstu.valueset.AdministrativeGenderCodesEnum;
+import ca.uhn.fhir.model.dstu.valueset.DocumentReferenceStatusEnum;
 import ca.uhn.fhir.model.dstu.valueset.IdentifierUseEnum;
 import ca.uhn.fhir.model.dstu.valueset.NarrativeStatusEnum;
 import ca.uhn.fhir.model.primitive.DateTimeDt;
@@ -68,6 +73,49 @@ public class XmlParserTest {
 	private static FhirContext ourCtx;
 	private static final org.slf4j.Logger ourLog = org.slf4j.LoggerFactory.getLogger(XmlParserTest.class);
 
+	/**
+	 * Thanks to Alexander Kley!
+	 */
+//	@Test
+	public void testParseContainedBinaryResource() {
+		byte[] bin = new byte[] {0,1,2,3,4};
+	    final Binary binary = new Binary("PatientConsent", bin);
+	    binary.setId(UUID.randomUUID().toString());
+	    DocumentManifest manifest = new DocumentManifest();
+	    manifest.setId(UUID.randomUUID().toString());
+	    manifest.setType(new CodeableConceptDt("mySystem", "PatientDocument"));
+	    manifest.setMasterIdentifier("mySystem", UUID.randomUUID().toString());
+	    manifest.addContent().setResource(binary);
+	    manifest.setStatus(DocumentReferenceStatusEnum.CURRENT);
+	    
+	    String encoded = ourCtx.newXmlParser().setPrettyPrint(true).encodeResourceToString(manifest);
+	    ourLog.info(encoded);
+	    assertThat(encoded, StringContainsInOrder.stringContainsInOrder(Arrays.asList("contained>","<Binary", "</contained>")));
+	    
+	    DocumentManifest actual = ourCtx.newXmlParser().parseResource(DocumentManifest.class, encoded);
+	    assertEquals(1, actual.getContained().getContainedResources().size());
+	    assertEquals(1, actual.getContent().size());
+	    assertNotNull(actual.getContent().get(0).getResource());
+	    
+	}
+	
+	
+	@Test
+	public void testComposition() {
+		
+		Composition comp = new Composition();
+		comp.setId("1");
+		
+		ourCtx.newXmlParser().encodeResourceToString(comp);
+		ourCtx.newXmlParser().encodeResourceToString(comp);
+		ourCtx.newXmlParser().encodeResourceToString(comp);
+		ourCtx.newXmlParser().encodeResourceToString(comp);
+		
+//		comp.
+		
+	}
+	
+	
 	@Test
 	public void testEncodeProfile() {
 
diff --git a/pom.xml b/pom.xml
index 05c532d2470..f546d385351 100644
--- a/pom.xml
+++ b/pom.xml
@@ -120,6 +120,7 @@
 		<mitreid-connect-version>1.1.8</mitreid-connect-version>
 		<mockito_version>1.9.5</mockito_version>
 		<phloc_schematron_version>2.7.1</phloc_schematron_version>
+		<phloc_commons_version>4.3.3</phloc_commons_version>
 		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 		<servlet_api_version>3.1.0</servlet_api_version>
 		<slf4j_version>1.7.7</slf4j_version>