From dd0e47afc305b1869ffcfedd7bd4f383c81dd7e5 Mon Sep 17 00:00:00 2001 From: James Date: Sat, 4 Feb 2017 16:31:18 -0500 Subject: [PATCH] Make projects import cleanly into eclipse --- .travis.yml | 2 +- .../org.eclipse.core.resources.prefs | 1 + .../org.eclipse.core.resources.prefs | 2 + hapi-fhir-jpaserver-base/pom.xml | 21 ++- hapi-fhir-structures-dstu/pom.xml | 18 ++ .../rest/server/SearchPostDstu2_1Test.java | 2 +- .../server/ServerMimetypeDstu2_1Test.java | 2 +- hapi-fhir-structures-dstu2/pom.xml | 47 +++-- .../fhir/rest/server/SearchPostDstu3Test.java | 2 +- .../rest/server/ServerMimetypeDstu3Test.java | 2 +- hapi-tinder-test/pom.xml | 175 +++++++++--------- pom.xml | 15 +- 12 files changed, 169 insertions(+), 120 deletions(-) diff --git a/.travis.yml b/.travis.yml index 048e6b014cb..026f024b581 100644 --- a/.travis.yml +++ b/.travis.yml @@ -20,4 +20,4 @@ before_script: script: # - mvn -e -B clean install && cd hapi-fhir-ra && mvn -e -B -DTRAVIS_JOB_ID=$TRAVIS_JOB_ID clean test jacoco:report coveralls:report - - mvn -Dci=true -e -B -P ALLMODULES,NOPARALLEL clean install && cd hapi-fhir-jacoco && mvn -e -B -DTRAVIS_JOB_ID=$TRAVIS_JOB_ID jacoco:report coveralls:report + - mvn -Dci=true -e -B -P ALLMODULES,NOPARALLEL,ERRORPRONE clean install && cd hapi-fhir-jacoco && mvn -e -B -DTRAVIS_JOB_ID=$TRAVIS_JOB_ID jacoco:report coveralls:report diff --git a/example-projects/hapi-fhir-base-example-embedded-ws/.settings/org.eclipse.core.resources.prefs b/example-projects/hapi-fhir-base-example-embedded-ws/.settings/org.eclipse.core.resources.prefs index 99f26c0203a..e9441bb123e 100644 --- a/example-projects/hapi-fhir-base-example-embedded-ws/.settings/org.eclipse.core.resources.prefs +++ b/example-projects/hapi-fhir-base-example-embedded-ws/.settings/org.eclipse.core.resources.prefs @@ -1,2 +1,3 @@ eclipse.preferences.version=1 +encoding//src/main/java=UTF-8 encoding/=UTF-8 diff --git a/example-projects/hapi-fhir-standalone-overlay-example/.settings/org.eclipse.core.resources.prefs b/example-projects/hapi-fhir-standalone-overlay-example/.settings/org.eclipse.core.resources.prefs index 99f26c0203a..f9fe34593fc 100644 --- a/example-projects/hapi-fhir-standalone-overlay-example/.settings/org.eclipse.core.resources.prefs +++ b/example-projects/hapi-fhir-standalone-overlay-example/.settings/org.eclipse.core.resources.prefs @@ -1,2 +1,4 @@ eclipse.preferences.version=1 +encoding//src/main/java=UTF-8 +encoding//src/test/java=UTF-8 encoding/=UTF-8 diff --git a/hapi-fhir-jpaserver-base/pom.xml b/hapi-fhir-jpaserver-base/pom.xml index 4a81d1bd6ef..132b010aa38 100644 --- a/hapi-fhir-jpaserver-base/pom.xml +++ b/hapi-fhir-jpaserver-base/pom.xml @@ -524,14 +524,29 @@ + + org.codehaus.mojo + build-helper-maven-plugin + + + add-source + generate-sources + + add-source + + + + target/generated-sources/tinder + + + + + ${basedir}/src/main/resources - - ${basedir}/target/generated-sources/tinder - ${basedir}/target/generated-resources/tinder diff --git a/hapi-fhir-structures-dstu/pom.xml b/hapi-fhir-structures-dstu/pom.xml index 1cb0d65eb58..aa358da5517 100644 --- a/hapi-fhir-structures-dstu/pom.xml +++ b/hapi-fhir-structures-dstu/pom.xml @@ -265,6 +265,24 @@ true + + org.codehaus.mojo + build-helper-maven-plugin + + + add-source + generate-sources + + add-source + + + + target/generated-sources/tinder + + + + + diff --git a/hapi-fhir-structures-dstu2.1/src/test/java/ca/uhn/fhir/rest/server/SearchPostDstu2_1Test.java b/hapi-fhir-structures-dstu2.1/src/test/java/ca/uhn/fhir/rest/server/SearchPostDstu2_1Test.java index 79b5a1b005c..731b88f8b92 100644 --- a/hapi-fhir-structures-dstu2.1/src/test/java/ca/uhn/fhir/rest/server/SearchPostDstu2_1Test.java +++ b/hapi-fhir-structures-dstu2.1/src/test/java/ca/uhn/fhir/rest/server/SearchPostDstu2_1Test.java @@ -72,7 +72,7 @@ public class SearchPostDstu2_1Test { ourLastSortSpec = null; ourLastName = null; - for (IServerInterceptor next : new ArrayList<>(ourServlet.getInterceptors())) { + for (IServerInterceptor next : new ArrayList(ourServlet.getInterceptors())) { ourServlet.unregisterInterceptor(next); } } diff --git a/hapi-fhir-structures-dstu2.1/src/test/java/ca/uhn/fhir/rest/server/ServerMimetypeDstu2_1Test.java b/hapi-fhir-structures-dstu2.1/src/test/java/ca/uhn/fhir/rest/server/ServerMimetypeDstu2_1Test.java index 70730cff212..8969b44efbe 100644 --- a/hapi-fhir-structures-dstu2.1/src/test/java/ca/uhn/fhir/rest/server/ServerMimetypeDstu2_1Test.java +++ b/hapi-fhir-structures-dstu2.1/src/test/java/ca/uhn/fhir/rest/server/ServerMimetypeDstu2_1Test.java @@ -75,7 +75,7 @@ public class ServerMimetypeDstu2_1Test { private List toStrings(List theFormat) { - ArrayList retVal = new ArrayList<>(); + ArrayList retVal = new ArrayList(); for (CodeType next : theFormat) { retVal.add(next.asStringValue()); } diff --git a/hapi-fhir-structures-dstu2/pom.xml b/hapi-fhir-structures-dstu2/pom.xml index 8c7a751c486..f5cd1d325aa 100644 --- a/hapi-fhir-structures-dstu2/pom.xml +++ b/hapi-fhir-structures-dstu2/pom.xml @@ -27,10 +27,7 @@ test - + javax.servlet servlet-api @@ -89,13 +86,7 @@ com.phloc phloc-schematron - test + test com.phloc @@ -119,11 +110,7 @@ commons-lang commons-lang - + @@ -140,11 +127,7 @@ commons-lang commons-lang - + @@ -252,9 +235,7 @@ deviceusestatement diagnosticorder diagnosticreport - + documentmanifest documentreference eligibilityrequest @@ -332,6 +313,24 @@ --> + + org.codehaus.mojo + build-helper-maven-plugin + + + add-source + generate-sources + + add-source + + + + target/generated-sources/tinder + + + + + diff --git a/hapi-fhir-structures-dstu3/src/test/java/ca/uhn/fhir/rest/server/SearchPostDstu3Test.java b/hapi-fhir-structures-dstu3/src/test/java/ca/uhn/fhir/rest/server/SearchPostDstu3Test.java index 1becf3dc3d4..32de1098112 100644 --- a/hapi-fhir-structures-dstu3/src/test/java/ca/uhn/fhir/rest/server/SearchPostDstu3Test.java +++ b/hapi-fhir-structures-dstu3/src/test/java/ca/uhn/fhir/rest/server/SearchPostDstu3Test.java @@ -82,7 +82,7 @@ public class SearchPostDstu3Test { ourLastSortSpec = null; ourLastName = null; - for (IServerInterceptor next : new ArrayList<>(ourServlet.getInterceptors())) { + for (IServerInterceptor next : new ArrayList(ourServlet.getInterceptors())) { ourServlet.unregisterInterceptor(next); } } diff --git a/hapi-fhir-structures-dstu3/src/test/java/ca/uhn/fhir/rest/server/ServerMimetypeDstu3Test.java b/hapi-fhir-structures-dstu3/src/test/java/ca/uhn/fhir/rest/server/ServerMimetypeDstu3Test.java index cccd3a2d90f..05ffa150167 100644 --- a/hapi-fhir-structures-dstu3/src/test/java/ca/uhn/fhir/rest/server/ServerMimetypeDstu3Test.java +++ b/hapi-fhir-structures-dstu3/src/test/java/ca/uhn/fhir/rest/server/ServerMimetypeDstu3Test.java @@ -69,7 +69,7 @@ public class ServerMimetypeDstu3Test { private List toStrings(List theFormat) { - ArrayList retVal = new ArrayList<>(); + ArrayList retVal = new ArrayList(); for (CodeType next : theFormat) { retVal.add(next.asStringValue()); } diff --git a/hapi-tinder-test/pom.xml b/hapi-tinder-test/pom.xml index c96532291e8..a5d6bab59d1 100644 --- a/hapi-tinder-test/pom.xml +++ b/hapi-tinder-test/pom.xml @@ -1,5 +1,4 @@ - + 4.0.0 @@ -30,10 +29,8 @@ hapi-fhir-structures-dstu2 ${project.version} - + ca.uhn.hapi.fhir hapi-fhir-structures-dstu2.1 @@ -76,17 +73,11 @@ - + ca.uhn.hapi.fhir @@ -268,11 +259,8 @@ - + @@ -286,77 +274,65 @@ - + - + - + - - ca.uhn.hapi.fhir - hapi-fhir-base - ${project.version} - - - ca.uhn.hapi.fhir - hapi-fhir-structures-dstu - ${project.version} - - - ca.uhn.hapi.fhir - hapi-fhir-structures-dstu2 - ${project.version} - - - ca.uhn.hapi.fhir - hapi-fhir-structures-dstu2.1 - ${project.version} - - - ca.uhn.hapi.fhir - hapi-fhir-base - - - - - ca.uhn.hapi.fhir - hapi-fhir-structures-dstu3 - ${project.version} - - - ca.uhn.hapi.fhir - hapi-fhir-structures-hl7org-dstu2 - ${project.version} - - - ca.uhn.hapi.fhir - hapi-fhir-validation-resources-dstu2 - ${project.version} - - - ca.uhn.hapi.fhir - hapi-fhir-validation-resources-dstu3 - ${project.version} - + + ca.uhn.hapi.fhir + hapi-fhir-base + ${project.version} + + + ca.uhn.hapi.fhir + hapi-fhir-structures-dstu + ${project.version} + + + ca.uhn.hapi.fhir + hapi-fhir-structures-dstu2 + ${project.version} + + + ca.uhn.hapi.fhir + hapi-fhir-structures-dstu2.1 + ${project.version} + + + ca.uhn.hapi.fhir + hapi-fhir-base + + + + + ca.uhn.hapi.fhir + hapi-fhir-structures-dstu3 + ${project.version} + + + ca.uhn.hapi.fhir + hapi-fhir-structures-hl7org-dstu2 + ${project.version} + + + ca.uhn.hapi.fhir + hapi-fhir-validation-resources-dstu2 + ${project.version} + + + ca.uhn.hapi.fhir + hapi-fhir-validation-resources-dstu3 + ${project.version} + ca.uhn.hapi.fhir hapi-tinder-plugin @@ -371,11 +347,28 @@ true + + org.codehaus.mojo + build-helper-maven-plugin + + + add-source + generate-sources + + add-source + + + + target/generated-sources/tinder + + + + + - + org.eclipse.m2e lifecycle-mapping @@ -428,6 +421,14 @@ + + + ${basedir}/src/main/resources + + + ${basedir}/target/generated-resources/tinder + + diff --git a/pom.xml b/pom.xml index a69e000b644..f47ee66a7b7 100644 --- a/pom.xml +++ b/pom.xml @@ -834,7 +834,6 @@ --> 1.8 1.8 - javac-with-errorprone true UTF-8 @@ -1677,6 +1676,20 @@ + + ERRORPRONE + + + + org.apache.maven.plugins + maven-compiler-plugin + + javac-with-errorprone + + + + +