diff --git a/hapi-fhir-android/src/test/java/ca/uhn/fhir/android/client/GenericClientDstu3IT.java b/hapi-fhir-android/src/test/java/ca/uhn/fhir/android/client/GenericClientDstu3IT.java index 96d535cbf88..791dc58b9fa 100644 --- a/hapi-fhir-android/src/test/java/ca/uhn/fhir/android/client/GenericClientDstu3IT.java +++ b/hapi-fhir-android/src/test/java/ca/uhn/fhir/android/client/GenericClientDstu3IT.java @@ -5,6 +5,7 @@ import static org.mockito.Mockito.mock; import static org.mockito.Mockito.when; import java.io.IOException; +import java.nio.charset.StandardCharsets; import java.util.Date; import org.hl7.fhir.dstu3.model.*; @@ -54,7 +55,7 @@ public class GenericClientDstu3IT { when(httpResponse.execute()).thenAnswer(new Answer() { @Override - public Response answer(InvocationOnMock theInvocation) throws Throwable { + public Response answer(InvocationOnMock theInvocation) { myAnswerCount++; return myHttpResponse; }}); @@ -70,7 +71,7 @@ public class GenericClientDstu3IT { private String extractBodyAsString(ArgumentCaptor capt) throws IOException { Buffer sink = new Buffer(); capt.getValue().body().writeTo(sink); - return new String(sink.readByteArray(), "UTF-8"); + return new String(sink.readByteArray(), StandardCharsets.UTF_8); } private void validateUserAgent(ArgumentCaptor capt) { @@ -103,7 +104,7 @@ public class GenericClientDstu3IT { pt.getText().setDivAsString("A PATIENT"); Binary bin = new Binary(); - bin.setContent(ourCtx.newJsonParser().encodeResourceToString(pt).getBytes("UTF-8")); + bin.setContent(ourCtx.newJsonParser().encodeResourceToString(pt).getBytes(StandardCharsets.UTF_8)); bin.setContentType(Constants.CT_FHIR_JSON); client.create().resource(bin).execute(); @@ -118,7 +119,7 @@ public class GenericClientDstu3IT { Binary output = ourCtx.newXmlParser().parseResource(Binary.class, extractBodyAsString(capt)); assertEquals(Constants.CT_FHIR_JSON, output.getContentType()); - Patient outputPt = (Patient) ourCtx.newJsonParser().parseResource(new String(output.getContent(), "UTF-8")); + Patient outputPt = (Patient) ourCtx.newJsonParser().parseResource(new String(output.getContent(), StandardCharsets.UTF_8)); assertEquals("
A PATIENT
", outputPt.getText().getDivAsString()); } @@ -137,7 +138,7 @@ public class GenericClientDstu3IT { .forResource(Patient.class) .where(Patient.FAMILY.matches().value((String)null)) .and(Patient.BIRTHDATE.exactly().day((Date)null)) - .and(Patient.GENDER.exactly().code((String)null)) + .and(Patient.GENDER.exactly().code(null)) .and(Patient.ORGANIZATION.hasId((String)null)) .returnBundle(Bundle.class) .execute(); @@ -188,7 +189,7 @@ public class GenericClientDstu3IT { @SuppressWarnings("unchecked") @Test - public void testClientFailures() throws Exception { + public void testClientFailures() { ResponseBody body = mock(ResponseBody.class); when(body.source()).thenThrow(IllegalStateException.class, RuntimeException.class); @@ -206,14 +207,14 @@ public class GenericClientDstu3IT { client.read().resource(Patient.class).withId("1").execute(); fail(); } catch (FhirClientConnectionException e) { - assertEquals("java.lang.IllegalStateException", e.getMessage()); + // good } try { client.read().resource(Patient.class).withId("1").execute(); fail(); } catch (RuntimeException e) { - assertEquals("java.lang.RuntimeException", e.toString()); + // good } } @@ -224,7 +225,7 @@ public class GenericClientDstu3IT { * TODO: narratives don't work without stax */ @Test - public void testCreateWithPreferRepresentationServerReturnsResource() throws Exception { + public void testCreateWithPreferRepresentationServerReturnsResource() { final IParser p = ourCtx.newJsonParser(); final Patient resp1 = new Patient(); @@ -255,7 +256,7 @@ public class GenericClientDstu3IT { } - private ArgumentCaptor prepareClientForSearchResponse() throws IOException { + private ArgumentCaptor prepareClientForSearchResponse() { final String respString = "{\"resourceType\":\"Bundle\",\"id\":null,\"base\":\"http://localhost:57931/fhir/contextDev\",\"total\":1,\"link\":[{\"relation\":\"self\",\"url\":\"http://localhost:57931/fhir/contextDev/Patient?identifier=urn%3AMultiFhirVersionTest%7CtestSubmitPatient01&_format=json\"}],\"entry\":[{\"resource\":{\"resourceType\":\"Patient\",\"id\":\"1\",\"meta\":{\"versionId\":\"1\",\"lastUpdated\":\"2014-12-20T18:41:29.706-05:00\"},\"identifier\":[{\"system\":\"urn:MultiFhirVersionTest\",\"value\":\"testSubmitPatient01\"}]}}]}"; myHttpResponse = new Response.Builder() .request(myRequest)