honeymoose
/
hapi-fhir
mirror of https://github.com/hapifhir/hapi-fhir.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add initial FIXMEs.

This commit is contained in:
Diederik Muylwyk 2021-03-04 13:45:09 -05:00
parent 8dcac3e8b7
commit e8c080bb12
4 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/index/DaoResourceLinkResolver.java
View File

@ -110,6 +110,7 @@ public class DaoResourceLinkResolver implements IResourceLinkResolver {
return resolvedResource;
}
// FIXME: DM 2021-03-04 - This is where placeholder reference targets are handled.
/**
* @param theIdToAssignToPlaceholder If specified, the placeholder resource created will be given a specific ID
*/
@ -123,6 +124,7 @@ public class DaoResourceLinkResolver implements IResourceLinkResolver {
@SuppressWarnings("unchecked")
T newResource = (T) missingResourceDef.newInstance();
// FIXME: DM 2021-03-04 - This is where the placeholder extension is added; should be in resource body instead of meta?
IBaseMetaType meta = newResource.getMeta();
if (meta instanceof IBaseHasExtensions) {
IBaseExtension<?, ?> extension = ((IBaseHasExtensions) meta).addExtension();

1
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/index/SearchParamWithInlineReferencesExtractor.java
View File

@ -214,6 +214,7 @@ public class SearchParamWithInlineReferencesExtractor {
}
// FIXME: DM 2021-03-04 - This is where inline match URLs are handled.
/**
* Handle references within the resource that are match URLs, for example references like "Patient?identifier=foo". These match URLs are resolved and replaced with the ID of the
* matching resource.

1
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/term/BaseTermReadSvcImpl.java
View File

@ -2123,6 +2123,7 @@ public abstract class BaseTermReadSvcImpl implements ITermReadSvc {
}
private boolean isPlaceholder(MetadataResource theResource) {
// FIXME: DM 2021-03-04 - We should probably check if this extension exists and the value is true.
return theResource.getMeta().getExtensionByUrl(HapiExtensions.EXT_RESOURCE_META_PLACEHOLDER) != null;
}

3
hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/packages/NpmR4Test.java
View File

@ -357,6 +357,9 @@ public class NpmR4Test extends BaseJpaR4Test {
}
}
// FIXME: DM 2021-03-04 - This test is meant to validate that placeholder ValueSets are not created.
// FIXME: DM 2021-03-04 - This test or a new test should probably validate that placeholder ConceptMaps are also not created.
// FIXME: DM 2021-03-04 - This test does not validate that placeholder resources are created with a EXT_RESOURCE_META_PLACEHOLDER extension.
// Reproduces https://github.com/hapifhir/hapi-fhir/issues/2332
@Test
public void testInstallR4Package_AutoCreatePlaceholder() throws Exception {