From fb0512f78f5e0a4cf1a0074c885953f5e7f383d3 Mon Sep 17 00:00:00 2001 From: michaelabuckley Date: Fri, 10 Feb 2023 09:30:55 -0500 Subject: [PATCH] Avoid logging message payloads that contain sensitive data (#4537) Don't log payloads - they may contain sensitive data. --- .../changelog/6_4_0/4537-message-to-string-redaction.yaml | 5 +++++ .../fhir/jpa/subscription/model/ResourceDeliveryMessage.java | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/6_4_0/4537-message-to-string-redaction.yaml diff --git a/hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/6_4_0/4537-message-to-string-redaction.yaml b/hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/6_4_0/4537-message-to-string-redaction.yaml new file mode 100644 index 00000000000..3341cbf3210 --- /dev/null +++ b/hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/6_4_0/4537-message-to-string-redaction.yaml @@ -0,0 +1,5 @@ +--- +type: change +issue: 4537 +title: "ResourceDeliveryMessage no longer includes the payload in toString(). + This avoids leaking sensitive data to logs and other channels." diff --git a/hapi-fhir-storage/src/main/java/ca/uhn/fhir/jpa/subscription/model/ResourceDeliveryMessage.java b/hapi-fhir-storage/src/main/java/ca/uhn/fhir/jpa/subscription/model/ResourceDeliveryMessage.java index e29755f3730..97d068e982a 100644 --- a/hapi-fhir-storage/src/main/java/ca/uhn/fhir/jpa/subscription/model/ResourceDeliveryMessage.java +++ b/hapi-fhir-storage/src/main/java/ca/uhn/fhir/jpa/subscription/model/ResourceDeliveryMessage.java @@ -128,7 +128,8 @@ public class ResourceDeliveryMessage extends BaseResourceMessage implements IRes public String toString() { return new ToStringBuilder(this) .append("mySubscription", mySubscription) - .append("myPayloadString", myPayloadString) + // it isn't safe to log payloads + .append("myPayloadString", "[Not Logged]") .append("myPayload", myPayloadDecoded) .append("myPayloadId", myPayloadId) .append("myPartitionId", myPartitionId)