From 76c01a98aab7687a500dc55a047aab13576a4cbd Mon Sep 17 00:00:00 2001
From: dotasek <dotasek.dev@gmail.com>
Date: Fri, 24 Feb 2023 15:05:49 -0500
Subject: [PATCH] Add basic checkstyle plugin config (#1122)

Co-authored-by: dotasek <david.otasek@smilecdr.com>
---
 checkstyle.xml                                | 27 +++++++++++++++++++
 .../checkstyle_suppressions.xml               |  8 ++++++
 .../checkstyle_suppressions.xml               |  8 ++++++
 .../checkstyle_suppressions.xml               |  8 ++++++
 .../checkstyle_suppressions.xml               |  8 ++++++
 org.hl7.fhir.r4/checkstyle_suppressions.xml   |  8 ++++++
 org.hl7.fhir.r4b/checkstyle_suppressions.xml  |  8 ++++++
 org.hl7.fhir.r5/checkstyle_suppressions.xml   |  8 ++++++
 .../checkstyle_suppressions.xml               |  8 ++++++
 .../checkstyle_suppressions.xml               |  8 ++++++
 .../checkstyle_suppressions.xml               |  8 ++++++
 .../checkstyle_suppressions.xml               |  8 ++++++
 pom.xml                                       | 20 +++++++++++---
 13 files changed, 132 insertions(+), 3 deletions(-)
 create mode 100644 checkstyle.xml
 create mode 100644 org.hl7.fhir.convertors/checkstyle_suppressions.xml
 create mode 100644 org.hl7.fhir.dstu2/checkstyle_suppressions.xml
 create mode 100644 org.hl7.fhir.dstu2016may/checkstyle_suppressions.xml
 create mode 100644 org.hl7.fhir.dstu3/checkstyle_suppressions.xml
 create mode 100644 org.hl7.fhir.r4/checkstyle_suppressions.xml
 create mode 100644 org.hl7.fhir.r4b/checkstyle_suppressions.xml
 create mode 100644 org.hl7.fhir.r5/checkstyle_suppressions.xml
 create mode 100644 org.hl7.fhir.report/checkstyle_suppressions.xml
 create mode 100644 org.hl7.fhir.utilities/checkstyle_suppressions.xml
 create mode 100644 org.hl7.fhir.validation.cli/checkstyle_suppressions.xml
 create mode 100644 org.hl7.fhir.validation/checkstyle_suppressions.xml

diff --git a/checkstyle.xml b/checkstyle.xml
new file mode 100644
index 000000000..625428252
--- /dev/null
+++ b/checkstyle.xml
@@ -0,0 +1,27 @@
+<?xml version="1.0"?>
+<!DOCTYPE module PUBLIC
+        "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
+        "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
+
+<module name="Checker">
+
+    <property name="severity" value="error"/>
+    <property name="charset" value="UTF-8"/>
+    <property name="fileExtensions" value="java, properties, xml, js, json"/>
+    <module name="TreeWalker">
+        <!--
+        <module name="TodoComment">-->
+            <!-- The (?i) below means Case Insensitive -->
+        <!--<property name="format" value="(?i)FIXME"/>
+-->
+  <module name="RegexpSinglelineJava">
+      <property name="format" value="org\.jetbrains\.annotations\.NotNull"/>
+  </module>
+  <module name="RegexpSinglelineJava">
+      <property name="format" value="org\.jetbrains\.annotations\.Nullable"/>
+  </module>
+  <module name="RegexpSinglelineJava">
+      <property name="format" value="org\.jetbrains\.annotations\.\*"/>
+  </module>
+</module>
+</module>
\ No newline at end of file
diff --git a/org.hl7.fhir.convertors/checkstyle_suppressions.xml b/org.hl7.fhir.convertors/checkstyle_suppressions.xml
new file mode 100644
index 000000000..1c51453aa
--- /dev/null
+++ b/org.hl7.fhir.convertors/checkstyle_suppressions.xml
@@ -0,0 +1,8 @@
+<?xml version="1.0"?>
+<!DOCTYPE suppressions PUBLIC
+        "-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN"
+        "https://checkstyle.org/dtds/suppressions_1_2.dtd">
+
+<suppressions>
+  
+</suppressions>
diff --git a/org.hl7.fhir.dstu2/checkstyle_suppressions.xml b/org.hl7.fhir.dstu2/checkstyle_suppressions.xml
new file mode 100644
index 000000000..1c51453aa
--- /dev/null
+++ b/org.hl7.fhir.dstu2/checkstyle_suppressions.xml
@@ -0,0 +1,8 @@
+<?xml version="1.0"?>
+<!DOCTYPE suppressions PUBLIC
+        "-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN"
+        "https://checkstyle.org/dtds/suppressions_1_2.dtd">
+
+<suppressions>
+  
+</suppressions>
diff --git a/org.hl7.fhir.dstu2016may/checkstyle_suppressions.xml b/org.hl7.fhir.dstu2016may/checkstyle_suppressions.xml
new file mode 100644
index 000000000..1c51453aa
--- /dev/null
+++ b/org.hl7.fhir.dstu2016may/checkstyle_suppressions.xml
@@ -0,0 +1,8 @@
+<?xml version="1.0"?>
+<!DOCTYPE suppressions PUBLIC
+        "-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN"
+        "https://checkstyle.org/dtds/suppressions_1_2.dtd">
+
+<suppressions>
+  
+</suppressions>
diff --git a/org.hl7.fhir.dstu3/checkstyle_suppressions.xml b/org.hl7.fhir.dstu3/checkstyle_suppressions.xml
new file mode 100644
index 000000000..1c51453aa
--- /dev/null
+++ b/org.hl7.fhir.dstu3/checkstyle_suppressions.xml
@@ -0,0 +1,8 @@
+<?xml version="1.0"?>
+<!DOCTYPE suppressions PUBLIC
+        "-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN"
+        "https://checkstyle.org/dtds/suppressions_1_2.dtd">
+
+<suppressions>
+  
+</suppressions>
diff --git a/org.hl7.fhir.r4/checkstyle_suppressions.xml b/org.hl7.fhir.r4/checkstyle_suppressions.xml
new file mode 100644
index 000000000..1c51453aa
--- /dev/null
+++ b/org.hl7.fhir.r4/checkstyle_suppressions.xml
@@ -0,0 +1,8 @@
+<?xml version="1.0"?>
+<!DOCTYPE suppressions PUBLIC
+        "-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN"
+        "https://checkstyle.org/dtds/suppressions_1_2.dtd">
+
+<suppressions>
+  
+</suppressions>
diff --git a/org.hl7.fhir.r4b/checkstyle_suppressions.xml b/org.hl7.fhir.r4b/checkstyle_suppressions.xml
new file mode 100644
index 000000000..1c51453aa
--- /dev/null
+++ b/org.hl7.fhir.r4b/checkstyle_suppressions.xml
@@ -0,0 +1,8 @@
+<?xml version="1.0"?>
+<!DOCTYPE suppressions PUBLIC
+        "-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN"
+        "https://checkstyle.org/dtds/suppressions_1_2.dtd">
+
+<suppressions>
+  
+</suppressions>
diff --git a/org.hl7.fhir.r5/checkstyle_suppressions.xml b/org.hl7.fhir.r5/checkstyle_suppressions.xml
new file mode 100644
index 000000000..1c51453aa
--- /dev/null
+++ b/org.hl7.fhir.r5/checkstyle_suppressions.xml
@@ -0,0 +1,8 @@
+<?xml version="1.0"?>
+<!DOCTYPE suppressions PUBLIC
+        "-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN"
+        "https://checkstyle.org/dtds/suppressions_1_2.dtd">
+
+<suppressions>
+  
+</suppressions>
diff --git a/org.hl7.fhir.report/checkstyle_suppressions.xml b/org.hl7.fhir.report/checkstyle_suppressions.xml
new file mode 100644
index 000000000..1c51453aa
--- /dev/null
+++ b/org.hl7.fhir.report/checkstyle_suppressions.xml
@@ -0,0 +1,8 @@
+<?xml version="1.0"?>
+<!DOCTYPE suppressions PUBLIC
+        "-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN"
+        "https://checkstyle.org/dtds/suppressions_1_2.dtd">
+
+<suppressions>
+  
+</suppressions>
diff --git a/org.hl7.fhir.utilities/checkstyle_suppressions.xml b/org.hl7.fhir.utilities/checkstyle_suppressions.xml
new file mode 100644
index 000000000..1291bd218
--- /dev/null
+++ b/org.hl7.fhir.utilities/checkstyle_suppressions.xml
@@ -0,0 +1,8 @@
+<?xml version="1.0"?>
+<!DOCTYPE suppressions PUBLIC
+        "-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN"
+        "https://checkstyle.org/dtds/suppressions_1_2.dtd">
+
+<suppressions>
+
+</suppressions>
diff --git a/org.hl7.fhir.validation.cli/checkstyle_suppressions.xml b/org.hl7.fhir.validation.cli/checkstyle_suppressions.xml
new file mode 100644
index 000000000..1291bd218
--- /dev/null
+++ b/org.hl7.fhir.validation.cli/checkstyle_suppressions.xml
@@ -0,0 +1,8 @@
+<?xml version="1.0"?>
+<!DOCTYPE suppressions PUBLIC
+        "-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN"
+        "https://checkstyle.org/dtds/suppressions_1_2.dtd">
+
+<suppressions>
+
+</suppressions>
diff --git a/org.hl7.fhir.validation/checkstyle_suppressions.xml b/org.hl7.fhir.validation/checkstyle_suppressions.xml
new file mode 100644
index 000000000..1291bd218
--- /dev/null
+++ b/org.hl7.fhir.validation/checkstyle_suppressions.xml
@@ -0,0 +1,8 @@
+<?xml version="1.0"?>
+<!DOCTYPE suppressions PUBLIC
+        "-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN"
+        "https://checkstyle.org/dtds/suppressions_1_2.dtd">
+
+<suppressions>
+
+</suppressions>
diff --git a/pom.xml b/pom.xml
index 2704139c6..7d6d344c6 100644
--- a/pom.xml
+++ b/pom.xml
@@ -184,9 +184,22 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-checkstyle-plugin</artifactId>
-                <configuration>
-                    <skip>true</skip>
-                </configuration>
+                <executions>
+                    <execution>
+                        <phase>process-sources</phase>
+                        <goals>
+                            <goal>checkstyle</goal>
+                        </goals>
+                        <configuration>
+                            <failsOnError>true</failsOnError>
+                            <suppressionsLocation>${project.basedir}/checkstyle_suppressions.xml</suppressionsLocation>
+                            <enableRulesSummary>true</enableRulesSummary>
+                            <enableSeveritySummary>true</enableSeveritySummary>
+                            <consoleOutput>true</consoleOutput>
+                            <configLocation>${project.basedir}/../checkstyle.xml</configLocation>
+                        </configuration>
+                    </execution>
+                </executions>
             </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
@@ -417,6 +430,7 @@
                 </executions>
             </plugin>
         </plugins>
+
     </build>
 
     <profiles>