honeymoose
/
org.hl7.fhir.core
mirror of https://github.com/hapifhir/org.hl7.fhir.core.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1259 from hapifhir/Type-validation-fixes 

Fix problem when profiling a base type that supports both Reference a…
This commit is contained in:
Grahame Grieve 2023-06-19 02:36:33 +10:00 committed by GitHub
parent 8bd4fc3ee6 8c494278f4
commit 96cadbed47
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 35 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

63
org.hl7.fhir.r5/src/main/java/org/hl7/fhir/r5/conformance/profile/ProfileUtilities.java
View File

@ -2679,53 +2679,60 @@ public class ProfileUtilities extends TranslatingUtilities {
CommaSeparatedStringBuilder b = new CommaSeparatedStringBuilder(); CommaSeparatedStringBuilder b = new CommaSeparatedStringBuilder();
String t = ts.getWorkingCode(); String t = ts.getWorkingCode();
for (TypeRefComponent td : base.getType()) {; for (TypeRefComponent td : base.getType()) {;
boolean matchType = false;
String tt = td.getWorkingCode(); String tt = td.getWorkingCode();
b.append(tt); b.append(tt);
if (td.hasCode() && (tt.equals(t))) { if (td.hasCode() && (tt.equals(t))) {
ok = true; matchType = true;
} }
if (!ok) { if (!matchType) {
StructureDefinition sdt = context.fetchTypeDefinition(tt); StructureDefinition sdt = context.fetchTypeDefinition(tt);
if (sdt != null && (sdt.getAbstract() || sdt.getKind() == StructureDefinitionKind.LOGICAL)) { if (sdt != null && (sdt.getAbstract() || sdt.getKind() == StructureDefinitionKind.LOGICAL)) {
StructureDefinition sdb = context.fetchTypeDefinition(t); StructureDefinition sdb = context.fetchTypeDefinition(t);
while (sdb != null && !ok) { while (sdb != null && !matchType) {
ok = sdb.getType().equals(sdt.getType()); matchType = sdb.getType().equals(sdt.getType());
sdb = context.fetchResource(StructureDefinition.class, sdb.getBaseDefinition(), sdb); sdb = context.fetchResource(StructureDefinition.class, sdb.getBaseDefinition(), sdb);
} }
} }
} }
// work around for old badly generated SDs // work around for old badly generated SDs
if (DONT_DO_THIS && Utilities.existsInList(tt, "Extension", "uri", "string", "Element")) { if (DONT_DO_THIS && Utilities.existsInList(tt, "Extension", "uri", "string", "Element")) {
ok = true; matchType = true;
} }
if (DONT_DO_THIS && Utilities.existsInList(tt, "Resource","DomainResource") && pkp.isResource(t)) { if (DONT_DO_THIS && Utilities.existsInList(tt, "Resource","DomainResource") && pkp.isResource(t)) {
ok = true; matchType = true;
} }
if (ok && ts.hasTargetProfile()) { if (matchType) {
// check that any derived target has a reference chain back to one of the base target profiles if (ts.hasTargetProfile()) {
for (UriType u : ts.getTargetProfile()) { // check that any derived target has a reference chain back to one of the base target profiles
String url = u.getValue(); for (UriType u : ts.getTargetProfile()) {
boolean tgtOk = !td.hasTargetProfile() || td.hasTargetProfile(url); String url = u.getValue();
while (url != null && !tgtOk) { boolean tgtOk = !td.hasTargetProfile() || td.hasTargetProfile(url);
StructureDefinition sd = context.fetchResource(StructureDefinition.class, url); while (url != null && !tgtOk) {
if (sd == null) { StructureDefinition sd = context.fetchResource(StructureDefinition.class, url);
if (messages != null) { if (sd == null) {
messages.add(new ValidationMessage(Source.InstanceValidator, IssueType.BUSINESSRULE, purl+"#"+derived.getPath(), "Cannot check whether the target profile "+url+" is valid constraint on the base because it is not known", IssueSeverity.WARNING)); if (messages != null) {
messages.add(new ValidationMessage(Source.InstanceValidator, IssueType.BUSINESSRULE, purl + "#" + derived.getPath(), "Cannot check whether the target profile " + url + " is valid constraint on the base because it is not known", IssueSeverity.WARNING));
}
url = null;
tgtOk = true; // suppress error message
} else {
url = sd.getBaseDefinition();
tgtOk = td.hasTargetProfile(url);
}
}
if (tgtOk)
ok = true;
else {
if (messages == null) {
throw new FHIRException(context.formatMessage(I18nConstants.ERROR_AT__THE_TARGET_PROFILE__IS_NOT__VALID_CONSTRAINT_ON_THE_BASE_, purl, derived.getPath(), url, td.getTargetProfile()));
} else {
messages.add(new ValidationMessage(Source.InstanceValidator, IssueType.BUSINESSRULE, derived.getPath(), "The target profile " + u.getValue() + " is not a valid constraint on the base (" + td.getTargetProfile() + ") at " + derived.getPath(), IssueSeverity.ERROR));
} }
url = null;
tgtOk = true; // suppress error message
} else {
url = sd.getBaseDefinition();
tgtOk = td.hasTargetProfile(url);
}
}
if (!tgtOk) {
if (messages == null) {
throw new FHIRException(context.formatMessage(I18nConstants.ERROR_AT__THE_TARGET_PROFILE__IS_NOT__VALID_CONSTRAINT_ON_THE_BASE_, purl, derived.getPath(), url, td.getTargetProfile()));
} else {
messages.add(new ValidationMessage(Source.InstanceValidator, IssueType.BUSINESSRULE, derived.getPath(), "The target profile "+u.getValue()+" is not a valid constraint on the base ("+td.getTargetProfile()+") at "+derived.getPath(), IssueSeverity.ERROR));
} }
} }
} else {
ok = true;
} }
} }
} }