honeymoose
/
org.hl7.fhir.core
mirror of https://github.com/hapifhir/org.hl7.fhir.core.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Avoid reflection

This commit is contained in:
jamesagnew 2022-01-16 13:50:10 -05:00 committed by James Agnew
parent 942d4f15aa
commit f902d1d273
1 changed files with 17 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
org.hl7.fhir.r5/src/main/java/org/hl7/fhir/r5/formats/FormatUtilities.java
View File

@ -123,27 +123,26 @@ public abstract class FormatUtilities {
public static ParserBase makeParser(String format) { public static ParserBase makeParser(String format) {
/* /*
* Note: In this class we're instantiating the parsers using reflection. This is because the * Note: Use fully qualified references to the parsers here in order to avoid adding
* a class-level import statement for them. This is because the
* XmlParser and JsonParser are huuuuuge classes and classloading them is quite expensive * XmlParser and JsonParser are huuuuuge classes and classloading them is quite expensive
* in cases where they won't actually ever be instantiated (such as when using the * in cases where they won't actually ever be instantiated (such as when using the
* validator in HAPI FHIR) * validator in HAPI FHIR).
*
* See https://github.com/hapifhir/hapi-fhir/issues/3268
*/ */
try { if ("XML".equalsIgnoreCase(format))
if ("XML".equalsIgnoreCase(format)) return new org.hl7.fhir.r5.formats.XmlParser();
return (ParserBase) Class.forName("org.hl7.fhir.r5.formats.XmlParser").getConstructor().newInstance(); if ("JSON".equalsIgnoreCase(format))
if ("JSON".equalsIgnoreCase(format)) return new org.hl7.fhir.r5.formats.JsonParser();
return (ParserBase) Class.forName("org.hl7.fhir.r5.formats.JsonParser").getConstructor().newInstance(); if ("TURTLE".equalsIgnoreCase(format))
if ("TURTLE".equalsIgnoreCase(format)) throw new Error("unsupported Format " + format.toString()); // return new TurtleParser();
throw new Error("unsupported Format " + format.toString()); // return new TurtleParser(); if ("JSONLD".equalsIgnoreCase(format))
if ("JSONLD".equalsIgnoreCase(format)) throw new Error("unsupported Format " + format.toString()); // return new JsonLdParser();
throw new Error("unsupported Format " + format.toString()); // return new JsonLdParser(); if ("VBAR".equalsIgnoreCase(format)) throw new Error("unsupported Format " + format.toString()); //
if ("VBAR".equalsIgnoreCase(format)) throw new Error("unsupported Format " + format.toString()); // if ("TEXT".equalsIgnoreCase(format)) throw new Error("unsupported Format " + format.toString()); //
if ("TEXT".equalsIgnoreCase(format)) throw new Error("unsupported Format " + format.toString()); // throw new Error("unsupported Format " + format);
throw new Error("unsupported Format " + format); }
} catch (ClassNotFoundException | NoSuchMethodException | InstantiationException | IllegalAccessException | InvocationTargetException e) {
throw new IllegalStateException("Failed to create parser", e);
}
}
public static FhirFormat determineFormat(byte[] source) throws FHIRException { public static FhirFormat determineFormat(byte[] source) throws FHIRException {
return determineFormat(source, MAX_SCAN_LENGTH); return determineFormat(source, MAX_SCAN_LENGTH);