From 8d7bbe38d614d550d663c5a757375c28ac00076c Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Mon, 7 Dec 2020 18:17:42 -0800 Subject: [PATCH] test: ensure file is closed after reading (#95) --- .../src/test/java/com/microsoft/playwright/TestHar.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/playwright/src/test/java/com/microsoft/playwright/TestHar.java b/playwright/src/test/java/com/microsoft/playwright/TestHar.java index 92c3e3fa..bf570522 100644 --- a/playwright/src/test/java/com/microsoft/playwright/TestHar.java +++ b/playwright/src/test/java/com/microsoft/playwright/TestHar.java @@ -27,6 +27,7 @@ import org.junit.jupiter.api.Test; import java.io.FileNotFoundException; import java.io.FileReader; import java.io.IOException; +import java.io.Reader; import java.nio.file.Files; import java.nio.file.Path; @@ -127,8 +128,10 @@ public class TestHar extends TestBase { Deferred loadEvent = page.waitForLoadState(Page.LoadState.DOMCONTENTLOADED); loadEvent.get(); context.close(); - JsonObject log = new Gson().fromJson(new FileReader(harPath.toFile()), JsonObject.class).getAsJsonObject("log"); - + JsonObject log; + try (Reader reader = new FileReader(harPath.toFile())) { + log = new Gson().fromJson(reader, JsonObject.class).getAsJsonObject("log"); + } assertEquals(1, log.getAsJsonArray("pages").size()); JsonObject pageEntry = log.getAsJsonArray("pages").get(0).getAsJsonObject(); assertEquals("page_0", pageEntry.get("id").getAsString());