From b8d2ccae087c8ac26281dad3d34aff93f33c385f Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Tue, 26 Apr 2022 17:01:50 -0700 Subject: [PATCH] fix: respect isChecked options (#911) --- .../playwright/impl/LocatorAssertionsImpl.java | 3 ++- .../playwright/TestLocatorAssertions.java | 14 ++++++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/playwright/src/main/java/com/microsoft/playwright/impl/LocatorAssertionsImpl.java b/playwright/src/main/java/com/microsoft/playwright/impl/LocatorAssertionsImpl.java index 88330041..246e536e 100644 --- a/playwright/src/main/java/com/microsoft/playwright/impl/LocatorAssertionsImpl.java +++ b/playwright/src/main/java/com/microsoft/playwright/impl/LocatorAssertionsImpl.java @@ -257,7 +257,8 @@ public class LocatorAssertionsImpl extends AssertionsBase implements LocatorAsse @Override public void isChecked(IsCheckedOptions options) { - expectTrue("to.be.checked", "Locator expected to be checked", convertType(options, FrameExpectOptions.class)); + String expression = (options != null && options.checked != null && !options.checked) ? "to.be.unchecked" : "to.be.checked"; + expectTrue(expression, "Locator expected to be checked", convertType(options, FrameExpectOptions.class)); } @Override diff --git a/playwright/src/test/java/com/microsoft/playwright/TestLocatorAssertions.java b/playwright/src/test/java/com/microsoft/playwright/TestLocatorAssertions.java index c9c37730..0ccc6f8b 100644 --- a/playwright/src/test/java/com/microsoft/playwright/TestLocatorAssertions.java +++ b/playwright/src/test/java/com/microsoft/playwright/TestLocatorAssertions.java @@ -118,6 +118,13 @@ public class TestLocatorAssertions extends TestBase { } } + @Test + void hasTextWTextInnerTextPass() { + page.setContent("
Text content
"); + Locator locator = page.locator("#node"); + assertThat(locator).hasText("Text content", new LocatorAssertions.HasTextOptions().setUseInnerText(true)); + } + @Test void hasTextWTextArrayPass() { page.setContent("
Text \n1
Text 2a
"); @@ -577,6 +584,13 @@ public class TestLocatorAssertions extends TestBase { } } + @Test + void isCheckedFalsePass() { + page.setContent(""); + Locator locator = page.locator("input"); + assertThat(locator).isChecked(new LocatorAssertions.IsCheckedOptions().setChecked(false)); + } + @Test void isDisabledPass() { page.setContent("");