honeymoose/playwright-java
1
0
Fork 0
mirror of https://github.com/microsoft/playwright-java.git synced 2026-02-12 08:24:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: serialize LocalDateTime parameters as Date (#1048)

Browse Source
This commit is contained in:
Yury Semikhatsky 2022-09-07 16:41:37 -07:00 committed by GitHub
parent 4a0ff6ef5c
commit cf73a8d525
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java
View File

@ -33,6 +33,8 @@ import java.net.URL;
import java.nio.charset.StandardCharsets;
import java.nio.file.Path;
import java.time.Instant;
import java.time.LocalDateTime;
import java.time.ZoneId;
import java.util.*;
import java.util.regex.Pattern;
@ -150,6 +152,8 @@ class Serialization {
result.s = (String) value;
} else if (value instanceof Date) {
result.d = ((Date)value).toInstant().toString();
} else if (value instanceof LocalDateTime) {
result.d = ((LocalDateTime)value).atZone(ZoneId.systemDefault()).toInstant().toString();
} else if (value instanceof URL) {
result.u = ((URL)value).toString();
} else if (value instanceof Pattern) {

11
playwright/src/test/java/com/microsoft/playwright/TestPageEvaluate.java
View File

@ -19,12 +19,12 @@ package com.microsoft.playwright;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.condition.DisabledIf;
import java.time.*;
import java.util.Map;
import java.util.regex.Pattern;
import java.util.Date;
import java.net.MalformedURLException;
import java.net.URL;
import java.time.ZonedDateTime;
import static com.microsoft.playwright.Utils.mapOf;
import static java.util.Arrays.asList;
@ -629,4 +629,13 @@ public class TestPageEvaluate extends TestBase {
assertEquals(1, map.size());
assertTrue(map == map.get("b"));
}
@Test
void shouldAcceptParameter() {
Instant instant = Instant.now();
LocalDateTime localDateTime = instant.atZone(ZoneId.systemDefault()).toLocalDateTime();
Object object = page.evaluate("p => p", localDateTime);
assertTrue(object instanceof Date);
assertEquals(Date.from(instant), object);
}
}