From d14d35610ec0164248e119992ff9a12fa0bf0dfb Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Tue, 2 Feb 2021 12:49:20 -0800 Subject: [PATCH] chore: remove custom generator code for Response.finished (#248) --- scripts/CLI_VERSION | 2 +- .../playwright/tools/ApiGenerator.java | 3 +++ .../com/microsoft/playwright/tools/Types.java | 25 ------------------- 3 files changed, 4 insertions(+), 26 deletions(-) diff --git a/scripts/CLI_VERSION b/scripts/CLI_VERSION index a38dbcb3..25637939 100644 --- a/scripts/CLI_VERSION +++ b/scripts/CLI_VERSION @@ -1 +1 @@ -1.9.0-next-1612292242000 +1.9.0-next-1612297085000 diff --git a/tools/api-generator/src/main/java/com/microsoft/playwright/tools/ApiGenerator.java b/tools/api-generator/src/main/java/com/microsoft/playwright/tools/ApiGenerator.java index f2015594..73023fda 100644 --- a/tools/api-generator/src/main/java/com/microsoft/playwright/tools/ApiGenerator.java +++ b/tools/api-generator/src/main/java/com/microsoft/playwright/tools/ApiGenerator.java @@ -292,6 +292,9 @@ class TypeRef extends Element { if ("any".equals(name)) { return "Object"; } + if ("Readable".equals(name)) { + return "InputStream"; + } if ("Buffer".equals(name)) { return "byte[]"; } diff --git a/tools/api-generator/src/main/java/com/microsoft/playwright/tools/Types.java b/tools/api-generator/src/main/java/com/microsoft/playwright/tools/Types.java index 11ef031e..1c1b4ae1 100644 --- a/tools/api-generator/src/main/java/com/microsoft/playwright/tools/Types.java +++ b/tools/api-generator/src/main/java/com/microsoft/playwright/tools/Types.java @@ -119,17 +119,6 @@ class Types { add("Browser.newContext.options.httpCredentials", "Object", "BrowserContext.HTTPCredentials", new Empty()); add("Browser.newPage.options.httpCredentials", "Object", "BrowserContext.HTTPCredentials", new Empty()); add("BrowserType.launchPersistentContext.options.httpCredentials", "Object", "BrowserContext.HTTPCredentials", new Empty()); - add("BrowserContext.setHTTPCredentials.httpCredentials", "Object|null", "do nothing", new Empty()); - - // js functions are always passed as text in java. - add("Page.$eval.pageFunction", "function(Element)", "String"); - add("Page.$$eval.pageFunction", "function(Array)", "String"); - add("Frame.$eval.pageFunction", "function(Element)", "String"); - add("Frame.$$eval.pageFunction", "function(Array)", "String"); - add("ElementHandle.$eval.pageFunction", "function(Element)", "String"); - add("ElementHandle.$$eval.pageFunction", "function(Array)", "String"); - add("ElementHandle.evaluate.pageFunction", "function", "String"); - add("JSHandle.evaluate.pageFunction", "function", "String"); add("BrowserContext.exposeBinding.callback", "function", "Page.Binding"); add("BrowserContext.exposeFunction.callback", "function", "Page.Function"); @@ -213,25 +202,11 @@ class Types { add("Browser.newPage.options.storageState", "Object|path", "BrowserContext.StorageState", new Empty()); add("Browser.newPage.options.geolocation", "Object", "Geolocation", new Empty()); add("BrowserType.launchPersistentContext.options.geolocation", "Object", "Geolocation", new Empty()); - add("Download.createReadStream", "Readable|null", "InputStream", new Empty()); // node.js types - add("BrowserServer.process", "ChildProcess", "Object"); - - add("Response.finished", "Error|null", "String"); - add("Route.continue_.options", "Object", "ContinueOptions"); // TODO: fix upstream types! - add("Request.headers", "Object", "Map", new Empty()); - add("Response.headers", "Object", "Map", new Empty()); - add("Browser.newContext.options.extraHTTPHeaders", "Object", "Map", new Empty()); - add("Browser.newPage.options.extraHTTPHeaders", "Object", "Map", new Empty()); - add("BrowserType.launchPersistentContext.options.extraHTTPHeaders", "Object", "Map", new Empty()); - add("Page.setExtraHTTPHeaders.headers", "Object", "Map", new Empty()); - add("BrowserContext.setExtraHTTPHeaders.headers", "Object", "Map", new Empty()); - add("Route.continue_.options.headers", "Object", "Map", new Empty()); - add("Route.fulfill.options.headers", "Object", "Map", new Empty()); add("Playwright.devices", "Object", "Map", new Empty()); }