diff --git a/playwright/src/main/java/com/microsoft/playwright/impl/BrowserContextImpl.java b/playwright/src/main/java/com/microsoft/playwright/impl/BrowserContextImpl.java index 768a336f..1fbcac3b 100644 --- a/playwright/src/main/java/com/microsoft/playwright/impl/BrowserContextImpl.java +++ b/playwright/src/main/java/com/microsoft/playwright/impl/BrowserContextImpl.java @@ -445,6 +445,10 @@ class BrowserContextImpl extends ChannelOwner implements BrowserContext { @Override public void setDefaultNavigationTimeout(double timeout) { + setDefaultNavigationTimeoutImpl(timeout); + } + + void setDefaultNavigationTimeoutImpl(Double timeout) { withLogging("BrowserContext.setDefaultNavigationTimeout", () -> { timeoutSettings.setDefaultNavigationTimeout(timeout); JsonObject params = new JsonObject(); @@ -455,6 +459,10 @@ class BrowserContextImpl extends ChannelOwner implements BrowserContext { @Override public void setDefaultTimeout(double timeout) { + setDefaultTimeoutImpl(timeout); + } + + void setDefaultTimeoutImpl(Double timeout) { withLogging("BrowserContext.setDefaultTimeout", () -> { timeoutSettings.setDefaultTimeout(timeout); JsonObject params = new JsonObject(); diff --git a/playwright/src/main/java/com/microsoft/playwright/impl/PageImpl.java b/playwright/src/main/java/com/microsoft/playwright/impl/PageImpl.java index 201e1a17..f3cdedc6 100644 --- a/playwright/src/main/java/com/microsoft/playwright/impl/PageImpl.java +++ b/playwright/src/main/java/com/microsoft/playwright/impl/PageImpl.java @@ -938,13 +938,13 @@ public class PageImpl extends ChannelOwner implements Page { withLogging("Page.pause", () -> { Double defaultNavigationTimeout = browserContext.timeoutSettings.defaultNavigationTimeout(); Double defaultTimeout = browserContext.timeoutSettings.defaultTimeout(); - browserContext.setDefaultNavigationTimeout(0); - browserContext.setDefaultTimeout(0); + browserContext.setDefaultNavigationTimeoutImpl(0.0); + browserContext.setDefaultTimeoutImpl(0.0); try { runUntil(() -> {}, new WaitableRace<>(asList(context().pause(), (Waitable) waitableClosedOrCrashed))); } finally { - browserContext.setDefaultNavigationTimeout(defaultNavigationTimeout); - browserContext.setDefaultTimeout(defaultTimeout); + browserContext.setDefaultNavigationTimeoutImpl(defaultNavigationTimeout); + browserContext.setDefaultTimeoutImpl(defaultTimeout); } }); } diff --git a/playwright/src/main/java/com/microsoft/playwright/impl/TimeoutSettings.java b/playwright/src/main/java/com/microsoft/playwright/impl/TimeoutSettings.java index 9507502e..3a311d43 100644 --- a/playwright/src/main/java/com/microsoft/playwright/impl/TimeoutSettings.java +++ b/playwright/src/main/java/com/microsoft/playwright/impl/TimeoutSettings.java @@ -37,11 +37,11 @@ class TimeoutSettings { return defaultNavigationTimeout; } - void setDefaultTimeout(double timeout) { + void setDefaultTimeout(Double timeout) { defaultTimeout = timeout; } - void setDefaultNavigationTimeout(double timeout) { + void setDefaultNavigationTimeout(Double timeout) { defaultNavigationTimeout = timeout; }