From db1c899cf68774ac095befe3d39d463c970399bb Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Wed, 11 Oct 2023 15:23:46 -0700 Subject: [PATCH] chore: unflake TestBrowserContextProxy.shouldExcludePatterns (#1404) --- .../playwright/TestBrowserContextProxy.java | 38 +++++++++++++------ 1 file changed, 27 insertions(+), 11 deletions(-) diff --git a/playwright/src/test/java/com/microsoft/playwright/TestBrowserContextProxy.java b/playwright/src/test/java/com/microsoft/playwright/TestBrowserContextProxy.java index ad9ac396..a054cb9a 100644 --- a/playwright/src/test/java/com/microsoft/playwright/TestBrowserContextProxy.java +++ b/playwright/src/test/java/com/microsoft/playwright/TestBrowserContextProxy.java @@ -175,17 +175,33 @@ public class TestBrowserContextProxy extends TestBase { // @see https://gist.github.com/CollinChaffin/24f6c9652efb3d6d5ef2f5502720ef00 .setBypass("1.non.existent.domain.for.the.test, 2.non.existent.domain.for.the.test, .another.test"))); - Page page = context.newPage(); - page.navigate("http://0.non.existent.domain.for.the.test/target.html"); - assertEquals("Served by the proxy", page.title()); - - assertThrows(PlaywrightException.class, () -> page.navigate("http://1.non.existent.domain.for.the.test/target.html")); - assertThrows(PlaywrightException.class, () -> page.navigate("http://2.non.existent.domain.for.the.test/target.html")); - assertThrows(PlaywrightException.class, () -> page.navigate("http://foo.is.the.another.test/target.html")); - - page.navigate("http://3.non.existent.domain.for.the.test/target.html"); - assertEquals("Served by the proxy", page.title()); - + { + Page page = context.newPage(); + page.navigate("http://0.non.existent.domain.for.the.test/target.html"); + assertEquals("Served by the proxy", page.title()); + page.close(); + } + { + Page page = context.newPage(); + assertThrows(PlaywrightException.class, () -> page.navigate("http://1.non.existent.domain.for.the.test/target.html")); + page.close(); + } + { + Page page = context.newPage(); + assertThrows(PlaywrightException.class, () -> page.navigate("http://2.non.existent.domain.for.the.test/target.html")); + page.close(); + } + { + Page page = context.newPage(); + assertThrows(PlaywrightException.class, () -> page.navigate("http://foo.is.the.another.test/target.html")); + page.close(); + } + { + Page page = context.newPage(); + page.navigate("http://3.non.existent.domain.for.the.test/target.html"); + assertEquals("Served by the proxy", page.title()); + page.close(); + } context.close(); }