honeymoose
/
sp-dev-fx-webparts
mirror of https://github.com/pnp/sp-dev-fx-webparts.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

resolve lint warnings

This commit is contained in:
reshmee011 2023-03-06 21:48:55 +00:00
parent eeb1998d86
commit 0206a69f61
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
samples/react-twitter/src/webparts/twitterFeed/TwitterFeedWebPart.ts
View File

@ -21,7 +21,7 @@ export interface ITwitterFeedWebPartProps extends ITwittweTimelineSettings {
} }
export default class TwitterFeedWebPart extends BaseClientSideWebPart<ITwitterFeedWebPartProps> { export default class TwitterFeedWebPart extends BaseClientSideWebPart<ITwitterFeedWebPartProps> {
private _rootElement: HTMLElement;
public onInit(): Promise<void> { public onInit(): Promise<void> {
if (!this.properties.sourceType) { if (!this.properties.sourceType) {
this.properties.sourceType = 'profile'; this.properties.sourceType = 'profile';
@ -47,20 +47,24 @@ export default class TwitterFeedWebPart extends BaseClientSideWebPart<ITwitterFe
} }
} }
); );
if (!this._rootElement) {
this._rootElement = document.createElement("div");
this.domElement.appendChild(this._rootElement);
}
ReactDom.unmountComponentAtNode(this.domElement); ReactDom.render(element, this._rootElement);
ReactDom.render(element, this.domElement);
} }
protected onDispose(): void { protected onDispose(): void {
ReactDom.unmountComponentAtNode(this.domElement); ReactDom.unmountComponentAtNode(this._rootElement);
this._rootElement.remove();
} }
protected get dataVersion(): Version { protected get dataVersion(): Version {
return Version.parse('1.0'); return Version.parse('1.0');
} }
protected onBeforeSerialize() { protected onBeforeSerialize():void {
const { const {
sourceType, sourceType,
autoHeight, autoHeight,
@ -112,7 +116,7 @@ export default class TwitterFeedWebPart extends BaseClientSideWebPart<ITwitterFe
return true; return true;
} }
protected onPropertyPaneFieldChanged(propertyPath: string, oldValue: any, newValue: any) { protected onPropertyPaneFieldChanged(propertyPath: string, oldValue: number, newValue: number):void {
const value = newValue as number; const value = newValue as number;
if (propertyPath === 'tweetLimit') { if (propertyPath === 'tweetLimit') {
if (value === 0) { if (value === 0) {