honeymoose
/
sp-dev-fx-webparts
mirror of https://github.com/pnp/sp-dev-fx-webparts.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

#893 Semantically change code regarding async render()

This commit is contained in:
Mikael Svenson 2019-07-01 13:32:04 +02:00
parent 51e85e8b52
commit 11ab7900cd
1 changed files with 19 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
samples/react-script-editor/src/webparts/scriptEditor/ScriptEditorWebPart.ts
View File

@ -18,7 +18,7 @@ export default class ScriptEditorWebPart extends BaseClientSideWebPart<IScriptEd
this.render();
}
public async render(): Promise<void> {
public render(): void {
if (this.displayMode == DisplayMode.Read) {
if (this.properties.removePadding) {
let element = this.domElement.parentElement;
@ -38,23 +38,27 @@ export default class ScriptEditorWebPart extends BaseClientSideWebPart<IScriptEd
this.domElement.innerHTML = this.properties.script;
this.executeScript(this.domElement);
} else {
// Dynamically load the editor pane to reduce overall bundle size
const editorPopUp = await import(
/* webpackChunkName: 'scripteditor' */
'./components/ScriptEditor'
);
const element: React.ReactElement<IScriptEditorProps> = React.createElement(
editorPopUp.default,
{
script: this.properties.script,
title: this.properties.title,
save: this.save
}
);
ReactDom.render(element, this.domElement);
this.renderEditor();
}
}
private async renderEditor(){
// Dynamically load the editor pane to reduce overall bundle size
const editorPopUp = await import(
/* webpackChunkName: 'scripteditor' */
'./components/ScriptEditor'
);
const element: React.ReactElement<IScriptEditorProps> = React.createElement(
editorPopUp.default,
{
script: this.properties.script,
title: this.properties.title,
save: this.save
}
);
ReactDom.render(element, this.domElement);
}
protected get dataVersion(): Version {
return Version.parse('1.0');
}