Merge pull request #3770 from a1mery/js-advanced-commenting-upgrade-spfx-1.17.0

This commit is contained in:
Hugo Bernier 2023-06-13 10:01:31 -04:00 committed by GitHub
commit 287090985f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
9 changed files with 20759 additions and 12699 deletions

View File

@ -1,7 +1,7 @@
// For more information on how to run this SPFx project in a VS Code Remote Container, please visit https://aka.ms/spfx-devcontainer
{
"name": "SPFx 1.16.1",
"image": "docker.io/m365pnp/spfx:1.16.1",
"name": "SPFx 1.17.0",
"image": "docker.io/m365pnp/spfx:1.17.0",
// Set *default* container specific settings.json values on container create.
"settings": {},
// Add the IDs of extensions you want installed when the container is created.

View File

@ -2,7 +2,7 @@
"@microsoft/generator-sharepoint": {
"isCreatingSolution": true,
"environment": "spo",
"version": "1.16.1",
"version": "1.17.0",
"libraryName": "modern-page-comments",
"libraryId": "cfa8dbcf-b32d-4de0-a6ba-af486007c2f2",
"packageManager": "npm",
@ -11,7 +11,7 @@
"nodeVersion": "14.18.2",
"sdkVersions": {
"@microsoft/microsoft-graph-client": "3.0.2",
"@microsoft/teams-js": "2.4.1"
"@microsoft/teams-js": "2.9.1"
}
}
}

View File

@ -48,8 +48,8 @@
This sample is optimally compatible with the following environment configuration:
![SPFx 1.16.1](https://img.shields.io/badge/SPFx-1.16.1-green.svg)
![Node.js v16 | v14 | v12](https://img.shields.io/badge/Node.js-v16%20%7C%20v14%20%7C%20v12-green.svg)
![SPFx 1.17.0](https://img.shields.io/badge/SPFx-1.17.0-green.svg)
![Node.js v16.13+](https://img.shields.io/badge/Node.js-v16.13+-green.svg)
![Compatible with SharePoint Online](https://img.shields.io/badge/SharePoint%20Online-Compatible-green.svg)
![Does not work with SharePoint 2019](https://img.shields.io/badge/SharePoint%20Server%202019-Incompatible-red.svg "SharePoint Server 2019 requires SPFx 1.4.1 or lower")
![Does not work with SharePoint 2016 (Feature Pack 2)](https://img.shields.io/badge/SharePoint%20Server%202016%20(Feature%20Pack%202)-Incompatible-red.svg "SharePoint Server 2016 Feature Pack 2 requires SPFx 1.1")
@ -82,6 +82,7 @@ Version|Date|Comments
1.0.0.0|Feb 05 2020|Initial release
1.1.0.0|Oct 06, 2022|Upgraded to 1.15.2
1.2.0.0|March 09, 2023|Upgraded to 1.16.1
1.3.0.0|June 10, 2023|Upgraded to 1.17.0
## Minimal Path to Awesome

View File

@ -9,7 +9,7 @@
"This component is developed for the advanced usage of commenting the page or article etc. Page Comments lists will be created to store the comments."
],
"creationDateTime": "2020-02-05",
"updateDateTime": "2023-03-09",
"updateDateTime": "2023-06-09",
"products": [
"SharePoint"
],
@ -20,7 +20,7 @@
},
{
"key": "SPFX-VERSION",
"value": "1.16.1"
"value": "1.17.0"
},
{
"key": "PNPCONTROLS",

View File

@ -3,7 +3,7 @@
"solution": {
"name": "Advanced Comments Box",
"id": "cfa8dbcf-b32d-4de0-a6ba-af486007c2f2",
"version": "1.2.0.0",
"version": "1.3.0.0",
"includeClientSideAssets": true,
"isDomainIsolated": false,
"developer": {

View File

@ -2,5 +2,5 @@
"$schema": "https://developer.microsoft.com/json-schemas/spfx-build/spfx-serve.schema.json",
"port": 4321,
"https": true,
"initialPage": "https://enter-your-SharePoint-site/_layouts/workbench.aspx"
"initialPage": "https://{tenantDomain}/_layouts/workbench.aspx"
}

File diff suppressed because it is too large Load Diff

View File

@ -1,6 +1,6 @@
{
"name": "modern-page-comments",
"version": "1.2.0",
"version": "1.3.0",
"private": true,
"main": "lib/index.js",
"scripts": {
@ -9,26 +9,29 @@
"test": "gulp test"
},
"dependencies": {
"@microsoft/sp-adaptive-card-extension-base": "1.16.1",
"@microsoft/sp-core-library": "1.16.1",
"@microsoft/sp-lodash-subset": "1.16.1",
"@microsoft/sp-office-ui-fabric-core": "1.16.1",
"@microsoft/sp-property-pane": "1.16.1",
"@microsoft/sp-webpart-base": "1.16.1",
"@pnp/sp": "^2.0.0",
"@pnp/spfx-property-controls": "1.16.0",
"@types/jquery": "^2.0.54",
"jquery": "^3.5.0",
"moment": "^2.29.2",
"@microsoft/sp-adaptive-card-extension-base": "1.17.0",
"@microsoft/sp-core-library": "1.17.0",
"@microsoft/sp-lodash-subset": "1.17.0",
"@microsoft/sp-office-ui-fabric-core": "1.17.0",
"@microsoft/sp-property-pane": "1.17.0",
"@microsoft/sp-webpart-base": "1.17.0",
"@pnp/sp": "^2.15.0",
"@pnp/spfx-property-controls": "^3.13.0",
"@types/jquery": "^2.0.60",
"@types/react-dom": "17.0.17",
"jquery": "^3.7.0",
"moment": "^2.29.4",
"react": "17.0.1",
"react-dom": "17.0.1",
"tslib": "2.3.1"
},
"devDependencies": {
"@microsoft/eslint-config-spfx": "1.16.1",
"@microsoft/eslint-plugin-spfx": "1.16.1",
"@microsoft/eslint-config-spfx": "1.17.0",
"@microsoft/eslint-plugin-spfx": "1.17.0",
"@microsoft/rush-stack-compiler-2.9": "0.7.16",
"@microsoft/rush-stack-compiler-4.5": "0.2.2",
"@microsoft/sp-build-web": "1.16.1",
"@microsoft/sp-module-interfaces": "1.16.1",
"@microsoft/rush-stack-compiler-4.5": "0.4.0",
"@microsoft/sp-build-web": "1.17.0",
"@microsoft/sp-module-interfaces": "1.17.0",
"@rushstack/eslint-config": "2.5.1",
"@types/es6-promise": "0.0.33",
"@types/react": "17.0.45",

View File

@ -48,7 +48,11 @@ export default class PageCommentsWebPart extends BaseClientSideWebPart<IPageComm
protected async onInit(): Promise<void> {
await super.onInit();
sp.setup(this.context);
sp.setup({
spfxContext: this.context as any
}
);
}
public constructor() {
@ -259,7 +263,7 @@ export default class PageCommentsWebPart extends BaseClientSideWebPart<IPageComm
orderBy: PropertyFieldListPickerOrderBy.Title,
onPropertyChange: this.onPropertyPaneFieldChanged.bind(this),
properties: this.properties,
context: this.context,
context: this.context as any,
onGetErrorMessage: this.checkForDocumentLibrary.bind(this),
deferredValidationTime: 0,
key: 'docLibFieldId',