Merge pull request #2053 from AriGunawan/features/sharepoint-crud_update_spfx_version

sharepoint-crud: Update spfx version

samples/sharepoint-crud/.gitignore

@@ -9,6 +9,7 @@ node_modules
 # Build generated files
 dist
 lib
+release
 solution
 temp
 *.sppkg

samples/sharepoint-crud/.yo-rc.json

@@ -2,10 +2,11 @@
   "@microsoft/generator-sharepoint": {
     "isCreatingSolution": false,
     "environment": "spo",
-    "version": "1.6.0",
+    "version": "1.12.1",
     "libraryName": "sharepoint-crud",
     "libraryId": "1409e8a2-1ce4-4888-87f8-1dc377b6b62e",
     "packageManager": "npm",
+    "isDomainIsolated": false,
     "componentType": "webpart"
   }
 }

samples/sharepoint-crud/README.md

@@ -23,33 +23,38 @@ Sample Web Parts illustrating performing SharePoint CRUD operations in React, An
 
 ![Sample To do SharePoint Framework Client-Side Web Part built using Angular and ngOfficeUIFabric](./assets/preview.png)
 
-## Used SharePoint Framework Version 
+## Compatibility
-![drop](https://img.shields.io/badge/drop-1.6.0-green.svg)
+
+![SPFx 1.12.1](https://img.shields.io/badge/SPFx-1.12.1-green.svg)
+![Node.js LTS v14 | LTS v12 | LTS v10](https://img.shields.io/badge/Node.js-LTS%20v14%20%7C%20LTS%20v12%20%7C%20LTS%20v10-green.svg) 
+![SharePoint Online](https://img.shields.io/badge/SharePoint-Online-yellow.svg)
+![Teams N/A: Untested with Microsoft Teams](https://img.shields.io/badge/Teams-N%2FA-lightgrey.svg "Untested with Microsoft Teams") 
+![Workbench Hosted](https://img.shields.io/badge/Workbench-Hosted-green.svg)
 
 ## Applies to
 
-* [SharePoint Framework Developer Preview](https://docs.microsoft.com/sharepoint/dev/spfx/sharepoint-framework-overview)
+* [SharePoint Framework](https://docs.microsoft.com/sharepoint/dev/spfx/sharepoint-framework-overview)
-* [Office 365 developer tenant](https://docs.microsoft.com/sharepoint/dev/spfx/set-up-your-developer-tenant)
+* [Microsoft 365 tenant](https://docs.microsoft.com/sharepoint/dev/spfx/set-up-your-development-environment)
 
 ## Solution
 
 Solution|Author(s)
 --------|---------
-sharepoint-crud|Waldek Mastykarz (MVP, Rencore, @waldekm), Gautam Sheth (SharePoint Consultant, RapidCircle)
+sharepoint-crud|Waldek Mastykarz (MVP, Rencore, @waldekm)
+sharepoint-crud|Gautam Sheth (SharePoint Consultant, RapidCircle)
+sharepoint-crud|[Ari Gunawan](https://github.com/AriGunawan) ([@AriGunawan3023](https://twitter.com/AriGunawan3023))
 
 ## Version history
 
 Version|Date|Comments
 -------|----|--------
+1.4|September 26, 2021|Updated to SPFx 1.12.1
 1.3|November 1, 2018|Updated to SPFx 1.6.0
 1.2|March 30, 2018|Updated to SPFx 1.4.1
 1.1|March 9, 2017|Updated to SPFx GA
 1.0|September 16, 2016|Initial release
 
-## Disclaimer
+## Prerequisites
-**THIS CODE IS PROVIDED *AS IS* WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESS OR IMPLIED, INCLUDING ANY IMPLIED WARRANTIES OF FITNESS FOR A PARTICULAR PURPOSE, MERCHANTABILITY, OR NON-INFRINGEMENT.**
-
----
 
 ## Minimal Path to Awesome
 
@@ -95,4 +100,18 @@ This sample illustrates the following concepts on top of the SharePoint Framewor
   - configuring global request headers and overriding them for specific requests
   - sorting and selecting top n items from a list using the fluent API
 
+## Disclaimer
+
+**THIS CODE IS PROVIDED *AS IS* WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESS OR IMPLIED, INCLUDING ANY IMPLIED WARRANTIES OF FITNESS FOR A PARTICULAR PURPOSE, MERCHANTABILITY, OR NON-INFRINGEMENT.**
+
+## Help
+
+We do not support samples, but we this community is always willing to help, and we want to improve these samples. We use GitHub to track issues, which makes it easy for  community members to volunteer their time and help resolve issues.
+
+If you encounter any issues while using this sample, [create a new issue](https://github.com/pnp/sp-dev-fx-webparts/issues/new?assignees=&labels=Needs%3A+Triage+%3Amag%3A%2Ctype%3Abug-suspected&template=bug-report.yml&sample=sharepoint-crud&authors=@waldekmastykarz%20@AriGunawan%20gautamdsheth&title=sharepoint-crud%20-%20).
+
+For questions regarding this sample, [create a new question](https://github.com/pnp/sp-dev-fx-webparts/issues/new?assignees=&labels=Needs%3A+Triage+%3Amag%3A%2Ctype%3Abug-suspected&template=question.yml&sample=sharepoint-crud&authors=@waldekmastykarz%20@AriGunawan%20gautamdsheth&title=sharepoint-crud%20-%20).
+
+Finally, if you have an idea for improvement, [make a suggestion](https://github.com/pnp/sp-dev-fx-webparts/issues/new?assignees=&labels=Needs%3A+Triage+%3Amag%3A%2Ctype%3Abug-suspected&template=suggestion.yml&sample=sharepoint-crud&authors=@waldekmastykarz%20@AriGunawan%20gautamdsheth&title=sharepoint-crud%20-%20).
+
 <img src="https://telemetry.sharepointpnp.com/sp-dev-fx-webparts/samples/sharepoint-crud" />

samples/sharepoint-crud/assets/sample.json

@@ -9,7 +9,7 @@
       "Sample Web Parts illustrating performing SharePoint CRUD operations in React, Angular, JavaScript without any framework and using the @pnp/sp library."
     ],
     "creationDateTime": "2018-11-01",
-    "updateDateTime": "2018-11-01",
+    "updateDateTime": "2021-09-26",
     "products": [
       "SharePoint",
       "Office"
@@ -21,7 +21,7 @@
       },
       {
         "key": "SPFX-VERSION",
-        "value": "1.6.0"
+        "value": "1.12.1"
       }
     ],
     "thumbnails": [
@@ -39,6 +39,18 @@
         "pictureUrl": "https://github.com/waldekmastykarz.png",
         "name": "Waldek Mastykarz",
         "twitter": "waldekm"
+      },
+      {
+        "gitHubAccount": "gautamdsheth",
+        "company": "Rapid Circle",
+        "pictureUrl": "https://github.com/gautamdsheth.png",
+        "name": "Gautam Sheth",
+        "twitter": "gautamdsheth"
+      },
+      {
+        "gitHubAccount": "AriGunawan",
+        "pictureUrl": "https://github.com/AriGunawan.png",
+        "name": "Ari Gunawan"
       }
     ],
     "references": [

samples/sharepoint-crud/config/copy-assets.json

@@ -1,4 +1,4 @@
 {
   "$schema": "https://developer.microsoft.com/json-schemas/spfx-build/copy-assets.schema.json",
-  "deployCdnPath": "temp/deploy"
+  "deployCdnPath": "./release/assets/"
 }

samples/sharepoint-crud/config/deploy-azure-storage.json

@@ -1,6 +1,6 @@
 {
   "$schema": "https://developer.microsoft.com/json-schemas/spfx-build/deploy-azure-storage.schema.json",
-  "workingDir": "./temp/deploy/",
+  "workingDir": "./release/assets/",
   "account": "<!-- STORAGE ACCOUNT NAME -->",
   "container": "sharepoint-crud",
   "accessKey": "<!-- ACCESS KEY -->"

samples/sharepoint-crud/config/package-solution.json

@@ -3,8 +3,17 @@
   "solution": {
     "name": "sharepoint-crud-client-side-solution",
     "id": "1409e8a2-1ce4-4888-87f8-1dc377b6b62e",
-    "version": "1.0.0.0",
+    "version": "1.4.0.0",
-    "includeClientSideAssets": true
+    "includeClientSideAssets": true,
+    "skipFeatureDeployment": true,
+    "isDomainIsolated": false,
+    "developer": {
+      "name": "",
+      "websiteUrl": "",
+      "privacyUrl": "",
+      "termsOfUseUrl": "",
+      "mpnId": ""
+    }
   },
   "paths": {
     "zippedPackage": "solution/sharepoint-crud.sppkg"

samples/sharepoint-crud/gulpfile.js

@@ -1,7 +1,16 @@
 'use strict';
 
-const gulp = require('gulp');
 const build = require('@microsoft/sp-build-web');
+
 build.addSuppression(`Warning - [sass] The local CSS class 'ms-Grid' is not camelCase and will not be type-safe.`);
 
-build.initialize(gulp);
+var getTasks = build.rig.getTasks;
+build.rig.getTasks = function () {
+  var result = getTasks.call(build.rig);
+
+  result.set('serve', result.get('serve-deprecated'));
+
+  return result;
+};
+
+build.initialize(require('gulp'));

samples/sharepoint-crud/package.json

@@ -1,10 +1,8 @@
 {
   "name": "sharepoint-crud",
-  "version": "1.6.0",
+  "version": "1.4.0",
   "private": true,
-  "engines": {
+  "main": "lib/index.js",
-    "node": ">=0.10.0"
-  },
   "author": {
     "name": "Waldek Mastykarz",
     "url": "https://rencore.com"
@@ -15,31 +13,30 @@
     "test": "gulp test"
   },
   "dependencies": {
-    "@microsoft/sp-core-library": "1.6.0",
+    "@microsoft/sp-core-library": "1.12.1",
-    "@microsoft/sp-lodash-subset": "1.6.0",
+    "@microsoft/sp-lodash-subset": "1.12.1",
-    "@microsoft/sp-office-ui-fabric-core": "1.6.0",
+    "@microsoft/sp-office-ui-fabric-core": "1.12.1",
-    "@microsoft/sp-webpart-base": "1.6.0",
+    "@microsoft/sp-property-pane": "1.12.1",
+    "@microsoft/sp-webpart-base": "1.12.1",
     "@pnp/common": "^1.2.3",
     "@pnp/logging": "^1.2.3",
     "@pnp/odata": "^1.2.3",
     "@pnp/sp": "^1.2.3",
     "@types/angular": "^1.6.51",
-    "@types/es6-promise": "0.0.33",
+    "office-ui-fabric-react": "7.156.0",
-    "@types/react": "15.6.6",
+    "react": "16.9.0",
-    "@types/react-dom": "15.5.6",
+    "react-dom": "16.9.0"
-    "@types/webpack-env": "1.13.1",
-    "react": "15.6.2",
-    "react-dom": "15.6.2"
   },
   "devDependencies": {
-    "@microsoft/sp-build-web": "1.6.0",
+    "@types/react": "16.9.36",
-    "@microsoft/sp-module-interfaces": "1.6.0",
+    "@types/react-dom": "16.9.8",
-    "@microsoft/sp-webpart-workbench": "1.6.0",
+    "@microsoft/sp-build-web": "1.12.1",
-    "@types/chai": "3.4.34",
+    "@microsoft/sp-tslint-rules": "1.12.1",
-    "@types/mocha": "2.2.38",
+    "@microsoft/sp-module-interfaces": "1.12.1",
+    "@microsoft/sp-webpart-workbench": "1.12.1",
+    "@microsoft/rush-stack-compiler-3.7": "0.2.3",
+    "gulp": "~4.0.2",
     "ajv": "~5.2.2",
-    "gulp": "~3.9.1",
+    "@types/webpack-env": "1.13.1"
-    "node-sass": "^4.13.1",
-    "tslint-microsoft-contrib": "~5.0.0"
   }
 }

samples/sharepoint-crud/src/webparts/angularCrud/AngularCrudWebPart.manifest.json

@@ -10,6 +10,7 @@
   // Components that allow authors to embed arbitrary script code should set this to true.
   // https://support.office.com/en-us/article/Turn-scripting-capabilities-on-or-off-1f2c515f-5d7e-448a-9fd7-835da935584f
   "requiresCustomScript": false,
+  "supportedHosts": ["SharePointWebPart"],
   "preconfiguredEntries": [
     {
       "groupId": "5c03119e-3074-46fd-976b-c60198311f70", // Other

samples/sharepoint-crud/src/webparts/angularCrud/AngularCrudWebPart.module.scss

@@ -1,4 +1,4 @@
-@import '~@microsoft/sp-office-ui-fabric-core/dist/sass/SPFabricCore.scss';
+@import '~office-ui-fabric-react/dist/sass/References.scss';
 
 .angularCrud {
   .container {

samples/sharepoint-crud/src/webparts/angularCrud/AngularCrudWebPart.ts

@@ -1,9 +1,6 @@
 import { Version } from '@microsoft/sp-core-library';
-import {
+import { BaseClientSideWebPart } from "@microsoft/sp-webpart-base";
-  BaseClientSideWebPart,
+import { IPropertyPaneConfiguration, PropertyPaneTextField } from "@microsoft/sp-property-pane";
-  IPropertyPaneConfiguration,
-  PropertyPaneTextField
-} from '@microsoft/sp-webpart-base';
 
 import styles from './AngularCrudWebPart.module.scss';
 import * as strings from 'AngularCrudWebPartStrings';

samples/sharepoint-crud/src/webparts/noFrameworkCrud/NoFrameworkCrudWebPart.manifest.json

@@ -10,6 +10,7 @@
   // Components that allow authors to embed arbitrary script code should set this to true.
   // https://support.office.com/en-us/article/Turn-scripting-capabilities-on-or-off-1f2c515f-5d7e-448a-9fd7-835da935584f
   "requiresCustomScript": false,
+  "supportedHosts": ["SharePointWebPart"],
   "preconfiguredEntries": [
     {
       "groupId": "5c03119e-3074-46fd-976b-c60198311f70", // Other

samples/sharepoint-crud/src/webparts/noFrameworkCrud/NoFrameworkCrudWebPart.module.scss

@@ -1,4 +1,4 @@
-@import '~@microsoft/sp-office-ui-fabric-core/dist/sass/SPFabricCore.scss';
+@import '~office-ui-fabric-react/dist/sass/References.scss';
 
 .noFrameworkCrud {
   .container {

samples/sharepoint-crud/src/webparts/noFrameworkCrud/NoFrameworkCrudWebPart.ts

@@ -1,9 +1,6 @@
 import { Version } from '@microsoft/sp-core-library';
-import {
+import { BaseClientSideWebPart } from "@microsoft/sp-webpart-base";
-  BaseClientSideWebPart,
+import { IPropertyPaneConfiguration, PropertyPaneTextField } from "@microsoft/sp-property-pane";
-  IPropertyPaneConfiguration,
-  PropertyPaneTextField
-} from '@microsoft/sp-webpart-base';
 
 import styles from './NoFrameworkCrudWebPart.module.scss';
 import * as strings from 'NoFrameworkCrudWebPartStrings';

samples/sharepoint-crud/src/webparts/pnpjsCrud/PnpjsCrudWebPart.manifest.json

@@ -10,6 +10,7 @@
   // Components that allow authors to embed arbitrary script code should set this to true.
   // https://support.office.com/en-us/article/Turn-scripting-capabilities-on-or-off-1f2c515f-5d7e-448a-9fd7-835da935584f
   "requiresCustomScript": false,
+  "supportedHosts": ["SharePointWebPart"],
   "preconfiguredEntries": [
     {
       "groupId": "5c03119e-3074-46fd-976b-c60198311f70", // Other

samples/sharepoint-crud/src/webparts/pnpjsCrud/PnpjsCrudWebPart.module.scss

@@ -1,4 +1,4 @@
-@import '~@microsoft/sp-office-ui-fabric-core/dist/sass/SPFabricCore.scss';
+@import '~office-ui-fabric-react/dist/sass/References.scss';
 
 .pnpjsCrud {
   .container {

samples/sharepoint-crud/src/webparts/pnpjsCrud/PnpjsCrudWebPart.ts

@@ -1,9 +1,6 @@
 import { Version } from '@microsoft/sp-core-library';
-import {
+import { BaseClientSideWebPart } from "@microsoft/sp-webpart-base";
-  BaseClientSideWebPart,
+import { IPropertyPaneConfiguration, PropertyPaneTextField } from "@microsoft/sp-property-pane";
-  IPropertyPaneConfiguration,
-  PropertyPaneTextField
-} from '@microsoft/sp-webpart-base';
 
 import styles from './PnpjsCrudWebPart.module.scss';
 import * as strings from 'PnpjsCrudWebPartStrings';

samples/sharepoint-crud/src/webparts/reactCrud/ReactCrudWebPart.manifest.json

@@ -10,6 +10,7 @@
   // Components that allow authors to embed arbitrary script code should set this to true.
   // https://support.office.com/en-us/article/Turn-scripting-capabilities-on-or-off-1f2c515f-5d7e-448a-9fd7-835da935584f
   "requiresCustomScript": false,
+  "supportedHosts": ["SharePointWebPart"],
   "preconfiguredEntries": [
     {
       "groupId": "5c03119e-3074-46fd-976b-c60198311f70", // Other

samples/sharepoint-crud/src/webparts/reactCrud/ReactCrudWebPart.ts

@@ -1,11 +1,8 @@
 import * as React from 'react';
 import * as ReactDom from 'react-dom';
 import { Version } from '@microsoft/sp-core-library';
-import {
+import { BaseClientSideWebPart } from "@microsoft/sp-webpart-base";
-  BaseClientSideWebPart,
+import { IPropertyPaneConfiguration, PropertyPaneTextField } from "@microsoft/sp-property-pane";
-  IPropertyPaneConfiguration,
-  PropertyPaneTextField
-} from '@microsoft/sp-webpart-base';
 
 import * as strings from 'ReactCrudWebPartStrings';
 import ReactCrud from './components/ReactCrud';

samples/sharepoint-crud/src/webparts/reactCrud/components/ReactCrud.module.scss

@@ -1,4 +1,4 @@
-@import '~@microsoft/sp-office-ui-fabric-core/dist/sass/SPFabricCore.scss';
+@import '~office-ui-fabric-react/dist/sass/References.scss';
 
 .reactCrud {
   .container {

samples/sharepoint-crud/src/webparts/spPnPJsCrud/SpPnPJsCrudWebPart.manifest.json

@@ -10,6 +10,7 @@
   // Components that allow authors to embed arbitrary script code should set this to true.
   // https://support.office.com/en-us/article/Turn-scripting-capabilities-on-or-off-1f2c515f-5d7e-448a-9fd7-835da935584f
   "requiresCustomScript": false,
+  "supportedHosts": ["SharePointWebPart"],
   "preconfiguredEntries": [
     {
       "groupId": "5c03119e-3074-46fd-976b-c60198311f70", // Other

samples/sharepoint-crud/src/webparts/spPnPJsCrud/SpPnPJsCrudWebPart.module.scss

@@ -1,4 +1,4 @@
-@import '~@microsoft/sp-office-ui-fabric-core/dist/sass/SPFabricCore.scss';
+@import '~office-ui-fabric-react/dist/sass/References.scss';
 
 .spPnPJsCrud {
   .container {

samples/sharepoint-crud/src/webparts/spPnPJsCrud/SpPnPJsCrudWebPart.ts

@@ -1,9 +1,6 @@
 import { Version } from '@microsoft/sp-core-library';
-import {
+import { BaseClientSideWebPart } from "@microsoft/sp-webpart-base";
-  BaseClientSideWebPart,
+import { IPropertyPaneConfiguration, PropertyPaneTextField } from "@microsoft/sp-property-pane";
-  IPropertyPaneConfiguration,
-  PropertyPaneTextField
-} from '@microsoft/sp-webpart-base';
 
 import styles from './SpPnPJsCrudWebPart.module.scss';
 import * as strings from 'SpPnPJsCrudWebPartStrings';

samples/sharepoint-crud/tsconfig.json

@@ -1,4 +1,5 @@
 {
+  "extends": "./node_modules/@microsoft/rush-stack-compiler-3.7/includes/tsconfig-web.json",
   "compilerOptions": {
     "target": "es5",
     "forceConsistentCasingInFileNames": true,
@@ -10,25 +11,25 @@
     "experimentalDecorators": true,
     "skipLibCheck": true,
     "outDir": "lib",
+    "inlineSources": false,
+    "strictNullChecks": false,
+    "noUnusedLocals": false,
     "typeRoots": [
       "./node_modules/@types",
       "./node_modules/@microsoft"
     ],
     "types": [
-      "es6-promise",
       "webpack-env"
     ],
     "lib": [
       "es5",
       "dom",
-      "es2015.collection"
+      "es2015.collection",
+      "es2015.promise"
     ]
   },
   "include": [
-    "src/**/*.ts"
+    "src/**/*.ts",
-  ],
+    "src/**/*.tsx"
-  "exclude": [
-    "node_modules",
-    "lib"
   ]
 }

samples/sharepoint-crud/tslint.json

@@ -1,7 +1,5 @@
 {
-  "rulesDirectory": [
+  "extends": "./node_modules/@microsoft/sp-tslint-rules/base-tslint.json",
-    "tslint-microsoft-contrib"
-  ],
   "rules": {
     "class-name": false,
     "export-name": false,