honeymoose
/
sp-dev-fx-webparts
mirror of https://github.com/pnp/sp-dev-fx-webparts.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix bug by correcting the separator character (#312) 

When the existing array _renewStates is cast as a string (at the string.prototype.split() function or possibly in earlier code), that existing array is represented as "A String, representing the values of the array, separated by a comma" [quote source](https://www.w3schools.com/jsref/jsref_tostring_array.asp).
This update replaces the incorrect semi-colon separator with the correct comma separator. Without a correction, it is possible to encounter issues such as token renewal timeout or token renewal silent failure. Testing included turning on logging in adal-angular.js to observe changes.
This commit is contained in:
Kirsten 2017-10-09 01:44:57 -07:00 committed by Vesa Juvonen
parent 62d9f652ea
commit 5f9d97ca53
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
samples/react-aad-implicitflow/src/webparts/WebPartAuthenticationContext.js vendored
View File

@ -51,7 +51,7 @@ AuthenticationContext.prototype._renewToken = function (resource, callback) {
this._renewTokenSuper(resource, callback); this._renewTokenSuper(resource, callback);
var _renewStates = this._getItem('renewStates'); var _renewStates = this._getItem('renewStates');
if (_renewStates) { if (_renewStates) {
_renewStates = _renewStates.split(';'); _renewStates = _renewStates.split(',');
} }
else { else {
_renewStates = []; _renewStates = [];