From 66aaeeb5bfde7b6ababc8d0522607042a3291b39 Mon Sep 17 00:00:00 2001 From: Hugo Bernier Date: Mon, 28 Mar 2022 02:22:07 -0400 Subject: [PATCH] Updated readme, sample.json and devcontainer --- .../.devcontainer/devcontainer.json | 8 ++--- .../react-teams-membership-updater/README.md | 36 +++++++++---------- .../assets/sample.json | 4 +-- 3 files changed, 23 insertions(+), 25 deletions(-) diff --git a/samples/react-teams-membership-updater/.devcontainer/devcontainer.json b/samples/react-teams-membership-updater/.devcontainer/devcontainer.json index 325cc1797..fed4f71e9 100644 --- a/samples/react-teams-membership-updater/.devcontainer/devcontainer.json +++ b/samples/react-teams-membership-updater/.devcontainer/devcontainer.json @@ -1,7 +1,7 @@ // For more information on how to run this SPFx project in a VS Code Remote Container, please visit https://aka.ms/spfx-devcontainer { - "name": "SPFx 1.12.1", - "image": "docker.io/m365pnp/spfx:1.12.1", + "name": "SPFx 1.140.", + "image": "docker.io/m365pnp/spfx:1.14.0", // Set *default* container specific settings.json values on container create. "settings": {}, // Add the IDs of extensions you want installed when the container is created. @@ -21,7 +21,7 @@ "onAutoForward": "silent", "requireLocalPort": true }, - // Not needed for SPFx>= 1.12.1 + // Not needed for SPFx>= 1.12.1 // "5432": { // "protocol": "https", // "label": "Workbench", @@ -36,4 +36,4 @@ }, "postCreateCommand": "bash .devcontainer/spfx-startup.sh", "remoteUser": "node" -} \ No newline at end of file +} diff --git a/samples/react-teams-membership-updater/README.md b/samples/react-teams-membership-updater/README.md index 7afe11426..31f852b27 100644 --- a/samples/react-teams-membership-updater/README.md +++ b/samples/react-teams-membership-updater/README.md @@ -12,9 +12,9 @@ Used to update the membership of a team based on the contents of a CSV file, can ## Compatibility -![SPFx 1.14.0](https://img.shields.io/badge/SPFx-1.14.0-green.svg) -![Node.js v14 | v12 | v10](https://img.shields.io/badge/Node.js-v14%20%7C%20v12%20%7C%20v10-green.svg) -![SharePoint Online](https://img.shields.io/badge/SharePoint-Online-yellow.svg) +![SPFx 1.14.0](https://img.shields.io/badge/SPFx-1.14.0-green.svg) +![Node.js v14 | v12 | v10](https://img.shields.io/badge/Node.js-v14%20%7C%20v12%20%7C%20v10-green.svg) +![SharePoint Online](https://img.shields.io/badge/SharePoint-Online-yellow.svg) ![Teams Yes: Designed for Microsoft Teams](https://img.shields.io/badge/Teams-Yes-green.svg "Designed for Microsoft Teams") ![Workbench Hosted: Does not work with local workbench](https://img.shields.io/badge/Workbench-Hosted-yellow.svg "Does not work with local workbench") ![Compatible with Remote Containers](https://img.shields.io/badge/Remote%20Containers-Compatible-green.svg) @@ -29,9 +29,9 @@ This web part can be deployed to a site or as a teams personal app. This does r Uses: -- PnP React Controls -- PnP React Property Controls -- React Papaparse (CSV parsing) +* PnP React Controls +* PnP React Property Controls +* React Papaparse (CSV parsing) Solution|Author(s) --------|--------- @@ -48,21 +48,21 @@ Version|Date|Comments 1.0.8|April 22, 2021|Added support for paging on the team member list get 1.1.0|July 13, 2021|Upgraded to v1.12.1 of SPFx and v3 of pnp controls 1.2.0|August 17, 2021|Added support for populating private channels inside of a team, added support for paged list of teams from Graph, added sorting to the Team list -1.2.1|September 21, 2021| Missing '/members' in the private channel membership url +1.2.1|September 21, 2021| Missing '/members' in the private channel membership url 1.2.2|March, 24, 2022|Upgraded to SPFx v1.14 and v4 of react-papaparse ## Minimal Path to Awesome -- Clone this repository -- in the command line run: - - `npm install` - - `gulp build` - - `gulp bundle --ship` - - `gulp package-solution --ship` - - Add to AppCatalog and deploy - -> This sample can also be opened with [VS Code Remote Development](https://code.visualstudio.com/docs/remote/remote-overview). Visit https://aka.ms/spfx-devcontainer for further instructions. +* Clone this repository (or [download this solution as a .ZIP file](https://pnp.github.io/download-partial/?url=https://github.com/pnp/sp-dev-fx-webparts/tree/main/samples/react-teams-membership-updater) then unzip it) +* From your command line, change your current directory to the directory containing this sample (`react-teams-membership-updater`, located under `samples`) +* in the command line run: + * `npm install` + * `gulp build` + * `gulp bundle --ship` + * `gulp package-solution --ship` + * Add to AppCatalog and deploy +> This sample can also be opened with [VS Code Remote Development](https://code.visualstudio.com/docs/remote/remote-overview). Visit for further instructions. ## Help @@ -80,10 +80,8 @@ For questions regarding this sample, [create a new question](https://github.com/ Finally, if you have an idea for improvement, [make a suggestion](https://github.com/pnp/sp-dev-fx-webparts/issues/new?assignees=&labels=Needs%3A+Triage+%3Amag%3A%2Ctype%3Aenhancement%2Csample%3A%20react-teams-membership-updater&template=question.yml&sample=react-teams-membership-updater&authors=@techienickb&title=react-teams-membership-updater%20-%20). - ## Disclaimer **THIS CODE IS PROVIDED *AS IS* WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESS OR IMPLIED, INCLUDING ANY IMPLIED WARRANTIES OF FITNESS FOR A PARTICULAR PURPOSE, MERCHANTABILITY, OR NON-INFRINGEMENT.** - - /> diff --git a/samples/react-teams-membership-updater/assets/sample.json b/samples/react-teams-membership-updater/assets/sample.json index 8e0cf67c4..8d733a262 100644 --- a/samples/react-teams-membership-updater/assets/sample.json +++ b/samples/react-teams-membership-updater/assets/sample.json @@ -9,7 +9,7 @@ "Used to update the membership of a team based on the contents of a CSV file, can be hosted in a SharePoint site where a list can be defined for logging purposes or run inside teams as a personal app." ], "creationDateTime": "2020-04-27", - "updateDateTime": "2021-09-21", + "updateDateTime": "2022-03-24", "products": [ "SharePoint" ], @@ -20,7 +20,7 @@ }, { "key": "SPFX-VERSION", - "value": "1.12.1" + "value": "1.14.0" } ], "thumbnails": [