From 578a3e710d150f3b31394c62f8eb2d7a810a02d0 Mon Sep 17 00:00:00 2001 From: Hugo Bernier Date: Mon, 28 Mar 2022 17:55:13 -0400 Subject: [PATCH] Updated container, readme and sample.json --- .../.devcontainer/devcontainer.json | 8 ++--- samples/react-star-ratings/.gitignore | 4 +++ samples/react-star-ratings/README.md | 34 +++++++++++++++++-- samples/react-star-ratings/assets/sample.json | 4 +-- samples/react-star-ratings/package-lock.json | 16 ++++----- 5 files changed, 50 insertions(+), 16 deletions(-) diff --git a/samples/react-star-ratings/.devcontainer/devcontainer.json b/samples/react-star-ratings/.devcontainer/devcontainer.json index 325cc1797..896564300 100644 --- a/samples/react-star-ratings/.devcontainer/devcontainer.json +++ b/samples/react-star-ratings/.devcontainer/devcontainer.json @@ -1,7 +1,7 @@ // For more information on how to run this SPFx project in a VS Code Remote Container, please visit https://aka.ms/spfx-devcontainer { - "name": "SPFx 1.12.1", - "image": "docker.io/m365pnp/spfx:1.12.1", + "name": "SPFx 1.14.0", + "image": "docker.io/m365pnp/spfx:1.14.0", // Set *default* container specific settings.json values on container create. "settings": {}, // Add the IDs of extensions you want installed when the container is created. @@ -21,7 +21,7 @@ "onAutoForward": "silent", "requireLocalPort": true }, - // Not needed for SPFx>= 1.12.1 + // Not needed for SPFx>= 1.12.1 // "5432": { // "protocol": "https", // "label": "Workbench", @@ -36,4 +36,4 @@ }, "postCreateCommand": "bash .devcontainer/spfx-startup.sh", "remoteUser": "node" -} \ No newline at end of file +} diff --git a/samples/react-star-ratings/.gitignore b/samples/react-star-ratings/.gitignore index d5ab57b0f..636a3337f 100644 --- a/samples/react-star-ratings/.gitignore +++ b/samples/react-star-ratings/.gitignore @@ -31,3 +31,7 @@ obj # Styles Generated Code *.scss.ts +# .CER Certificates +*.cer +# .PEM Certificates +*.pem diff --git a/samples/react-star-ratings/README.md b/samples/react-star-ratings/README.md index d9060ce8d..ab3130c40 100644 --- a/samples/react-star-ratings/README.md +++ b/samples/react-star-ratings/README.md @@ -34,6 +34,29 @@ Enable-PnPFeature -Identity 915c240e-a6cc-49b8-8b2c-0bff8b553ed3 - **Rating Settings**: Select **Yes** - **Which voting/rating experience you would like to enable for this list?**: Select **Star Ratings** +## Minimal Path to Awesome + + + +* Clone this repository (or [download this solution as a .ZIP file](https://pnp.github.io/download-partial/?url=https://github.com/pnp/sp-dev-fx-webparts/tree/main/samples/react-star-ratings) then unzip it) +* From your command line, change your current directory to the directory containing this sample (`react-star-ratings`, located under `samples`) +* in the command line run: + * `npm install` + * `gulp serve` + +> This sample can also be opened with [VS Code Remote Development](https://code.visualstudio.com/docs/remote/remote-overview). Visit https://aka.ms/spfx-devcontainer for further instructions. + ## Solution Solution|Author(s) @@ -50,15 +73,22 @@ Version|Date|Comments ## Help -We do not support samples, but we this community is always willing to help, and we want to improve these samples. We use GitHub to track issues, which makes it easy for community members to volunteer their time and help resolve issues. + +We do not support samples, but this community is always willing to help, and we want to improve these samples. We use GitHub to track issues, which makes it easy for community members to volunteer their time and help resolve issues. If you're having issues building the solution, please run [spfx doctor](https://pnp.github.io/cli-microsoft365/cmd/spfx/spfx-doctor/) from within the solution folder to diagnose incompatibility issues with your environment. +You can try looking at [issues related to this sample](https://github.com/pnp/sp-dev-fx-webparts/issues?q=label%3A%22sample%3A%20react-star-ratings%22) to see if anybody else is having the same issues. + +You can also try looking at [discussions related to this sample](https://github.com/pnp/sp-dev-fx-webparts/discussions?discussions_q=react-star-ratings) and see what the community is saying. + If you encounter any issues while using this sample, [create a new issue](https://github.com/pnp/sp-dev-fx-webparts/issues/new?assignees=&labels=Needs%3A+Triage+%3Amag%3A%2Ctype%3Abug-suspected%2Csample%3A%20react-star-ratings&template=bug-report.yml&sample=react-star-ratings&authors=@karamem0&title=react-star-ratings%20-%20). For questions regarding this sample, [create a new question](https://github.com/pnp/sp-dev-fx-webparts/issues/new?assignees=&labels=Needs%3A+Triage+%3Amag%3A%2Ctype%3Aquestion%2Csample%3A%20react-star-ratings&template=question.yml&sample=react-star-ratings&authors=@karamem0&title=react-star-ratings%20-%20). -Finally, if you have an idea for improvement, [make a suggestion](https://github.com/pnp/sp-dev-fx-webparts/issues/new?assignees=&labels=Needs%3A+Triage+%3Amag%3A%2Ctype%3Aenhancement%2Csample%3A%20react-star-ratings&template=question.yml&sample=react-star-ratings&authors=@karamem0&title=react-star-ratings%20-%20). +Finally, if you have an idea for improvement, [make a suggestion](https://github.com/pnp/sp-dev-fx-webparts/issues/new?assignees=&labels=Needs%3A+Triage+%3Amag%3A%2Ctype%3Aenhancement%2Csample%3A%20react-star-ratings&template=suggestion.yml&sample=react-star-ratings&authors=@karamem0&title=react-star-ratings%20-%20). + + ## Disclaimer diff --git a/samples/react-star-ratings/assets/sample.json b/samples/react-star-ratings/assets/sample.json index d25db3ac6..9db20342c 100644 --- a/samples/react-star-ratings/assets/sample.json +++ b/samples/react-star-ratings/assets/sample.json @@ -9,7 +9,7 @@ "This web part demonstrates Star Ratings capablities to SharePoint News. The Ratings site collection feature provides Likes and Star Ratings, but SharePoint News provides only provides Likes. This web part can get or set ratings of the current page." ], "creationDateTime": "2021-10-07", - "updateDateTime": "2022-01-06", + "updateDateTime": "2022-03-28", "products": [ "SharePoint" ], @@ -20,7 +20,7 @@ }, { "key": "SPFX-VERSION", - "value": "1.12.1" + "value": "1.14.0" } ], "thumbnails": [ diff --git a/samples/react-star-ratings/package-lock.json b/samples/react-star-ratings/package-lock.json index acc569d3f..0120224c3 100644 --- a/samples/react-star-ratings/package-lock.json +++ b/samples/react-star-ratings/package-lock.json @@ -3466,6 +3466,14 @@ "tslib": "~1.10.0" }, "dependencies": { + "msalLegacy": { + "version": "npm:msal@1.4.12", + "resolved": "https://registry.npmjs.org/msal/-/msal-1.4.12.tgz", + "integrity": "sha512-gjupwQ6nvNL6mZkl5NIXyUmZhTiEMRu5giNdgHMh8l5EPOnV2Xj6nukY1NIxFacSTkEYUSDB47Pej9GxDYf+1w==", + "requires": { + "tslib": "^1.9.3" + } + }, "tslib": { "version": "1.10.0", "resolved": "https://registry.npmjs.org/tslib/-/tslib-1.10.0.tgz", @@ -16133,14 +16141,6 @@ "tslib": "^1.9.3" } }, - "msalLegacy": { - "version": "npm:msal@1.4.12", - "resolved": "https://registry.npmjs.org/msal/-/msal-1.4.12.tgz", - "integrity": "sha512-gjupwQ6nvNL6mZkl5NIXyUmZhTiEMRu5giNdgHMh8l5EPOnV2Xj6nukY1NIxFacSTkEYUSDB47Pej9GxDYf+1w==", - "requires": { - "tslib": "^1.9.3" - } - }, "multicast-dns": { "version": "6.2.3", "resolved": "https://registry.npmjs.org/multicast-dns/-/multicast-dns-6.2.3.tgz",