js-skype-status: upgrade to spfx 1.7.0 (#689)

* js-skype-status: upgrade to spfx 1.7.0

* js-skype-status: updated readme

samples/js-skype-status/.yo-rc.json

@@ -2,10 +2,11 @@
   "@microsoft/generator-sharepoint": {
     "isCreatingSolution": true,
     "environment": "spo",
-    "version": "1.5.0",
+    "version": "1.7.0",
     "libraryName": "skype-presence-spfx",
     "libraryId": "fcfeb3e4-bf84-4405-81c1-9c8f5dbaabe6",
     "packageManager": "npm",
-    "componentType": "webpart"
+    "componentType": "webpart",
+    "isDomainIsolated": false
   }
 }

samples/js-skype-status/README.md

@@ -28,6 +28,7 @@ js-skype-status|[Vincent Biret](https://github.com/baywet)
 
 Version|Date|Comments
 -------|----|--------
+1.3|November 18th, 2018|Upgrade to SPFx 1.7.0
 1.2|July 4th, 2018|Fixed a bug when subscribing to the current user's status
 1.1|June 22nd, 2018|Upgraded to SPFX 1.5
 1.0|December 1, 2017|Initial release

samples/js-skype-status/config/package-solution.json

@@ -5,6 +5,7 @@
     "id": "fcfeb3e4-bf84-4405-81c1-9c8f5dbaabe6",
     "version": "1.0.0.0",
     "includeClientSideAssets": true,
+    "isDomainIsolated": false,
     "skipFeatureDeployment": true
   },
   "paths": {

samples/js-skype-status/config/tslint.json

@@ -1,45 +0,0 @@
-{
-  "$schema": "https://developer.microsoft.com/json-schemas/core-build/tslint.schema.json",
-  // Display errors as warnings
-  "displayAsWarning": true,
-  // The TSLint task may have been configured with several custom lint rules
-  // before this config file is read (for example lint rules from the tslint-microsoft-contrib
-  // project). If true, this flag will deactivate any of these rules.
-  "removeExistingRules": true,
-  // When true, the TSLint task is configured with some default TSLint "rules.":
-  "useDefaultConfigAsBase": false,
-  // Since removeExistingRules=true and useDefaultConfigAsBase=false, there will be no lint rules
-  // which are active, other than the list of rules below.
-  "lintConfig": {
-    // Opt-in to Lint rules which help to eliminate bugs in JavaScript
-    "rules": {
-      "class-name": false,
-      "export-name": false,
-      "forin": false,
-      "label-position": false,
-      "member-access": true,
-      "no-arg": false,
-      "no-console": false,
-      "no-construct": false,
-      "no-duplicate-case": true,
-      "no-duplicate-variable": true,
-      "no-eval": false,
-      "no-function-expression": true,
-      "no-internal-module": true,
-      "no-shadowed-variable": true,
-      "no-switch-case-fall-through": true,
-      "no-unnecessary-semicolons": true,
-      "no-unused-expression": true,
-      "no-use-before-declare": true,
-      "no-with-statement": true,
-      "semicolon": true,
-      "trailing-comma": false,
-      "typedef": false,
-      "typedef-whitespace": false,
-      "use-named-parameter": true,
-      "valid-typeof": true,
-      "variable-name": false,
-      "whitespace": false
-    }
-  }
-}

samples/js-skype-status/package.json

@@ -11,18 +11,19 @@
     "test": "gulp test"
   },
   "dependencies": {
-    "@microsoft/sp-core-library": "1.5.0",
+    "@microsoft/sp-core-library": "1.7.0",
-    "@microsoft/sp-lodash-subset": "1.5.0",
+    "@microsoft/sp-lodash-subset": "1.7.0",
-    "@microsoft/sp-office-ui-fabric-core": "1.5.0",
+    "@microsoft/sp-office-ui-fabric-core": "1.7.0",
-    "@microsoft/sp-webpart-base": "1.5.0",
+    "@microsoft/sp-webpart-base": "1.7.0",
     "@types/es6-promise": "0.0.33",
     "@types/webpack-env": "1.13.1",
     "jquery": "^3.3.1"
   },
   "devDependencies": {
-    "@microsoft/sp-build-web": "1.5.0",
+    "@microsoft/sp-build-web": "1.7.0",
-    "@microsoft/sp-module-interfaces": "1.5.0",
+    "@microsoft/sp-module-interfaces": "1.7.0",
-    "@microsoft/sp-webpart-workbench": "1.5.0",
+    "@microsoft/sp-tslint-rules": "1.7.0",
+    "@microsoft/sp-webpart-workbench": "1.7.0",
     "@types/chai": "3.4.34",
     "@types/jquery": "^3.3.4",
     "@types/mocha": "2.2.38",

samples/js-skype-status/src/index.ts

@@ -0,0 +1 @@
+// A file is required to be in the root of the /src directory by the TypeScript compiler

samples/js-skype-status/teams_skypePresence/manifest.json

@@ -0,0 +1,47 @@
+{
+  "$schema": "https://developer.microsoft.com/en-us/json-schemas/teams/v1.2/MicrosoftTeams.schema.json",
+  "manifestVersion": "1.2",
+  "packageName": "SkypePresence",
+  "id": "cd41bf93-187a-47db-8ef1-ee84b37706ce",
+  "version": "0.1",
+  "developer": {
+    "name": "SPFx + Teams Dev",
+    "websiteUrl": "https://products.office.com/en-us/sharepoint/collaboration",
+    "privacyUrl": "https://privacy.microsoft.com/en-us/privacystatement",
+    "termsOfUseUrl": "https://www.microsoft.com/en-us/servicesagreement"
+  },
+  "name": {
+    "short": "SkypePresence"
+  },
+  "description": {
+    "short": "Demonstration webpart leveraging UCWA and presence subscription",
+    "full": "Demonstration webpart leveraging UCWA and presence subscription"
+  },
+  "icons": {
+    "outline": "tab20x20.png",
+    "color": "tab96x96.png"
+  },
+  "accentColor": "#004578",
+  "configurableTabs": [
+    {
+      "configurationUrl": "https://{teamSiteDomain}{teamSitePath}/_layouts/15/TeamsLogon.aspx?SPFX=true&dest={teamSitePath}/_layouts/15/teamshostedapp.aspx%3FopenPropertyPane=true%26teams%26componentId=cd41bf93-187a-47db-8ef1-ee84b37706ce",
+      "canUpdateConfiguration": true,
+      "scopes": [
+        "team"
+      ]
+    }
+  ],
+  "validDomains": [
+    "*.login.microsoftonline.com",
+    "*.sharepoint.com",
+    "*.sharepoint-df.com",
+    "spoppe-a.akamaihd.net",
+    "spoprod-a.akamaihd.net",
+    "resourceseng.blob.core.windows.net",
+    "msft.spoppe.com"
+  ],
+  "webApplicationInfo": {
+    "resource": "https://{teamSiteDomain}",
+    "id": "00000003-0000-0ff1-ce00-000000000000"
+  }
+}

samples/js-skype-status/tsconfig.json

@@ -1,5 +1,13 @@
 {
+  "include": [
+    "src/**/*.ts"
+  ],
+  "exclude": [
+    "node_modules",
+    "lib"
+  ],
   "compilerOptions": {
+    "outDir": "lib",
     "target": "es5",
     "forceConsistentCasingInFileNames": true,
     "module": "esnext",

samples/js-skype-status/tslint.json

@@ -1,3 +1,30 @@
 {
-    "rulesDirectory": "./config"
+  "extends": "@microsoft/sp-tslint-rules/base-tslint.json",
-}
+  "rules": {
+    "class-name": false,
+    "export-name": false,
+    "forin": false,
+    "label-position": false,
+    "member-access": true,
+    "no-arg": false,
+    "no-console": false,
+    "no-construct": false,
+    "no-duplicate-variable": true,
+    "no-eval": false,
+    "no-function-expression": true,
+    "no-internal-module": true,
+    "no-shadowed-variable": true,
+    "no-switch-case-fall-through": true,
+    "no-unnecessary-semicolons": true,
+    "no-unused-expression": true,
+    "no-use-before-declare": true,
+    "no-with-statement": true,
+    "semicolon": true,
+    "trailing-comma": false,
+    "typedef": false,
+    "typedef-whitespace": false,
+    "use-named-parameter": true,
+    "variable-name": false,
+    "whitespace": false
+  }
+}