honeymoose
/
sp-dev-fx-webparts
mirror of https://github.com/pnp/sp-dev-fx-webparts.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Call date utility function directly and not from private methods in every control

This commit is contained in:
Anders Mörtsell 2019-08-19 21:14:10 +02:00
parent 8a12f697f8
commit b4a9d56c5f
5 changed files with 10 additions and 60 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
samples/react-calendar/src/controls/Event/event.tsx
View File

@ -528,16 +528,6 @@ export class Event extends React.Component<IEventProps, IEventState> {
this.setState({ startDate: newDate });
}
/**
*
* @private
* @param date
* @memberof Event
*/
private formatDate(date: Date) {
return toLocaleShortDateString(date);
}
/**
* @private
* @param {Date} newDate
@ -669,7 +659,7 @@ export class Event extends React.Component<IEventProps, IEventState> {
value={this.state.startDate}
label={strings.StartDateLabel}
onSelectDate={this.onSelectDateStart}
formatDate={this.formatDate}
formatDate={toLocaleShortDateString}
disabled={this.state.userPermissions.hasPermissionAdd || this.state.userPermissions.hasPermissionEdit ? false : true}
hidden={this.state.showRecurrenceSeriesInfo}
/>
@ -741,7 +731,7 @@ export class Event extends React.Component<IEventProps, IEventState> {
value={this.state.endDate}
label={strings.EndDateLabel}
onSelectDate={this.onSelectDateEnd}
formatDate={this.formatDate}
formatDate={toLocaleShortDateString}
disabled={this.state.userPermissions.hasPermissionAdd || this.state.userPermissions.hasPermissionEdit ? false : true}
hidden={this.state.showRecurrenceSeriesInfo}
/>

14
samples/react-calendar/src/controls/EventRecurrenceInfoDaily/EventRecurrenceInfoDaily.tsx
View File

@ -86,16 +86,6 @@ export class EventRecurrenceInfoDaily extends React.Component<IEventRecurrenceIn
this.applyRecurrence();
}
/**
*
* @private
* @param date
* @memberof EventRecurrenceInfoDaily
*/
private formatDate(date: Date) {
return toLocaleShortDateString(date);
}
/**
*
*
@ -353,7 +343,7 @@ export class EventRecurrenceInfoDaily extends React.Component<IEventRecurrenceIn
label={strings.StartDateLabel}
value={this.state.startDate}
onSelectDate={this.onStartDateChange}
formatDate={this.formatDate}
formatDate={toLocaleShortDateString}
/>
</div>
@ -380,7 +370,7 @@ export class EventRecurrenceInfoDaily extends React.Component<IEventRecurrenceIn
ariaLabel="Select a date"
style={{ display: 'inline-block', verticalAlign: 'top', paddingLeft: '22px', }}
onSelectDate={this.onEndDateChange}
formatDate={this.formatDate}
formatDate={toLocaleShortDateString}
value={this.state.endDate}
disabled={this.state.disableEndDate}

13
samples/react-calendar/src/controls/EventRecurrenceInfoMonthly/EventRecurrenceInfoMonthly.tsx
View File

@ -112,15 +112,6 @@ export class EventRecurrenceInfoMonthly extends React.Component<IEventRecurrence
this.applyRecurrence();
}
/**
*
* @private
* @param date
* @memberof EventRecurrenceInfoMonthly
*/
private formatDate(date: Date) : string {
return toLocaleShortDateString(date);
}
/**
*
*
@ -590,7 +581,7 @@ export class EventRecurrenceInfoMonthly extends React.Component<IEventRecurrence
label={strings.StartDateLabel}
value={this.state.startDate}
onSelectDate={this.onStartDateChange}
formatDate= {this.formatDate}
formatDate= {toLocaleShortDateString}
/>
</div>
@ -617,7 +608,7 @@ export class EventRecurrenceInfoMonthly extends React.Component<IEventRecurrence
ariaLabel={strings.StartDatePlaceHolder}
style={{ display: 'inline-block', verticalAlign: 'top', paddingLeft: '22px', }}
onSelectDate={this.onEndDateChange}
formatDate={this.formatDate}
formatDate={toLocaleShortDateString}
value={this.state.endDate}
disabled={this.state.disableEndDate}
/>

15
samples/react-calendar/src/controls/EventRecurrenceInfoWeekly/EventRecurrenceInfoWeekly.tsx
View File

@ -101,17 +101,6 @@ export class EventRecurrenceInfoWeekly extends React.Component<IEventRecurrenceI
this.applyRecurrence();
}
/**
*
*
* @private
* @param date
* @memberof EventRecurrenceInfoDaily
*/
private formatDate(date: Date): string {
return toLocaleShortDateString(date);
}
/**
*
*
@ -419,7 +408,7 @@ export class EventRecurrenceInfoWeekly extends React.Component<IEventRecurrenceI
label={strings.StartDateLabel}
value={this.state.startDate}
onSelectDate={this.onStartDateChange}
formatDate={this.formatDate}
formatDate={toLocaleShortDateString}
/>
</div>
@ -446,7 +435,7 @@ export class EventRecurrenceInfoWeekly extends React.Component<IEventRecurrenceI
ariaLabel={strings.StartDatePlaceHolder}
style={{ display: 'inline-block', verticalAlign: 'top', paddingLeft: '22px', }}
onSelectDate={this.onEndDateChange}
formatDate={this.formatDate}
formatDate={toLocaleShortDateString}
value={this.state.endDate}
disabled={this.state.disableEndDate}
/>

14
samples/react-calendar/src/controls/EventRecurrenceInfoYearly/EventRecurrenceInfoYearly.tsx
View File

@ -109,16 +109,6 @@ export class EventRecurrenceInfoYearly extends React.Component<IEventRecurrenceI
this.applyRecurrence();
}
/**
*
* @private
* @param date
* @memberof EventRecurrenceInfoDaily
*/
private formatDate(date: Date): string {
return toLocaleShortDateString(date);
}
/**
*
*
@ -582,7 +572,7 @@ export class EventRecurrenceInfoYearly extends React.Component<IEventRecurrenceI
label={strings.StartDateLabel}
value={this.state.startDate}
onSelectDate={this.onStartDateChange}
formatDate={this.formatDate}
formatDate={toLocaleShortDateString}
/>
</div>
@ -609,7 +599,7 @@ export class EventRecurrenceInfoYearly extends React.Component<IEventRecurrenceI
ariaLabel={strings.StartDatePlaceHolder}
style={{ display: 'inline-block', verticalAlign: 'top', paddingLeft: '22px', }}
onSelectDate={this.onEndDateChange}
formatDate={this.formatDate}
formatDate={toLocaleShortDateString}
value={this.state.endDate}
disabled={this.state.disableEndDate}
/>