From cc74a1f5e9dedb18a6f880f8fb850db75761bedb Mon Sep 17 00:00:00 2001 From: Hugo Bernier Date: Mon, 11 Mar 2024 10:46:23 -0400 Subject: [PATCH] Added nvmrc, updated readme, sample manifest --- samples/js-advanced-commenting/.nvmrc | 1 + samples/js-advanced-commenting/README.md | 5 +++-- samples/js-advanced-commenting/assets/sample.json | 7 ++++++- 3 files changed, 10 insertions(+), 3 deletions(-) create mode 100644 samples/js-advanced-commenting/.nvmrc diff --git a/samples/js-advanced-commenting/.nvmrc b/samples/js-advanced-commenting/.nvmrc new file mode 100644 index 000000000..ff650592a --- /dev/null +++ b/samples/js-advanced-commenting/.nvmrc @@ -0,0 +1 @@ +v16.13.0 diff --git a/samples/js-advanced-commenting/README.md b/samples/js-advanced-commenting/README.md index 0bc2ca632..8acfefd7c 100644 --- a/samples/js-advanced-commenting/README.md +++ b/samples/js-advanced-commenting/README.md @@ -72,8 +72,9 @@ None ## Contributors -* [Sudharsan K.](https://github.com/sudharsank) * [Aimery Thomas](https://github.com/a1mery) +* [Sergey Shiroky](https://github.com/wideserg) +* [Sudharsan K.](https://github.com/sudharsank) ## Version history @@ -83,6 +84,7 @@ Version|Date|Comments 1.1.0.0|Oct 06, 2022|Upgraded to 1.15.2 1.2.0.0|March 09, 2023|Upgraded to 1.16.1 1.3.0.0|June 10, 2023|Upgraded to 1.17.0 +1.3.0.1|March 11, 2024|`this.pageurl` must be initialized before building `this.pastAtachmentPath` ## Minimal Path to Awesome @@ -102,7 +104,6 @@ Version|Date|Comments * Used [jquery-comments](https://viima.github.io/jquery-comments/) for comments control with some customization. * Used [Moment.js](https://momentjs.com/) for datetime formatting. - ## Video [![Building an enhanced commenting web part with SPFx](./assets/video-thumbnail.jpg)](https://www.youtube.com/watch?v=ndHMdfFscsk "Building an enhanced commenting web part with SPFx") diff --git a/samples/js-advanced-commenting/assets/sample.json b/samples/js-advanced-commenting/assets/sample.json index 272184bcc..6c40d4906 100644 --- a/samples/js-advanced-commenting/assets/sample.json +++ b/samples/js-advanced-commenting/assets/sample.json @@ -9,7 +9,7 @@ "This component is developed for the advanced usage of commenting the page or article etc. Page Comments lists will be created to store the comments." ], "creationDateTime": "2020-02-05", - "updateDateTime": "2023-06-09", + "updateDateTime": "2024-03-11", "products": [ "SharePoint" ], @@ -53,6 +53,11 @@ "gitHubAccount": "a1mery", "name": "Aimery Thomas", "pictureUrl": "https://github.com/a1mery.png" + }, + { + "gitHubAccount": "wideserg", + "name": "Sergey Shiroky", + "pictureUrl": "https://github.com/wideserg.png" } ], "references": [