honeymoose/sp-dev-fx-webparts
1
0
Fork 0
mirror of https://github.com/pnp/sp-dev-fx-webparts.git synced 2025-03-06 11:49:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Solve collapsible sections without a name

Browse Source
This commit is contained in:
Jasey Waegebaert 2022-07-19 20:57:02 +02:00
parent 9679ba3772
commit f0cf95dc3e
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
samples/react-page-navigator/src/Service/SPService.ts
View File

@ -86,14 +86,15 @@ export class SPService {
/* Traverse through all the Text web parts in the page */ /* Traverse through all the Text web parts in the page */
canvasContent1JSON.map((webPart) => { canvasContent1JSON.map((webPart) => {
if (webPart.zoneGroupMetadata && webPart.zoneGroupMetadata.type === 1) { if (webPart.zoneGroupMetadata && webPart.zoneGroupMetadata.type === 1) {
const headingValue: string = webPart.zoneGroupMetadata.displayName; const headingIsEmpty: boolean = webPart.zoneGroupMetadata.displayName === '';
const headingValue: string = headingIsEmpty ? 'Empty Heading' : webPart.zoneGroupMetadata.displayName ;
const anchorUrl: string = this.GetAnchorUrl(headingValue); const anchorUrl: string = this.GetAnchorUrl(headingValue);
this.allUrls.push(anchorUrl); this.allUrls.push(anchorUrl);
// Limitation! This will break with headings containing the same name // Limitation! This will break with headings containing the same name
if (anchorLinks.filter(x => x.name === headingValue).length === 0) { if (anchorLinks.filter(x => x.name === headingValue).length === 0) {
// Add link to nav element // Add link to nav element
anchorLinks.push({ name: headingValue, key: anchorUrl, url: anchorUrl, links: [], isExpanded: webPart.zoneGroupMetadata.isExpanded }); anchorLinks.push({ name: headingValue, key: anchorUrl, url: !headingIsEmpty && anchorUrl, links: [], isExpanded: webPart.zoneGroupMetadata.isExpanded });
} }
} }
@ -101,7 +102,8 @@ export class SPService {
const HTMLString: string = webPart.innerHTML; const HTMLString: string = webPart.innerHTML;
const hasCollapsableHeader: boolean = webPart.zoneGroupMetadata && const hasCollapsableHeader: boolean = webPart.zoneGroupMetadata &&
webPart.zoneGroupMetadata.type === 1 && webPart.zoneGroupMetadata.type === 1 &&
anchorLinks.filter(x => x.name === webPart.zoneGroupMetadata.displayName).length === 1; ( anchorLinks.filter(x => x.name === webPart.zoneGroupMetadata.displayName).length === 1 ||
webPart.zoneGroupMetadata.displayName === '' );
const htmlObject: HTMLDivElement = document.createElement('div'); const htmlObject: HTMLDivElement = document.createElement('div');
htmlObject.innerHTML = HTMLString; htmlObject.innerHTML = HTMLString;